From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0DBE13F4834;
	Mon, 15 Jun 2026 12:30:55 +0000 (UTC)
Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18
ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;
	t=1781526666; cv=none; b=LhTW1LsH5AYE91qU8G5zOzn+tqq2uIk3nCHf8y8vUAiB5I7BNKeyVVEg707FZliQcGKYtAB4GFTqktUdWWsJZBccNK4hpK3Qu9ap2GP9WypHDqK6AmM1TIQPjwbk4PT+n2ZwHkZBzgJhGmMm8SAssn0tswXOllBdX46bJfil5Jc=
ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org;
	s=arc-20240116; t=1781526666; c=relaxed/simple;
	bh=n6rVU8hZkAoVBUdjEyEiZj3byk7yaw6Ywu1ouXmXVIA=;
	h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version:
	 Content-Type:Content-Disposition:In-Reply-To; b=kpm3uBUtD2lykmcycMEvaot1DaaCJ2n7rA00Oe30zwptrhe0N/dPhSv72FeOXfM/J9faSo8eivNE3mX8B/ZmlXz4TmA29WBPa+JTOSkvSIlbJ7oeQdRjAdEHUAkUdoPurCAqqrYpmcPuwJf3jloxKsEp05txb9EFYX0ASTcatmM=
ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=gzlLG8Ha; arc=none smtp.client-ip=100.103.45.18
Authentication-Results: smtp.subspace.kernel.org;
	dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="gzlLG8Ha"
Received: by smtp.kernel.org (Postfix) with ESMTPSA id A001A1F0157E;
	Mon, 15 Jun 2026 12:30:52 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org;
	s=k20260515; t=1781526655;
	bh=bjUsrlAJzA2g2sG67p8ulOzileDSPaUvPy5l18Mliyo=;
	h=Date:From:To:Cc:Subject:References:In-Reply-To;
	b=gzlLG8HabWMs4R8b2QuZkBDTDfN0eShe3CG5Bd4GqnDvqTseKV08S6lXIS0PWGUPw
	 Wz55HtTI1EQjOmkLcl3He9hOMhTrK1UFowD/laDWymB+DK759obCLWNJdo6iWZrcp2
	 6qsOImUqAdrdx4t7oiTty8hJwYJsLq2D9A0Fnn6VuOtnxv24JjF5oXvkttFdN3etcI
	 sugLR54CzIOjrqQXWigBP5G92qKouteZo2OXUIVusclHjRVfMR9FW8PA1wN0wbbbr/
	 2sXdtNHZptlAL7tlD5ra/2HZ3/4nPVa8FfDiobLZB21wGy7lUarc5j82wGOQnghLA5
	 JO/fNOg05FsbA==
Date: Mon, 15 Jun 2026 13:30:50 +0100
From: Simon Horman <horms@kernel.org>
To: lirongqing <lirongqing@baidu.com>
Cc: Saeed Mahameed <saeedm@nvidia.com>, Leon Romanovsky <leon@kernel.org>,
	Tariq Toukan <tariqt@nvidia.com>, Mark Bloch <mbloch@nvidia.com>,
	Andrew Lunn <andrew+netdev@lunn.ch>,
	"David S . Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
	netdev@vger.kernel.org, linux-rdma@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] net/mlx5: Free steering tag data on release
Message-ID: <20260615123050.GJ712698@horms.kernel.org>
References: <20260613153725.1874-1-lirongqing@baidu.com>
Precedence: bulk
X-Mailing-List: netdev@vger.kernel.org
List-Id: <netdev.vger.kernel.org>
List-Subscribe: <mailto:netdev+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:netdev+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20260613153725.1874-1-lirongqing@baidu.com>

On Sat, Jun 13, 2026 at 11:37:25PM +0800, lirongqing wrote:
> From: Li RongQing <lirongqing@baidu.com>
> 
> mlx5_st_alloc_index() allocates an mlx5_st_idx_data object for
> each new steering tag table index and stores it in the xarray.
> When the last user releases the index, mlx5_st_dealloc_index()
> removes the entry from the xarray but did not free the backing
> object, leaking memory.
> 
> Free idx_data after erasing the xarray entry once the refcount
> reaches zero.
> 
> Fixes: 888a7776f4fb0 ("net/mlx5: Add support for device steering tag")
> Signed-off-by: Li RongQing <lirongqing@baidu.com>

Reviewed-by: Simon Horman <horms@kernel.org>