From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from szelinsky.de (szelinsky.de [85.214.127.56]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 323A519F11B; Mon, 15 Jun 2026 18:07:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=85.214.127.56 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781546865; cv=none; b=OaZUDM2ULwRnHyT4gZaQ1xo0Hu/1HZl1e/Cv1dJAcKgCzH1Yc7vRPlPADDBxWDjPujNcziQN5UxLuvFH0NGfrfS4aQBncJ7l2VglIR+FEBah7pE0QiiZz3+yhC67VIrAhjkPIK8bbkseabABOn0Dh3sHr9fIfZ9SI1W3HUdJHIY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781546865; c=relaxed/simple; bh=OejRFYEqQHsqfbQLqhS/C+/zcfW3LEMjVaQAJ6BNhuw=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=sZn0kCOjxzuWTaLtQVIz7TTGOkedVc9sWf9+ykqXcwGOVXzzc0hPNE74zN3d6N7Zr5QFc2p53czKtRBIOBMzQ59yJzyw2aE05HBmOyZri8zivgfIH7GWh3DKtoHRWQ3ULB8D3qBODBLvTVYRXb3QhlqczJgnh+9S3LWaWQibtyE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=szelinsky.de; spf=pass smtp.mailfrom=szelinsky.de; dkim=temperror (0-bit key) header.d=szelinsky.de header.i=@szelinsky.de header.b=FMxk83QG; arc=none smtp.client-ip=85.214.127.56 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=szelinsky.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=szelinsky.de Authentication-Results: smtp.subspace.kernel.org; dkim=temperror (0-bit key) header.d=szelinsky.de header.i=@szelinsky.de header.b="FMxk83QG" Received: from localhost (localhost [127.0.0.1]) by szelinsky.de (Postfix) with ESMTP id E46A7E83A26; Mon, 15 Jun 2026 19:59:53 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=szelinsky.de; s=mail; t=1781546393; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=nVdAzhnInFA2Y3/7I56HSI2bZc6O/wA+N/9tYWb3XK8=; b=FMxk83QGvrjFMjz+pyafd8ZVbxPgghPZuvdKtzUOr42ccBvOTweJrZT5Btg40QoZohvdX6 M87/5vvRpyC2i02gIm21s5NKhXw669fTCJUbOZ5HfN+gAqeCR+4x5x4vkPhOypdBhMMu4n Ecs1t1XuP6+dfb3yetjhdYg/l+tUkZ/6s8RQVhXrVqhoGyrnV2OIdEeJblSJKHKZD+Ag1r KA6zrhP1gNMGzKKZJX9kgvctNqbqaGV4t06VRPmuiiMMafe/5bbIcMNjXCcH5qa9Zj05za OD099Uwjgbh025KD442tFmwkv6XS5yQfR131xG8bUTH3I8mbvvcEf94AMBd/6A== X-Virus-Scanned: Debian amavis at szelinsky.de Received: from szelinsky.de ([127.0.0.1]) by localhost (szelinsky.de [127.0.0.1]) (amavis, port 10025) with ESMTP id eTcQe8DxYgUL; Mon, 15 Jun 2026 19:59:53 +0200 (CEST) Received: from p14sgen5.. (unknown [91.25.97.186]) by szelinsky.de (Postfix) with ESMTPSA; Mon, 15 Jun 2026 19:59:53 +0200 (CEST) From: Carlo Szelinsky To: Simon Horman Cc: Oleksij Rempel , Kory Maincent , Andrew Lunn , "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Carlo Szelinsky Subject: Re: [PATCH net 1/2] net: pse-pd: disable IRQ before freeing PI data in unregister Date: Mon, 15 Jun 2026 19:59:49 +0200 Message-ID: <20260615175949.827693-1-github@szelinsky.de> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260601162506.GY2256768@horms.kernel.org> References: <20260601162506.GY2256768@horms.kernel.org> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Hi Simon, Thanks, this all makes sense. > > Did I miss a path where the worker reaches pcdev->pi? > > I am concerned that this can occur if pse_send_ntf_worker() > calls pse_control_put(). In which case __pse_control_release() > may run, which accesses psec->pcdev->pi[psec->id].admin_state_enabled. You're right, I was wrong. The worker does reach pcdev->pi through pse_control_put() -> __pse_control_release(). For v2 I'll move cancel_work_sync(&pcdev->ntf_work) before pse_release_pis() and fix the patch 1 commit message, which wrongly claims the worker never touches pcdev->pi. > I wonder if you may have missed the AI-generated review of it that I > forwarded. I did, thanks for the hint. I went over it again more carefully now. :-) Both [High] points seem to be valid, I'll reply to them inline on the 2/2 review thread so the discussion stays where it was raised. > For these last three pre-existing items I think it's best to handle > them separately. Agreed, I'll send those on their own later. Thanks, Carlo