From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 42D003806C5; Tue, 16 Jun 2026 21:24:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781645042; cv=none; b=eDRb+zfJklBtUiDgLSa/D8Ps2UkT/8g2RMOxUJDRy/pH2dOszMa9HBH/E/+2OtnNh0vMF8EJigh9Qc22JAgDBs2UhGHLXWhXrg9394YCpap0Ohxff8LVylxCnaaPXqqHGanZPOnZa2TH14jvXWnPbZA9Q+FwY/Z7nB5tnyM20wQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781645042; c=relaxed/simple; bh=dnnMlt3NUnfVd8e98ce32rX8ijCUFqeuBErQQK8v++o=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=OOFE3c/h4b1ooWkTmiMvuHmvJIa4p7w+e9KpIpsZKwLXWzxWvQ18I9ytv1b71kjo2St2Tf/Gh79OwlhSlGlFwmSFL26rQVZDcBHYZoXg0UvQnQJsrBkZwSX4Phc2fQ2ZT/HGSRAn/RwPCWC13HwnVoqUxWAC3g5MxDiBqAemyYE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=Nd1TD6O5; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="Nd1TD6O5" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 58B6B1F000E9; Tue, 16 Jun 2026 21:24:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1781645040; bh=s8T3aYLI5DrbNJ7kwq8RJnZMCafMwusd1xaM5iiYTs0=; h=Date:From:To:Cc:Subject:In-Reply-To:References; b=Nd1TD6O5S2qKlg41LTPvwRTWI0/7TIpZqhKSZbT/fj+EEqkqb+BNfQhD73YkUmFrD rG73uHU+IwquWgLtqpKGhJKJXFu6cRE4SprWVUA/SPVvFbXhpJnARLGpU29qPYsxgl 3/Efh6aT7dVAYq59chbPV0E48bgOmapD/DEplPOuKYWeZs6ybF+kpIF/eAmoC17CYP g2Jry4Fcl+ygOHJZ81+EiLs396mhq+GmOAkwRhuFaO4cR5yX9YWySEkquNvdjepXdG bD6Nhk6/yC5Dt7el/jS3PLv+3bVWcqdVH+hzq+OrefHcdvA4VJt3Al1H5cs6YN00Pz frm3zw6BVlcXg== Date: Tue, 16 Jun 2026 14:23:59 -0700 From: Jakub Kicinski To: Sabrina Dubroca Cc: syzbot , davem@davemloft.net, edumazet@google.com, horms@kernel.org, john.fastabend@gmail.com, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, pabeni@redhat.com, syzkaller-bugs@googlegroups.com Subject: Re: [syzbot] [net?] WARNING in tls_err_abort Message-ID: <20260616142359.43300727@kernel.org> In-Reply-To: References: <6a315d48.b0403584.28d0ff.0002.GAE@google.com> <20260616082816.4dd0f035@kernel.org> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Tue, 16 Jun 2026 23:00:54 +0200 Sabrina Dubroca wrote: > 2026-06-16, 08:28:16 -0700, Jakub Kicinski wrote: > > On Tue, 16 Jun 2026 17:19:22 +0200 Sabrina Dubroca wrote: > > > I suspect err==0, and sock_error() consumed sk_err in between (the > > > alternative would be err > 0). > > > > > > Something like this? > > > > Makes sense, but what's eating sk_err? > > The 2 remaining sock_error() in tls_rx_rec_wait()? [1] How did that elude my grep.. > > Don't we depend on it being set > > to avoid further state transitions once we hit a crypto error? > > I kind of thought so too. In which case the question is whether we should try to remove the sock_error() instead? (stating the obvious I guess) > > I thought that's why we don't consume sk_err in recvmsg and sendmsg in > > the first place (we are not calling sock_error() anywhere) > > Umm... > [1] https://git.kernel.org/pub/scm/linux/kernel/git/netdev/net-next.git/tree/net/tls/tls_sw.c#n1095 >