From: Lovekesh Solanki <lovekeshsolanki00@gmail.com>
To: anthony.l.nguyen@intel.com
Cc: przemyslaw.kitszel@intel.com, andrew+netdev@lunn.ch,
davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
pabeni@redhat.com, netdev@vger.kernel.org,
Lovekesh Solanki <lovekeshsolanki00@gmail.com>
Subject: [PATCH] e1000: Remove redundant else after return
Date: Wed, 17 Jun 2026 02:30:08 +0530 [thread overview]
Message-ID: <20260616210008.109635-1-lovekeshsolanki00@gmail.com> (raw)
The else branch is needless because the preceding branch
unconditionally returns -ENOMEM
Reduce nesting by removing unnecessary else
Signed-off-by: Lovekesh Solanki <lovekeshsolanki00@gmail.com>
---
drivers/net/ethernet/intel/e1000/e1000_main.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/net/ethernet/intel/e1000/e1000_main.c b/drivers/net/ethernet/intel/e1000/e1000_main.c
index 9b09eb144b81..3d97e952c916 100644
--- a/drivers/net/ethernet/intel/e1000/e1000_main.c
+++ b/drivers/net/ethernet/intel/e1000/e1000_main.c
@@ -1546,11 +1546,10 @@ static int e1000_setup_tx_resources(struct e1000_adapter *adapter,
"for the transmit descriptor ring\n");
vfree(txdr->buffer_info);
return -ENOMEM;
- } else {
+ }
/* Free old allocation, new allocation was successful */
dma_free_coherent(&pdev->dev, txdr->size, olddesc,
olddma);
- }
}
memset(txdr->desc, 0, txdr->size);
--
2.54.0
next reply other threads:[~2026-06-16 21:01 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-16 21:00 Lovekesh Solanki [this message]
2026-06-16 21:51 ` [PATCH] e1000: Remove redundant else after return Andrew Lunn
2026-06-17 7:58 ` Lovekesh Solanki
2026-06-17 9:36 ` Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260616210008.109635-1-lovekeshsolanki00@gmail.com \
--to=lovekeshsolanki00@gmail.com \
--cc=andrew+netdev@lunn.ch \
--cc=anthony.l.nguyen@intel.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=przemyslaw.kitszel@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox