From: Stephen Hemminger <stephen@networkplumber.org>
To: Louis Scalbert <louis.scalbert@6wind.com>
Cc: netdev@vger.kernel.org, andrew+netdev@lunn.ch, jv@jvosburgh.net,
edumazet@google.com, kuba@kernel.org, pabeni@redhat.com,
fbl@redhat.com, andy@greyhouse.net, shemminger@vyatta.com,
maheshb@google.com, jonas.gorski@gmail.com, horms@kernel.org
Subject: Re: [PATCH iproute2-next v4] ip/bond: add lacp_strict support
Date: Wed, 17 Jun 2026 08:01:23 -0700 [thread overview]
Message-ID: <20260617080123.3afba0aa@phoenix.local> (raw)
In-Reply-To: <20260617130314.3893243-1-louis.scalbert@6wind.com>
On Wed, 17 Jun 2026 15:03:14 +0200
Louis Scalbert <louis.scalbert@6wind.com> wrote:
> + } else if (matches(*argv, "lacp_strict") == 0) {
> + NEXT_ARG();
> + if (get_index(lacp_strict_tbl, *argv) < 0)
> + invarg("invalid lacp_strict", *argv);
> +
> + lacp_strict = get_index(lacp_strict_tbl, *argv);
> + addattr8(n, 1024, IFLA_BOND_LACP_STRICT, lacp_strict);
> } else if (matches(*argv, "tlb_dynamic_lb") == 0) {
> NEXT_ARG();
> if (get_u8(&tlb_dynamic_lb, *argv, 0)) {
Why not use parse_on_off like other code in this file.
> @@ -642,6 +658,15 @@ static void bond_print_opt(struct link_util *lu, FILE *f, struct rtattr *tb[])
> "all_slaves_active %u ",
> rta_getattr_u8(tb[IFLA_BOND_ALL_SLAVES_ACTIVE]));
>
> + if (tb[IFLA_BOND_LACP_STRICT]) {
> + __u8 lacp_strict = rta_getattr_u8(tb[IFLA_BOND_LACP_STRICT]);
> + print_string(PRINT_FP,
> + "lacp_strict",
> + "lacp_strict %s ",
> + get_name(lacp_strict_tbl, lacp_strict));
> + print_bool(PRINT_JSON, "lacp_strict", NULL, lacp_strict);
> + }
> +
Why not use print_on_off like other options
prev parent reply other threads:[~2026-06-17 15:01 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-17 13:03 [PATCH iproute2-next v4] ip/bond: add lacp_strict support Louis Scalbert
2026-06-17 15:01 ` Stephen Hemminger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260617080123.3afba0aa@phoenix.local \
--to=stephen@networkplumber.org \
--cc=andrew+netdev@lunn.ch \
--cc=andy@greyhouse.net \
--cc=edumazet@google.com \
--cc=fbl@redhat.com \
--cc=horms@kernel.org \
--cc=jonas.gorski@gmail.com \
--cc=jv@jvosburgh.net \
--cc=kuba@kernel.org \
--cc=louis.scalbert@6wind.com \
--cc=maheshb@google.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=shemminger@vyatta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox