From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from violet.fr.zoreil.com (violet.fr.zoreil.com [92.243.8.30]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5D0C62EEE74 for ; Wed, 17 Jun 2026 22:26:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=92.243.8.30 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781735165; cv=none; b=VVCe8CAmEkD72B4+XWViOIQfONROizjB9uxJKtxD3UTw0YTM00BDOpnkPKUFQoDxjH+ZsBwsF7sVXLq1+bQqmN0JiSgKTKlabPDKJjFpYNOosB6WegklEdonE6Ckz6x3+fdfrUV8qYG04V++pllLWCIpALgkE/eKMZ3BBVOXS6g= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781735165; c=relaxed/simple; bh=ek5YPfIi3miySu+OGgINN4xoG2HI4oM67+yeKK4gpt0=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=gkwodl3s4skDdqYgeBnmCbqov6D4wc/BP1ESL76sfbc9BkIua5lnroW9FyyHfPKoPGQr9oOUz2jLhJM9QqeMp8JRym6aBPpVztfkozhVTntzwBq/4qwCTlquQwmly3mv3COHcDGyjet89EnFjlRJkfF1tHJ2SSB/UcvHQhckBP0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=fr.zoreil.com; spf=pass smtp.mailfrom=fr.zoreil.com; dkim=pass (1024-bit key) header.d=fr.zoreil.com header.i=@fr.zoreil.com header.b=FF3otWbI; arc=none smtp.client-ip=92.243.8.30 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=fr.zoreil.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=fr.zoreil.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=fr.zoreil.com header.i=@fr.zoreil.com header.b="FF3otWbI" Received: from violet.fr.zoreil.com ([127.0.0.1]) by violet.fr.zoreil.com (8.17.1/8.17.1) with ESMTP id 65HMPNrF3712048; Thu, 18 Jun 2026 00:25:23 +0200 DKIM-Filter: OpenDKIM Filter v2.11.0 violet.fr.zoreil.com 65HMPNrF3712048 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fr.zoreil.com; s=v20220413; t=1781735123; bh=Oe/iXlh5kEu7zfbfDHyD/ASRNxkD+zGQJQ4wJjxLfmk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=FF3otWbI1wigC2a1xxSwJwujep3hC4tJGWmT/mKZCyagyHuCj5OlT2L26Ni+7lflx fs+anZT3NqdYSfGub6EXXT5zGm358K0gugWDbaf2DT0KwYBkKOAWc2nnB2IdAXYszX FC6RMplpEaX+k/lupbUkeVLNVnarmgknRXS9HNfE= Received: (from romieu@localhost) by violet.fr.zoreil.com (8.17.1/8.17.1/Submit) id 65HMPNRp3712047; Thu, 18 Jun 2026 00:25:23 +0200 Date: Thu, 18 Jun 2026 00:25:22 +0200 From: Francois Romieu To: Atharva Potdar Cc: hkallweit1@gmail.com, nic_swsd@realtek.com, andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, netdev@vger.kernel.org Subject: Re: [PATCH net-next] r8169: migrate Rx path to page_pool Message-ID: <20260617222522.GA3712043@electric-eye.fr.zoreil.com> References: <20260614054137.32181-1-atharvapotdar07@gmail.com> <20260614220934.GA3575431@electric-eye.fr.zoreil.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Organisation: Land of Sunshine Inc. Atharva Potdar : [...] > Francois: > > You may consider fdd7b4c3302c93f6833e338903ea77245eb510b4 and some related > > changes around that time. > > I am sorry but I don't fully understand the context of this commit or > the behaviour it addresses. Could you please help me regarding what I > need to watch out for this change? It should be clearer with c0cd884af045338476b8e69a61fceb3f34ff22f1 (and may be 6f0333b8fde44b8c04a53b2461504f0e8f1cebe6 as well). Old chipsets did not correctly implement receive buffer size limit. I have no idea how mildly recent ones (< 15 years) behave. Reinstatement of the bug on old chipset imho deserves some warning. -- Ueimor