From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.21]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2251E2EBDDE for ; Wed, 17 Jun 2026 20:03:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.21 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781726598; cv=none; b=CCJIo9iPkjTWQ2WflU7tjCik6O1hwQEet1Idg/S40Ib+9lUe+oVMBG54aAxpk7sgiY9dU+OzSO6mO3I1r0zzhY7jtTPMsiDpP66T2/38QBsa+Gf0WKhIyldhu+tl1gMovIvV9UVLehC8yXS9GtSLLiRx5JN14NRfDkYBkxalSF0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781726598; c=relaxed/simple; bh=RX26t8axNHR2+20GoC02Y1V789ZRLXoB4J2FYEoPhOI=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=hQddvg4ndUdZHH5xL077kCE7QuNw6b7FfCM2/De0jWJURV+0wmjby8vKjDEhtR2dcGpRlrKvOMcU4AfrT1k7I1YEDWuSN4Zq6NdcpJH/HwZ/KQ1OnlEpvVpPn0IBrXGxDrV14GtgDO8IV98gMBjwCT4bDaSGv88PBAfNVLZbB6M= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=OK8FOx6l; arc=none smtp.client-ip=198.175.65.21 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="OK8FOx6l" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1781726596; x=1813262596; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=RX26t8axNHR2+20GoC02Y1V789ZRLXoB4J2FYEoPhOI=; b=OK8FOx6lyGzj5ocK1xxRLShHn+7nLG7k6S2ONeLeO5S12Adg2fMG/c2W s288dO+Kv+5Qw5WUIPxxlzn4ojdaWKUA2Y+OvyRFEWO6ZtfBpxS1e3HP0 8xtwaXkoqimE77KQS6VbBDV3LT6HizIWbHeWHh1zRqmtXnRVpGIVVgelz SuyVamoPQCr6ke/qhP0stHGtoSknG58jHJ3qSuteHRhzBvuZuAPzoz9nu 00yy80UFeWzpvx/9UqmSAtuvYxKyvTUzyIQ3fE6eJJwCOCnL1Fv+oog9O IVN8hesYjVGb8JW9qwWOqno/CguW7FRHyvKHw3X7r42hPhHdxNT65U1o8 A==; X-CSE-ConnectionGUID: KDFrm9VkR+qaMBsrQtjh4Q== X-CSE-MsgGUID: lvnquzDrSXy/W0OSml2WFQ== X-IronPort-AV: E=McAfee;i="6800,10657,11820"; a="82435959" X-IronPort-AV: E=Sophos;i="6.24,210,1774335600"; d="scan'208";a="82435959" Received: from orviesa001.jf.intel.com ([10.64.159.141]) by orvoesa113.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Jun 2026 13:03:15 -0700 X-CSE-ConnectionGUID: oZ/Ntua8Tzmscqcny8xYcg== X-CSE-MsgGUID: BgpdpGDZSzqrbucK7elsTg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.24,210,1774335600"; d="scan'208";a="286268578" Received: from lkp-server01.sh.intel.com (HELO f0d55cb201f0) ([10.239.97.150]) by orviesa001.jf.intel.com with ESMTP; 17 Jun 2026 13:03:12 -0700 Received: from kbuild by f0d55cb201f0 with local (Exim 4.98.2) (envelope-from ) id 1wZwTc-00000000Uwg-3rli; Wed, 17 Jun 2026 20:03:08 +0000 Date: Thu, 18 Jun 2026 04:02:44 +0800 From: kernel test robot To: Lovekesh Solanki , anthony.l.nguyen@intel.com Cc: oe-kbuild-all@lists.linux.dev, przemyslaw.kitszel@intel.com, andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, netdev@vger.kernel.org, Lovekesh Solanki Subject: Re: [PATCH] e1000: Remove redundant else after return Message-ID: <202606180301.nRhk5lMR-lkp@intel.com> References: <20260616210008.109635-1-lovekeshsolanki00@gmail.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260616210008.109635-1-lovekeshsolanki00@gmail.com> Hi Lovekesh, kernel test robot noticed the following build warnings: [auto build test WARNING on tnguy-next-queue/dev-queue] [also build test WARNING on tnguy-net-queue/dev-queue linus/master v7.1 next-20260616] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Lovekesh-Solanki/e1000-Remove-redundant-else-after-return/20260617-051633 base: https://git.kernel.org/pub/scm/linux/kernel/git/tnguy/next-queue.git dev-queue patch link: https://lore.kernel.org/r/20260616210008.109635-1-lovekeshsolanki00%40gmail.com patch subject: [PATCH] e1000: Remove redundant else after return config: powerpc-randconfig-r073-20260617 (https://download.01.org/0day-ci/archive/20260618/202606180301.nRhk5lMR-lkp@intel.com/config) compiler: clang version 23.0.0git (https://github.com/llvm/llvm-project e19d1f51a2c80b63cd8ca95bcc757b7077112808) smatch: v0.5.0-9185-gbcc58b9c If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot | Closes: https://lore.kernel.org/oe-kbuild-all/202606180301.nRhk5lMR-lkp@intel.com/ New smatch warnings: drivers/net/ethernet/intel/e1000/e1000_main.c:1551 e1000_setup_tx_resources() warn: inconsistent indenting Old smatch warnings: arch/powerpc/include/asm/checksum.h:94 csum_tcpudp_nofold() warn: inconsistent indenting vim +1551 drivers/net/ethernet/intel/e1000/e1000_main.c ^1da177e4c3f41 drivers/net/e1000/e1000_main.c Linus Torvalds 2005-04-16 1491 ^1da177e4c3f41 drivers/net/e1000/e1000_main.c Linus Torvalds 2005-04-16 1492 /** ^1da177e4c3f41 drivers/net/e1000/e1000_main.c Linus Torvalds 2005-04-16 1493 * e1000_setup_tx_resources - allocate Tx resources (Descriptors) ^1da177e4c3f41 drivers/net/e1000/e1000_main.c Linus Torvalds 2005-04-16 1494 * @adapter: board private structure 581d708eb47ccc drivers/net/e1000/e1000_main.c Mallikarjuna R Chilakala 2005-10-04 1495 * @txdr: tx descriptor ring (for a specific queue) to setup ^1da177e4c3f41 drivers/net/e1000/e1000_main.c Linus Torvalds 2005-04-16 1496 * ^1da177e4c3f41 drivers/net/e1000/e1000_main.c Linus Torvalds 2005-04-16 1497 * Return 0 on success, negative on failure ^1da177e4c3f41 drivers/net/e1000/e1000_main.c Linus Torvalds 2005-04-16 1498 **/ 6479884509e6cd drivers/net/e1000/e1000_main.c Joe Perches 2008-07-11 1499 static int e1000_setup_tx_resources(struct e1000_adapter *adapter, 581d708eb47ccc drivers/net/e1000/e1000_main.c Mallikarjuna R Chilakala 2005-10-04 1500 struct e1000_tx_ring *txdr) ^1da177e4c3f41 drivers/net/e1000/e1000_main.c Linus Torvalds 2005-04-16 1501 { ^1da177e4c3f41 drivers/net/e1000/e1000_main.c Linus Torvalds 2005-04-16 1502 struct pci_dev *pdev = adapter->pdev; ^1da177e4c3f41 drivers/net/e1000/e1000_main.c Linus Torvalds 2005-04-16 1503 int size; ^1da177e4c3f41 drivers/net/e1000/e1000_main.c Linus Torvalds 2005-04-16 1504 580f321d8498f1 drivers/net/ethernet/intel/e1000/e1000_main.c Florian Westphal 2014-09-03 1505 size = sizeof(struct e1000_tx_buffer) * txdr->count; 89bf67f1f080c9 drivers/net/e1000/e1000_main.c Eric Dumazet 2010-11-22 1506 txdr->buffer_info = vzalloc(size); 14f8dc49532f76 drivers/net/ethernet/intel/e1000/e1000_main.c Joe Perches 2013-02-07 1507 if (!txdr->buffer_info) ^1da177e4c3f41 drivers/net/e1000/e1000_main.c Linus Torvalds 2005-04-16 1508 return -ENOMEM; ^1da177e4c3f41 drivers/net/e1000/e1000_main.c Linus Torvalds 2005-04-16 1509 ^1da177e4c3f41 drivers/net/e1000/e1000_main.c Linus Torvalds 2005-04-16 1510 /* round up to nearest 4K */ ^1da177e4c3f41 drivers/net/e1000/e1000_main.c Linus Torvalds 2005-04-16 1511 ^1da177e4c3f41 drivers/net/e1000/e1000_main.c Linus Torvalds 2005-04-16 1512 txdr->size = txdr->count * sizeof(struct e1000_tx_desc); 9099cfb9170f35 drivers/net/e1000/e1000_main.c Milind Arun Choudhary 2007-04-27 1513 txdr->size = ALIGN(txdr->size, 4096); ^1da177e4c3f41 drivers/net/e1000/e1000_main.c Linus Torvalds 2005-04-16 1514 b16f53bef9be0a drivers/net/e1000/e1000_main.c Nick Nunley 2010-04-27 1515 txdr->desc = dma_alloc_coherent(&pdev->dev, txdr->size, &txdr->dma, b16f53bef9be0a drivers/net/e1000/e1000_main.c Nick Nunley 2010-04-27 1516 GFP_KERNEL); ^1da177e4c3f41 drivers/net/e1000/e1000_main.c Linus Torvalds 2005-04-16 1517 if (!txdr->desc) { ^1da177e4c3f41 drivers/net/e1000/e1000_main.c Linus Torvalds 2005-04-16 1518 setup_tx_desc_die: ^1da177e4c3f41 drivers/net/e1000/e1000_main.c Linus Torvalds 2005-04-16 1519 vfree(txdr->buffer_info); ^1da177e4c3f41 drivers/net/e1000/e1000_main.c Linus Torvalds 2005-04-16 1520 return -ENOMEM; ^1da177e4c3f41 drivers/net/e1000/e1000_main.c Linus Torvalds 2005-04-16 1521 } ^1da177e4c3f41 drivers/net/e1000/e1000_main.c Linus Torvalds 2005-04-16 1522 2648345fcbadfa drivers/net/e1000/e1000_main.c Malli Chilakala 2005-04-28 1523 /* Fix for errata 23, can't cross 64kB boundary */ ^1da177e4c3f41 drivers/net/e1000/e1000_main.c Linus Torvalds 2005-04-16 1524 if (!e1000_check_64k_bound(adapter, txdr->desc, txdr->size)) { ^1da177e4c3f41 drivers/net/e1000/e1000_main.c Linus Torvalds 2005-04-16 1525 void *olddesc = txdr->desc; ^1da177e4c3f41 drivers/net/e1000/e1000_main.c Linus Torvalds 2005-04-16 1526 dma_addr_t olddma = txdr->dma; feb8f47809fcc6 drivers/net/e1000/e1000_main.c Emil Tantilov 2010-07-26 1527 e_err(tx_err, "txdr align check failed: %u bytes at %p\n", 675ad47375c76a drivers/net/e1000/e1000_main.c Emil Tantilov 2010-04-27 1528 txdr->size, txdr->desc); 2648345fcbadfa drivers/net/e1000/e1000_main.c Malli Chilakala 2005-04-28 1529 /* Try again, without freeing the previous */ b16f53bef9be0a drivers/net/e1000/e1000_main.c Nick Nunley 2010-04-27 1530 txdr->desc = dma_alloc_coherent(&pdev->dev, txdr->size, b16f53bef9be0a drivers/net/e1000/e1000_main.c Nick Nunley 2010-04-27 1531 &txdr->dma, GFP_KERNEL); 2648345fcbadfa drivers/net/e1000/e1000_main.c Malli Chilakala 2005-04-28 1532 /* Failed allocation, critical failure */ 96838a40f02950 drivers/net/e1000/e1000_main.c Jesse Brandeburg 2006-01-18 1533 if (!txdr->desc) { b16f53bef9be0a drivers/net/e1000/e1000_main.c Nick Nunley 2010-04-27 1534 dma_free_coherent(&pdev->dev, txdr->size, olddesc, b16f53bef9be0a drivers/net/e1000/e1000_main.c Nick Nunley 2010-04-27 1535 olddma); ^1da177e4c3f41 drivers/net/e1000/e1000_main.c Linus Torvalds 2005-04-16 1536 goto setup_tx_desc_die; ^1da177e4c3f41 drivers/net/e1000/e1000_main.c Linus Torvalds 2005-04-16 1537 } ^1da177e4c3f41 drivers/net/e1000/e1000_main.c Linus Torvalds 2005-04-16 1538 ^1da177e4c3f41 drivers/net/e1000/e1000_main.c Linus Torvalds 2005-04-16 1539 if (!e1000_check_64k_bound(adapter, txdr->desc, txdr->size)) { ^1da177e4c3f41 drivers/net/e1000/e1000_main.c Linus Torvalds 2005-04-16 1540 /* give up */ b16f53bef9be0a drivers/net/e1000/e1000_main.c Nick Nunley 2010-04-27 1541 dma_free_coherent(&pdev->dev, txdr->size, txdr->desc, 2648345fcbadfa drivers/net/e1000/e1000_main.c Malli Chilakala 2005-04-28 1542 txdr->dma); b16f53bef9be0a drivers/net/e1000/e1000_main.c Nick Nunley 2010-04-27 1543 dma_free_coherent(&pdev->dev, txdr->size, olddesc, b16f53bef9be0a drivers/net/e1000/e1000_main.c Nick Nunley 2010-04-27 1544 olddma); feb8f47809fcc6 drivers/net/e1000/e1000_main.c Emil Tantilov 2010-07-26 1545 e_err(probe, "Unable to allocate aligned memory " 2648345fcbadfa drivers/net/e1000/e1000_main.c Malli Chilakala 2005-04-28 1546 "for the transmit descriptor ring\n"); ^1da177e4c3f41 drivers/net/e1000/e1000_main.c Linus Torvalds 2005-04-16 1547 vfree(txdr->buffer_info); ^1da177e4c3f41 drivers/net/e1000/e1000_main.c Linus Torvalds 2005-04-16 1548 return -ENOMEM; d66eba46397f54 drivers/net/ethernet/intel/e1000/e1000_main.c Lovekesh Solanki 2026-06-17 1549 } 2648345fcbadfa drivers/net/e1000/e1000_main.c Malli Chilakala 2005-04-28 1550 /* Free old allocation, new allocation was successful */ b16f53bef9be0a drivers/net/e1000/e1000_main.c Nick Nunley 2010-04-27 @1551 dma_free_coherent(&pdev->dev, txdr->size, olddesc, b16f53bef9be0a drivers/net/e1000/e1000_main.c Nick Nunley 2010-04-27 1552 olddma); ^1da177e4c3f41 drivers/net/e1000/e1000_main.c Linus Torvalds 2005-04-16 1553 } ^1da177e4c3f41 drivers/net/e1000/e1000_main.c Linus Torvalds 2005-04-16 1554 memset(txdr->desc, 0, txdr->size); ^1da177e4c3f41 drivers/net/e1000/e1000_main.c Linus Torvalds 2005-04-16 1555 ^1da177e4c3f41 drivers/net/e1000/e1000_main.c Linus Torvalds 2005-04-16 1556 txdr->next_to_use = 0; ^1da177e4c3f41 drivers/net/e1000/e1000_main.c Linus Torvalds 2005-04-16 1557 txdr->next_to_clean = 0; ^1da177e4c3f41 drivers/net/e1000/e1000_main.c Linus Torvalds 2005-04-16 1558 ^1da177e4c3f41 drivers/net/e1000/e1000_main.c Linus Torvalds 2005-04-16 1559 return 0; ^1da177e4c3f41 drivers/net/e1000/e1000_main.c Linus Torvalds 2005-04-16 1560 } ^1da177e4c3f41 drivers/net/e1000/e1000_main.c Linus Torvalds 2005-04-16 1561 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki