From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EBF83320CD1 for ; Thu, 18 Jun 2026 16:22:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=195.135.223.130 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781799771; cv=none; b=ufMZeM/fZTpMEVHaMIUaTBVhy9Ce9PP+gPaH6A7C7r/KHakTIMrpScodBt9P9siscs3bcZ4QP6nBTeoVyLVVT55rKBrz49IzDa/1Fv+lAk8aEx8CuM7EPx+q0HJyNxXtQg59TIWORr8iJfJAFCNMEpqfp6/4X70iVLBoWFYX33Y= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781799771; c=relaxed/simple; bh=I/o00LLTs3Tsrik3JCia5xY8kdhmAn0j6QYT8lc7Pss=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=UoiCQZkaMYrKp5EkdVUL41/aCSdK25VgEMAFP+tkntA64OfPpld3spXHxLRzt2rb7mJ8dEf+Ljih9DEcoBaGjM6aYP16hwnQtsJ8CTHIjwP4WIaGMp0POtrTFYcMgcZhbDjNdrYSef4plkJEV+KnLJnJMaDaFC8QBGRSvZda1TA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=suse.de; spf=pass smtp.mailfrom=suse.de; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b=UTvcbmsE; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b=uZHKcuA9; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b=UTvcbmsE; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b=uZHKcuA9; arc=none smtp.client-ip=195.135.223.130 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="UTvcbmsE"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="uZHKcuA9"; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="UTvcbmsE"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="uZHKcuA9" Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 012826D486; Thu, 18 Jun 2026 16:22:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1781799761; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=DyfplpXwdBjHdOrkA+ELzvFo2jvbdCKanPA27u1aGAc=; b=UTvcbmsEtQxsEhmCsn9jYr8YVeYurY4oZIHyMRDIUgF9Sw5Zmpj7dsSFQj0ndli8wkojku mgadhY1XJXMR+peuEf+HxJhMEtaYww/q/PoZnSfHP9k2h8Y1qIYRz2BV0jBZQARdUT/82I /Ruz1FFVG4qQ0rAesJ/jZvEnUG8nAio= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1781799761; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=DyfplpXwdBjHdOrkA+ELzvFo2jvbdCKanPA27u1aGAc=; b=uZHKcuA9FQptZ9QZF1KUbagtZHfVD1VvLGtfTGg70bPJ6kAMJzBGaPlODQtCe4EtxnvvQg GejT7NFd5Zjb7fCA== Authentication-Results: smtp-out1.suse.de; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=UTvcbmsE; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=uZHKcuA9 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1781799761; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=DyfplpXwdBjHdOrkA+ELzvFo2jvbdCKanPA27u1aGAc=; b=UTvcbmsEtQxsEhmCsn9jYr8YVeYurY4oZIHyMRDIUgF9Sw5Zmpj7dsSFQj0ndli8wkojku mgadhY1XJXMR+peuEf+HxJhMEtaYww/q/PoZnSfHP9k2h8Y1qIYRz2BV0jBZQARdUT/82I /Ruz1FFVG4qQ0rAesJ/jZvEnUG8nAio= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1781799761; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=DyfplpXwdBjHdOrkA+ELzvFo2jvbdCKanPA27u1aGAc=; b=uZHKcuA9FQptZ9QZF1KUbagtZHfVD1VvLGtfTGg70bPJ6kAMJzBGaPlODQtCe4EtxnvvQg GejT7NFd5Zjb7fCA== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 209EF779A8; Thu, 18 Jun 2026 16:22:40 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id 4NMFBVAbNGqCDgAAD6G6ig (envelope-from ); Thu, 18 Jun 2026 16:22:40 +0000 From: Fernando Fernandez Mancera To: netdev@vger.kernel.org Cc: nicolas.dichtel@6wind.com, shemminger@vyatta.com, dforster@brocade.com, gospo@cumulusnetworks.com, ddutt@cumulusnetworks.com, brian.haley@hp.com, horms@kernel.org, pabeni@redhat.com, kuba@kernel.org, edumazet@google.com, davem@davemloft.net, idosch@nvidia.com, dsahern@kernel.org, Fernando Fernandez Mancera Subject: [PATCH net 1/6] ipv6: fix error handling in disable_ipv6 sysctl Date: Thu, 18 Jun 2026 18:22:20 +0200 Message-ID: <20260618162225.4588-2-fmancera@suse.de> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20260618162225.4588-1-fmancera@suse.de> References: <20260618162225.4588-1-fmancera@suse.de> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspamd-Action: no action X-Rspamd-Queue-Id: 012826D486 X-Spam-Flag: NO X-Spam-Score: -3.01 X-Spam-Level: X-Spamd-Result: default: False [-3.01 / 50.00]; BAYES_HAM(-3.00)[100.00%]; MID_CONTAINS_FROM(1.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000]; R_MISSING_CHARSET(0.50)[]; R_DKIM_ALLOW(-0.20)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; MX_GOOD(-0.01)[]; RCVD_COUNT_TWO(0.00)[2]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; FUZZY_RATELIMITED(0.00)[rspamd.com]; ARC_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; RBL_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:104:10:150:64:97:from]; RCPT_COUNT_TWELVE(0.00)[15]; URIBL_BLOCKED(0.00)[suse.de:dkim,suse.de:email,suse.de:mid,imap1.dmz-prg2.suse.org:rdns,imap1.dmz-prg2.suse.org:helo]; TO_MATCH_ENVRCPT_ALL(0.00)[]; FROM_HAS_DN(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; RECEIVED_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:106:10:150:64:167:received]; FROM_EQ_ENVFROM(0.00)[]; R_RATELIMIT(0.00)[to_ip_from(RLb3xxm68jmrjpif7i5fm8f49r)]; RCVD_TLS_ALL(0.00)[]; DKIM_TRACE(0.00)[suse.de:+]; TO_DN_SOME(0.00)[]; DBL_BLOCKED_OPENRESOLVER(0.00)[imap1.dmz-prg2.suse.org:rdns,imap1.dmz-prg2.suse.org:helo,suse.de:dkim,suse.de:email,suse.de:mid] X-Rspamd-Server: rspamd1.dmz-prg2.suse.org When writing to the disable_ipv6 sysctl, if proc_dointvec() fails to parse the input, it returns a negative error code. The current implementation is overwriting that error for write operations. This results in a silent failure, it returns a successful write although the configuration was not modified at all. When modifying the "all" variant it can also modify the configuration of existing interfaces to the wrong value. Fix this by checking the return value of proc_dointvec() and returning early on failure. Fixes: 56d417b12e57 ("IPv6: Add 'autoconf' and 'disable_ipv6' module parameters") Signed-off-by: Fernando Fernandez Mancera --- net/ipv6/addrconf.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/net/ipv6/addrconf.c b/net/ipv6/addrconf.c index 1f21ccb55caa..c901b444a995 100644 --- a/net/ipv6/addrconf.c +++ b/net/ipv6/addrconf.c @@ -6467,6 +6467,8 @@ static int addrconf_sysctl_disable(const struct ctl_table *ctl, int write, lctl.data = &val; ret = proc_dointvec(&lctl, write, buffer, lenp, ppos); + if (ret) + return ret; if (write) ret = addrconf_disable_ipv6(ctl, valp, val); -- 2.54.0