From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 911CA2F7EE2 for ; Thu, 18 Jun 2026 16:22:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=195.135.223.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781799772; cv=none; b=Q9sEvblXf54z47QTEpXPsL9PZ9RA+IfzKIFObT/6kZJWoCfKcn7DkXHJl4BjCMEzRG5D3f4IhCBDEP7ynGo9IBYH/GzFxbfdgKk3xsnIDrdS8sM3mZvge6Rp7n/uOdgd1kGWvgu7dhSd+VRGYuuEz/cx9YEyPytWa2bXStc7RTs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781799772; c=relaxed/simple; bh=E9FmkVrlQ8SVz75fEHQsPOJDf0O138Ei5crdzcNZYYk=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=pppqYwMVq16APMuEyKifS1Nrc9MSmMOVaqV5unioSirLhz4zQWfiofYmIDzSHTFtryhrj2YF18T0ia8iFUH8rhvwGYtJvqOx8IZ+8Zya9zYQuE/+B0GXOCMtyPxlmewoPzUZb2nX7lBM0Ts5Fv6222nC8rN//jZBpvDgSPPlpmA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=suse.de; spf=pass smtp.mailfrom=suse.de; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b=uR1M4UI9; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b=N5Su95a0; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b=uR1M4UI9; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b=N5Su95a0; arc=none smtp.client-ip=195.135.223.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="uR1M4UI9"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="N5Su95a0"; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="uR1M4UI9"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="N5Su95a0" Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 94C8175FE9; Thu, 18 Jun 2026 16:22:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1781799767; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=RgoTog6NBw1KjlYBrCypyowsJeN4J+N7aPh5DtBfD3I=; b=uR1M4UI9psbuC8hSDuO9i6ikeTNgzJoRt5JZxzriRvXF8zVpEJZuiEUlAPnXf4uca5g0Rg m8rztpitclOCnUvYwAuR8ppguBnyQgBGSsRx4l76c5RXTrE9LnGewg1Digk3kZLYSTBBXX 0N2VeStlOoIshrKH39s7k3AHxz/BarE= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1781799767; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=RgoTog6NBw1KjlYBrCypyowsJeN4J+N7aPh5DtBfD3I=; b=N5Su95a0iId8pyWqFZFwD/kXnJD25MJKIuRlR7qN/hWAGaukYCRAEsSMrGFh+tGrmJcY5c 4hqMz8d6O549+gCg== Authentication-Results: smtp-out2.suse.de; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=uR1M4UI9; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=N5Su95a0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1781799767; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=RgoTog6NBw1KjlYBrCypyowsJeN4J+N7aPh5DtBfD3I=; b=uR1M4UI9psbuC8hSDuO9i6ikeTNgzJoRt5JZxzriRvXF8zVpEJZuiEUlAPnXf4uca5g0Rg m8rztpitclOCnUvYwAuR8ppguBnyQgBGSsRx4l76c5RXTrE9LnGewg1Digk3kZLYSTBBXX 0N2VeStlOoIshrKH39s7k3AHxz/BarE= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1781799767; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=RgoTog6NBw1KjlYBrCypyowsJeN4J+N7aPh5DtBfD3I=; b=N5Su95a0iId8pyWqFZFwD/kXnJD25MJKIuRlR7qN/hWAGaukYCRAEsSMrGFh+tGrmJcY5c 4hqMz8d6O549+gCg== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id B5AD1779AB; Thu, 18 Jun 2026 16:22:46 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id oAtYKVYbNGqCDgAAD6G6ig (envelope-from ); Thu, 18 Jun 2026 16:22:46 +0000 From: Fernando Fernandez Mancera To: netdev@vger.kernel.org Cc: nicolas.dichtel@6wind.com, shemminger@vyatta.com, dforster@brocade.com, gospo@cumulusnetworks.com, ddutt@cumulusnetworks.com, brian.haley@hp.com, horms@kernel.org, pabeni@redhat.com, kuba@kernel.org, edumazet@google.com, davem@davemloft.net, idosch@nvidia.com, dsahern@kernel.org, Fernando Fernandez Mancera Subject: [PATCH net 4/6] ipv6: fix error handling in disable_policy sysctl Date: Thu, 18 Jun 2026 18:22:23 +0200 Message-ID: <20260618162225.4588-5-fmancera@suse.de> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20260618162225.4588-1-fmancera@suse.de> References: <20260618162225.4588-1-fmancera@suse.de> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Flag: NO X-Rspamd-Action: no action X-Spam-Level: X-Spamd-Result: default: False [-3.01 / 50.00]; BAYES_HAM(-3.00)[100.00%]; MID_CONTAINS_FROM(1.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000]; R_MISSING_CHARSET(0.50)[]; R_DKIM_ALLOW(-0.20)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; MX_GOOD(-0.01)[]; FUZZY_RATELIMITED(0.00)[rspamd.com]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; RBL_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:104:10:150:64:97:from]; SPAMHAUS_XBL(0.00)[2a07:de40:b281:104:10:150:64:97:from]; MIME_TRACE(0.00)[0:+]; ARC_NA(0.00)[]; RCPT_COUNT_TWELVE(0.00)[15]; URIBL_BLOCKED(0.00)[suse.de:email,suse.de:dkim,suse.de:mid,imap1.dmz-prg2.suse.org:helo,imap1.dmz-prg2.suse.org:rdns]; RCVD_COUNT_TWO(0.00)[2]; TO_MATCH_ENVRCPT_ALL(0.00)[]; R_RATELIMIT(0.00)[to_ip_from(RLb3xxm68jmrjpif7i5fm8f49r)]; RCVD_VIA_SMTP_AUTH(0.00)[]; RECEIVED_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:106:10:150:64:167:received]; FROM_EQ_ENVFROM(0.00)[]; DKIM_TRACE(0.00)[suse.de:+]; FROM_HAS_DN(0.00)[]; RCVD_TLS_ALL(0.00)[]; TO_DN_SOME(0.00)[]; DBL_BLOCKED_OPENRESOLVER(0.00)[imap1.dmz-prg2.suse.org:helo,imap1.dmz-prg2.suse.org:rdns,suse.de:email,suse.de:dkim,suse.de:mid] X-Rspamd-Server: rspamd2.dmz-prg2.suse.org X-Rspamd-Queue-Id: 94C8175FE9 X-Spam-Score: -3.01 When writing to the disable_policy sysctl, if proc_dointvec() fails to parse the input, it returns a negative error code. The current implementation is resetting the position argument even if an error occurred during proc_dointvec() and not only during sysctl restart. Fix this by checking the return value of proc_dointvec() and returning early on failure. Fixes: df789fe75206 ("ipv6: Provide ipv6 version of "disable_policy" sysctl") Signed-off-by: Fernando Fernandez Mancera --- net/ipv6/addrconf.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/net/ipv6/addrconf.c b/net/ipv6/addrconf.c index 0b128b6cff60..8ff015975e27 100644 --- a/net/ipv6/addrconf.c +++ b/net/ipv6/addrconf.c @@ -6769,6 +6769,8 @@ static int addrconf_sysctl_disable_policy(const struct ctl_table *ctl, int write lctl = *ctl; lctl.data = &val; ret = proc_dointvec(&lctl, write, buffer, lenp, ppos); + if (ret) + return ret; if (write && (*valp != val)) ret = addrconf_disable_policy(ctl, valp, val); -- 2.54.0