From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 04F30280A56 for ; Thu, 18 Jun 2026 16:23:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=195.135.223.130 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781799795; cv=none; b=uU0zhGxz7vsFlFhnDlkudecr05TlCJpno1fCivbN6bsjgXxa0O2clm1FUcjSk8cu5rE0ytvP6EKquuUQQKCGNz9Otuqq+8aJY9eNJZoDizg/Zqc7q5J2Gq5moaPE+Cgi/oqQ/tZWu1293hAZOY9Pe3r5d9xFRLL/7fEFWJ1jAds= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781799795; c=relaxed/simple; bh=JPGeb1FJCs44lbD7ccbkaYJ/2mJM+1sDy3CPh7o5/9s=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=C9h4arAhXhySDXs4CQ+yKDZhTru/UOncxaluqvX7xNlsR0ZfeB2qN3a4Ol3EMZ1E3IXkCKK38Mm+WbMt3u1FuZMR1/WIDo0yCBhINc4LNxIKKCdB6jBgfHSsuss3IAqWpZeosBP/KGS+dVsWo7z7aNpil1cjmbfjEBx/OOTK9kg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=suse.de; spf=pass smtp.mailfrom=suse.de; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b=VViNd8PX; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b=j1Q7Xd1K; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b=VViNd8PX; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b=j1Q7Xd1K; arc=none smtp.client-ip=195.135.223.130 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="VViNd8PX"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="j1Q7Xd1K"; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="VViNd8PX"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="j1Q7Xd1K" Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id BA1F76D490; Thu, 18 Jun 2026 16:22:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1781799770; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=hQKtNx9gkQdqh3XxzOkTF6N8KSOnu1L+mOfISfK7d+c=; b=VViNd8PXyRn1APuxj/fPGujAx1e6IX5mS6DNDwkKBt08zN3kF6+lf2kKYmswPqFOLd2U/a 81olWgM2xykI/2E2Tkr2BA3CTSVLW07v2j9GVWSkiXdpcuXzHnIjwPP4FcPVOKG3ofvb2b wVNn9Ru91719xnVuS5re6XSqGwuMPH0= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1781799770; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=hQKtNx9gkQdqh3XxzOkTF6N8KSOnu1L+mOfISfK7d+c=; b=j1Q7Xd1KlsBzWCl+GuPPL050KnAA0kyGoiG43kXwM2h5zhfOyeVsoHIi7JwgjJ94UIhGdG QvPPXuvBPRRDNSBg== Authentication-Results: smtp-out1.suse.de; none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1781799770; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=hQKtNx9gkQdqh3XxzOkTF6N8KSOnu1L+mOfISfK7d+c=; b=VViNd8PXyRn1APuxj/fPGujAx1e6IX5mS6DNDwkKBt08zN3kF6+lf2kKYmswPqFOLd2U/a 81olWgM2xykI/2E2Tkr2BA3CTSVLW07v2j9GVWSkiXdpcuXzHnIjwPP4FcPVOKG3ofvb2b wVNn9Ru91719xnVuS5re6XSqGwuMPH0= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1781799770; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=hQKtNx9gkQdqh3XxzOkTF6N8KSOnu1L+mOfISfK7d+c=; b=j1Q7Xd1KlsBzWCl+GuPPL050KnAA0kyGoiG43kXwM2h5zhfOyeVsoHIi7JwgjJ94UIhGdG QvPPXuvBPRRDNSBg== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id DA831779A8; Thu, 18 Jun 2026 16:22:49 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id cCJeMlkbNGqCDgAAD6G6ig (envelope-from ); Thu, 18 Jun 2026 16:22:49 +0000 From: Fernando Fernandez Mancera To: netdev@vger.kernel.org Cc: nicolas.dichtel@6wind.com, shemminger@vyatta.com, dforster@brocade.com, gospo@cumulusnetworks.com, ddutt@cumulusnetworks.com, brian.haley@hp.com, horms@kernel.org, pabeni@redhat.com, kuba@kernel.org, edumazet@google.com, davem@davemloft.net, idosch@nvidia.com, dsahern@kernel.org, Fernando Fernandez Mancera Subject: [PATCH net 6/6] ipv6: fix missing notification for ignore_routes_with_linkdown Date: Thu, 18 Jun 2026 18:22:25 +0200 Message-ID: <20260618162225.4588-7-fmancera@suse.de> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20260618162225.4588-1-fmancera@suse.de> References: <20260618162225.4588-1-fmancera@suse.de> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Flag: NO X-Spamd-Result: default: False [-2.80 / 50.00]; BAYES_HAM(-3.00)[99.99%]; MID_CONTAINS_FROM(1.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000]; R_MISSING_CHARSET(0.50)[]; NEURAL_HAM_SHORT(-0.20)[-0.993]; MIME_GOOD(-0.10)[text/plain]; TO_MATCH_ENVRCPT_ALL(0.00)[]; FROM_HAS_DN(0.00)[]; ARC_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; TO_DN_SOME(0.00)[]; RCPT_COUNT_TWELVE(0.00)[15]; DBL_BLOCKED_OPENRESOLVER(0.00)[suse.de:email,suse.de:mid,imap1.dmz-prg2.suse.org:helo]; RCVD_VIA_SMTP_AUTH(0.00)[]; FROM_EQ_ENVFROM(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; FUZZY_RATELIMITED(0.00)[rspamd.com]; URIBL_BLOCKED(0.00)[suse.de:email,suse.de:mid,imap1.dmz-prg2.suse.org:helo]; R_RATELIMIT(0.00)[to_ip_from(RLwhz7wtk6en1e6cs856tq4oxd)]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; RCVD_TLS_ALL(0.00)[] X-Spam-Level: X-Spam-Score: -2.80 When changing the ignore_routes_with_linkdown sysctl for a specific interface, the RTM_NEWNETCONF netlink notification was not being emitted to userspace. Fix this by emitting the notification when needed. In addition, fix bogus return value for successful "all" and specific interface write operation leading to a wrong reset of the position pointer. Fixes: 35103d11173b ("net: ipv6 sysctl option to ignore routes when nexthop link is down") Signed-off-by: Fernando Fernandez Mancera --- net/ipv6/addrconf.c | 18 ++++++++++++------ 1 file changed, 12 insertions(+), 6 deletions(-) diff --git a/net/ipv6/addrconf.c b/net/ipv6/addrconf.c index 1cfb223476bd..2d81569b692b 100644 --- a/net/ipv6/addrconf.c +++ b/net/ipv6/addrconf.c @@ -955,11 +955,7 @@ static int addrconf_fixup_linkdown(const struct ctl_table *table, int *p, int ne NETCONFA_IGNORE_ROUTES_WITH_LINKDOWN, NETCONFA_IFINDEX_DEFAULT, net->ipv6.devconf_dflt); - rtnl_net_unlock(net); - return 0; - } - - if (p == &net->ipv6.devconf_all->ignore_routes_with_linkdown) { + } else if (p == &net->ipv6.devconf_all->ignore_routes_with_linkdown) { WRITE_ONCE(net->ipv6.devconf_dflt->ignore_routes_with_linkdown, newf); addrconf_linkdown_change(net, newf); if ((!newf) ^ (!old)) @@ -968,11 +964,21 @@ static int addrconf_fixup_linkdown(const struct ctl_table *table, int *p, int ne NETCONFA_IGNORE_ROUTES_WITH_LINKDOWN, NETCONFA_IFINDEX_ALL, net->ipv6.devconf_all); + } else { + if (!newf ^ !old) { + struct inet6_dev *idev = table->extra1; + + inet6_netconf_notify_devconf(net, + RTM_NEWNETCONF, + NETCONFA_IGNORE_ROUTES_WITH_LINKDOWN, + idev->dev->ifindex, + &idev->cnf); + } } rtnl_net_unlock(net); - return 1; + return 0; } #endif -- 2.54.0