From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B40C0348C65 for ; Sat, 20 Jun 2026 16:19:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=195.135.223.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781972367; cv=none; b=Tvvnm9loglN56PZWh5Zdpl5+j6E0SStaynylNF8itE1rvhhU04CzGKMf0TgHHThSWtI47slVpHEzeCzNcpMI/WK7rEPOajuJA/5Bkc1Y4q02and4B58K4ipNRhxUNOOFr66Ag19wTuNxvimBk4OhMiSiXxGpodWcAUOkqIN3DBY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781972367; c=relaxed/simple; bh=s1rSQKl3XCF7UWekLfvK7mfsuKImlkpuLAy7sEURwr0=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=fTQ4eUkvkVFEOGUMWybQA52XELM6e8fNUhs+KTjM9yk/QV1GBRwoi83hXSm75+R3r3rHGxBDf2ZN3trhNzuofUZs3LUDHOd89V0vdXprthbW+EzBNXqyhjWQjLxsbFqq+C1iSn1iuqprKpDCgipAp7Xi+Q67lGFpeXGYzxC7C08= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=suse.de; spf=pass smtp.mailfrom=suse.de; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b=Qkgbz+KT; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b=mLg9pD84; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b=Qkgbz+KT; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b=mLg9pD84; arc=none smtp.client-ip=195.135.223.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="Qkgbz+KT"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="mLg9pD84"; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="Qkgbz+KT"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="mLg9pD84" Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 5A02275837; Sat, 20 Jun 2026 16:19:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1781972350; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=zKF65wqg9LRmMrT7MbpDxfYKLhxPGXqWsNi5FBtSY84=; b=Qkgbz+KTmQRG+2tmz/jZHfB0fYmPOlXtVAXCSXnZ0qerTNDyC0JVEYuYcpM4jJtWK2rwqQ j+c8IFerQ6QzibGvYVrlPmh6rR2hxSOzhGRLDdPo3VhIHQtk9pv/Q1k/5zZLDXIHMHm6v9 GO4NUtLbT2xzAjse+VeauRkkSiY0Yt8= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1781972350; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=zKF65wqg9LRmMrT7MbpDxfYKLhxPGXqWsNi5FBtSY84=; b=mLg9pD84Jew8AJJ7b1QJHM1UKa3OCXk/sSDTrdjnM6gFe++0riS4UZJWm1jsa/7gnPbKkB 11ui+ycdd6lFh1Ag== Authentication-Results: smtp-out2.suse.de; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=Qkgbz+KT; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=mLg9pD84 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1781972350; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=zKF65wqg9LRmMrT7MbpDxfYKLhxPGXqWsNi5FBtSY84=; b=Qkgbz+KTmQRG+2tmz/jZHfB0fYmPOlXtVAXCSXnZ0qerTNDyC0JVEYuYcpM4jJtWK2rwqQ j+c8IFerQ6QzibGvYVrlPmh6rR2hxSOzhGRLDdPo3VhIHQtk9pv/Q1k/5zZLDXIHMHm6v9 GO4NUtLbT2xzAjse+VeauRkkSiY0Yt8= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1781972350; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=zKF65wqg9LRmMrT7MbpDxfYKLhxPGXqWsNi5FBtSY84=; b=mLg9pD84Jew8AJJ7b1QJHM1UKa3OCXk/sSDTrdjnM6gFe++0riS4UZJWm1jsa/7gnPbKkB 11ui+ycdd6lFh1Ag== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 98742779A8; Sat, 20 Jun 2026 16:19:09 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id QHkfIn29NmogRQAAD6G6ig (envelope-from ); Sat, 20 Jun 2026 16:19:09 +0000 From: Fernando Fernandez Mancera To: netdev@vger.kernel.org Cc: nicolas.dichtel@6wind.com, stephen@networkplumber.org, brian.haley@hp.com, horms@kernel.org, pabeni@redhat.com, kuba@kernel.org, edumazet@google.com, davem@davemloft.net, idosch@nvidia.com, dsahern@kernel.org, Fernando Fernandez Mancera Subject: [PATCH net v2 3/7] ipv6: fix error handling in forwarding sysctl Date: Sat, 20 Jun 2026 18:18:46 +0200 Message-ID: <20260620161850.7114-4-fmancera@suse.de> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20260620161850.7114-1-fmancera@suse.de> References: <20260620161850.7114-1-fmancera@suse.de> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Flag: NO X-Rspamd-Action: no action X-Spam-Level: X-Spamd-Result: default: False [-3.01 / 50.00]; BAYES_HAM(-3.00)[100.00%]; MID_CONTAINS_FROM(1.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000]; R_MISSING_CHARSET(0.50)[]; NEURAL_HAM_SHORT(-0.20)[-1.000]; R_DKIM_ALLOW(-0.20)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; MIME_GOOD(-0.10)[text/plain]; MX_GOOD(-0.01)[]; DBL_BLOCKED_OPENRESOLVER(0.00)[suse.de:email,suse.de:dkim,suse.de:mid]; FROM_HAS_DN(0.00)[]; ARC_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; TO_DN_SOME(0.00)[]; RCPT_COUNT_TWELVE(0.00)[12]; TO_MATCH_ENVRCPT_ALL(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; FROM_EQ_ENVFROM(0.00)[]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; FUZZY_RATELIMITED(0.00)[rspamd.com]; RCVD_COUNT_TWO(0.00)[2]; RCVD_TLS_ALL(0.00)[]; R_RATELIMIT(0.00)[to_ip_from(RLb3xxm68jmrjpif7i5fm8f49r)]; DKIM_TRACE(0.00)[suse.de:+] X-Rspamd-Server: rspamd2.dmz-prg2.suse.org X-Rspamd-Queue-Id: 5A02275837 X-Spam-Score: -3.01 When writing to the forwarding sysctl, if proc_dointvec() fails to parse the input, it returns a negative error code. The current implementation is overwriting that error for write operations. This results in a silent failure, it returns a successful write although the configuration was not modified at all. When modifying the "all" variant it can also modify the configuration of existing interfaces to the wrong value. Fix this by checking the return value of proc_dointvec() and returning early on failure. In addition, adjust return code of addrconf_fixup_forwarding() for successful operation. Fixes: b325fddb7f86 ("ipv6: Fix sysctl unregistration deadlock") Reviewed-by: Nicolas Dichtel Signed-off-by: Fernando Fernandez Mancera --- net/ipv6/addrconf.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/net/ipv6/addrconf.c b/net/ipv6/addrconf.c index 70058d971205..d23a89b07eed 100644 --- a/net/ipv6/addrconf.c +++ b/net/ipv6/addrconf.c @@ -913,7 +913,7 @@ static int addrconf_fixup_forwarding(const struct ctl_table *table, int *p, int if (newf) rt6_purge_dflt_routers(net); - return 1; + return 0; } static void addrconf_linkdown_change(struct net *net, __s32 newf) @@ -6370,6 +6370,8 @@ static int addrconf_sysctl_forward(const struct ctl_table *ctl, int write, lctl.data = &val; ret = proc_dointvec(&lctl, write, buffer, lenp, ppos); + if (ret) + return ret; if (write) ret = addrconf_fixup_forwarding(ctl, valp, val); -- 2.54.0