From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by smtp.subspace.kernel.org (Postfix) with ESMTPS id DF4B51DDC37;
	Sun, 21 Jun 2026 05:39:14 +0000 (UTC)
Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18
ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;
	t=1782020355; cv=none; b=bDw6BOIFVNqFXbufJYIG/pQ/duzr684ozyuGNGsPDDSEf0cEsoqLNYYht5uyhSZ4oXq4/WtfBIkgPQAeJ/hYnN6wKh6SYES7ZTxXE8pYRZ4juqT7bZLS3NIOvdWYNc0NyGhTYS7Y3LPH+Mbct8DMgm7c1LLJfMj9H4lT4xiRzBc=
ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org;
	s=arc-20240116; t=1782020355; c=relaxed/simple;
	bh=nwfuR7vyMinBAPE+rYZyPFUgqHeAIK7T9UKqDm0zf3U=;
	h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version:
	 Content-Type:Content-Disposition:In-Reply-To; b=qDBQfhfgPv6qNRwgnMRHkFR/IU0212e0qkzF5bHW2fz5wyl6OoLSz3bhqUM9K/Y9zx7VTyWPmfvOZzyiCOFY36DXOSAalNeX/nxTuiPDLf/NnScbqflZHsLTYWz0IrgqQswsokYXEXW2ylmBXV9uXqQR1Ua3HxNCRi8j6LtsmuE=
ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=1WX/wGQO; arc=none smtp.client-ip=100.103.45.18
Authentication-Results: smtp.subspace.kernel.org;
	dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="1WX/wGQO"
Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2372F1F000E9;
	Sun, 21 Jun 2026 05:39:14 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org;
	s=korg; t=1782020354;
	bh=v6wADMUi0lpR3SGAx412F1px7EYsSiwMbiEhOqY2PYE=;
	h=Date:From:To:Cc:Subject:References:In-Reply-To;
	b=1WX/wGQOOixMWA+NDiylaUwIpM8be2nFiwb8jHguBmUowX/893TfqE/fQLX4RJyoR
	 A9c4T+oJL3M6he0b7vcbBnXAhMZtXqLpLKJJ8QzEUXo8N1dLbUGjcaz84cwlrXGPvQ
	 x4CoetNJVeKswuEeq6DiT4LQTikOcMNTqnjsKECU=
Date: Sun, 21 Jun 2026 07:39:24 +0200
From: Greg KH <gregkh@linuxfoundation.org>
To: XIAO WU <xiaowu.417@qq.com>
Cc: Li Xiasong <lixiasong1@huawei.com>, Jon Maloy <jmaloy@redhat.com>,
	stable@vger.kernel.org, "David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
	Simon Horman <horms@kernel.org>, Ying Xue <ying.xue@windriver.com>,
	Tuong Lien <tuong.t.lien@dektech.com.au>, netdev@vger.kernel.org,
	tipc-discussion@lists.sourceforge.net, yuehaibing@huawei.com,
	zhangchangzhong@huawei.com, weiyongjun1@huawei.com
Subject: Re: [PATCH net] tipc: restrict socket queue dumps in enqueue
 tracepoints
Message-ID: <2026062113-reflex-enforcer-441e@gregkh>
References: <20260611135647.3666727-1-lixiasong1@huawei.com>
 <tencent_EC8B2032C1F9358EA3B49645F0F2277B210A@qq.com>
Precedence: bulk
X-Mailing-List: netdev@vger.kernel.org
List-Id: <netdev.vger.kernel.org>
List-Subscribe: <mailto:netdev+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:netdev+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <tencent_EC8B2032C1F9358EA3B49645F0F2277B210A@qq.com>

On Sun, Jun 21, 2026 at 09:21:15AM +0800, XIAO WU wrote:
> Hi Li Xiasong,
> 
> I see this patch was merged into net.git as commit acd7df8d9554 — thanks
> for the fix.  However, a Sashiko AI code review [1] flagged that
> `tipc_poll()` in the same file has the identical pre-existing issue: it
> calls `trace_tipc_sk_poll()` with `TIPC_DUMP_ALL`, which triggers a dump
> of all socket queues without holding the socket owner lock.  The merged
> fix addressed `tipc_sk_enqueue()` but left `tipc_poll()` unchanged.
> 
> I was able to reproduce the remaining use-after-free in QEMU with KASAN
> by racing `tipc_poll()` against `tipc_recvmsg()` on the same socket.

Great, can you send a fix for this?

thanks,

greg k-h