From: Petr Oros <poros@redhat.com>
To: netdev@vger.kernel.org
Cc: Petr Oros <poros@redhat.com>
Subject: [PATCH iwl-net v2 0/2] ice: fix DFLT Rx rule handling for promisc and switchdev
Date: Mon, 22 Jun 2026 13:34:26 +0200 [thread overview]
Message-ID: <20260622113428.2565255-1-poros@redhat.com> (raw)
Two fixes for the uplink default VSI Rx rule (DFLT) on E810 when the
netdev is in IFF_PROMISC.
Patch 1 drops the redundant per-VLAN promisc expansion that exhausts
the FLU pool on a wide VLAN trunk across several PFs.
Patch 2 keeps the DFLT Rx rule across a switchdev teardown instead of
clobbering the promisc state the operator asked for.
Changes since v1:
- Patch 2: reworked to avoid the service task entirely. v1 scheduled a
filter sync in ice_eswitch_disable_switchdev(); that work could run
after ice_remove() freed the uplink VSI (use-after-free) and was not
guaranteed to fire if ice_set_rx_mode() never ran again. v2 keeps or
drops the DFLT Rx rule synchronously in ice_eswitch_release_env() by
testing the live netdev->flags IFF_PROMISC, the same value
ice_cfg_vlan_pruning() already keys on. No service task is scheduled
and no symbol is exported. Dropped Aleksandr's Reviewed-by since the
fix mechanism changed.
- Patch 1: no functional changes, collected Aleksandr's Reviewed-by.
Link to v1:
https://lore.kernel.org/all/cover.1781786935.git.poros@redhat.com/
Petr Oros (2):
ice: skip per-VLAN promisc rules when default VSI Rx rule is set
ice: preserve uplink DFLT Rx rule on switchdev release
drivers/net/ethernet/intel/ice/ice_eswitch.c | 18 +++-
drivers/net/ethernet/intel/ice/ice_main.c | 90 +++++++++++++++-----
2 files changed, 84 insertions(+), 24 deletions(-)
--
2.53.0
next reply other threads:[~2026-06-22 11:34 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-22 11:34 Petr Oros [this message]
2026-06-22 11:34 ` [PATCH iwl-net v2 1/2] ice: skip per-VLAN promisc rules when default VSI Rx rule is set Petr Oros
2026-06-23 16:25 ` Simon Horman
2026-06-22 11:34 ` [PATCH iwl-net v2 2/2] ice: preserve uplink DFLT Rx rule on switchdev release Petr Oros
2026-06-23 16:25 ` Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260622113428.2565255-1-poros@redhat.com \
--to=poros@redhat.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox