From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BF5F057C9F for ; Mon, 22 Jun 2026 22:15:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782166547; cv=none; b=I4oUxnXEilMeEvSsWxDQ1qnbg+QMPSX9SCnrwsmh0gak3Y2P6ldaTCvoABqrWEuXhg4iY3wp5wpBy5M/l4xP32b7Rw3vrfsTAMAgbs+wAUwbkGhQAX/OKCB7Gd1pgd9u+nR8mpEug7qTg0QVgSyhK7pvnmeqArZyHywUmfpcByQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782166547; c=relaxed/simple; bh=G1sdTy4mgqMiYtrPaIQhflyahpgNRB07qllNs1lUX5I=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=LmhzbjaOjKa1MEau2Lvv3VxRjJ2+TUBz9cowxaSKfOHG2S9JAB2KQgnOYAvZIMx/NUXyYlNi9uk3/6DaZ0EtuogChW36ug95v955LFPOzcu0w5kPOnIPhHe8w4mVJkNeZGxXMorM68I2AQY8oSWM9LsfIxruKODu18NgMDXTqsk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=kJhqYeJ8; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="kJhqYeJ8" Received: by smtp.kernel.org (Postfix) with ESMTPSA id DE4BC1F000E9; Mon, 22 Jun 2026 22:15:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1782166546; bh=n6Cj3B0lmGIqhGNYby2Kc0qKU/yseO+5CJWPhGVtjvA=; h=Date:From:To:Cc:Subject:In-Reply-To:References; b=kJhqYeJ8blHG/Kdbl49vE5z9xbOqAJgcEYeT7GB2loANFsrT3LyrfLhzXQkFjdzwz oh5ESirqqJqPHviHFFg6GzkAVHO7p4yjzz8+W6/56bop6jyc4vdTWAfvgw01lKShMX 83KKkjGziT0BP4/a5JDs/wRKay6d2n6NGQ2GHSf3yMSIsB+hSIzKTphP+UEyAAcIub yvhloR2eo2AZAncfC914kRwfqlevxPuyqZo+BF/+tCuSTPaREo3L0ujFYAofVeMoG4 Qm8Gq6cu4LTHHSR5OfFWg39oxpRBBdpc+plLAqVljmQZdqsujCVyr8HZcrrq1Eun2Q MP4+I0KLzPnkw== Date: Mon, 22 Jun 2026 15:15:45 -0700 From: Jakub Kicinski To: Eric Dumazet Cc: "David S . Miller" , Paolo Abeni , Simon Horman , Dmitry Safonov <0x7f454c46@gmail.com>, Neal Cardwell , Kuniyuki Iwashima , netdev@vger.kernel.org, eric.dumazet@gmail.com Subject: Re: [PATCH net 0/2] tcp: make TCP-AO lookups more predictable Message-ID: <20260622151545.5e1688dc@kernel.org> In-Reply-To: <20260622185248.1717846-1-edumazet@google.com> References: <20260622185248.1717846-1-edumazet@google.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Mon, 22 Jun 2026 18:52:46 +0000 Eric Dumazet wrote: > This series fixes a TCP-AO key lookup precedence bug. > > TCP-AO stores MKTs in an unsorted list and returns the first match. This > allows newer, less-specific keys (wildcard VRF or shorter prefixes) to > shadow older, more-specific keys if inserted later. > > Fix this by implementing sorted insertion in tcp_ao_link_mkt() based on > key specificity (VRF binding, then prefix length). This keeps the RX > lookup path fast while ensuring correctness. > > The second patch adds a selftest to verify this behavior. Unhappiness: https://netdev-ctrl.bots.linux.dev/logs/vmksft/net-extra/results/702701/29-key-management-ipv4/stdout