From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2F822329E5D; Wed, 24 Jun 2026 18:20:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782325231; cv=none; b=orJ5ReRWBcVFDCWz7OlC56LfaUNfSOQCaL31X/Bk4ZophOjzHIsFmjiE0H0wE9QV2/o20erQ3dtTUqKQ8o0cHWDQTN272JZwDgTBGwuwIf+RCnML0CIZtQFz3LFqrejfWOIemzbOZp8uYt8yEiKkWqg5ZrY2/eqxmSeLUflLBXg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782325231; c=relaxed/simple; bh=o2h6ixJ8nw9b38Td39gTF6iqW9LeRrMIoTiW63i/HRM=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=BLSWQPShEC0aOVLwcIe7rGiotJrxuamfVTvwPS8CN0TQUNBqf7VYauaPg5sAZpiS1xYTwEQXB/+/Fh1UStSp9ZxjnJCcR0vFxwUKBswz/0Lbk4Ab4OJBJ6r+WIM4tkbBCkFmkw4wFhmerdMpVFsL8hVLRa9hazrbxritt2/02Zg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=F4wnAHSN; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="F4wnAHSN" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 762C01F00A3A; Wed, 24 Jun 2026 18:20:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1782325230; bh=Gj/dLmWpu6KCwtYE/WsbeLqQ7EsyJBapuzEt+HhI4+4=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=F4wnAHSNSNsldnTXoICx0hgvmsUSswnIYrCuzHnvAmSZnTzgMEGXkzCRbYDWdzo3+ KRXPKTadf167eFnWaXxTbQzhT8LiW4bpxy0SeolTNDk14YlHYHQgOHhhxBeTC+TfxZ ppLr3vPc5NCDoaanSIPRlxBkui23a4LTdpB9L7BT2376Qi3qo+EJ5Y5Q20j97ITVYU aFSMujOMva/VFe2WSixc8dOsAuuwb6+HYjZw8QlcoIL7aeARAhKpTe9yVlPpZaVErP 1YTbzbcLyA6ye3EWj4Y3CYZKorwhpSwZ+bOc3BXEkZmhNIy6isufVLWl2heStQiCIT pzNnYxoN8cz0Q== Date: Wed, 24 Jun 2026 19:20:26 +0100 From: Simon Horman To: Ben Dooks Cc: Kuniyuki Iwashima , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] af_unix: move proto info out of CONFIG_BPF_SYSCALL Message-ID: <20260624182026.GD1131256@horms.kernel.org> References: <20260623124940.791230-1-ben.dooks@codethink.co.uk> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260623124940.791230-1-ben.dooks@codethink.co.uk> On Tue, Jun 23, 2026 at 01:49:40PM +0100, Ben Dooks wrote: > These two structs are defined even if CONFIG_BPF_SYSCALL but > the header does not export them, so declare them anyway and > move the check for CONFIG_BPF_SYSCALL lower into the file. > > This removes the two sparse warnings: > net/unix/af_unix.c:1060:14: warning: symbol 'unix_dgram_proto' was not declared. Should it be static? > net/unix/af_unix.c:1071:14: warning: symbol 'unix_stream_proto' was not declared. Should it be static? > > This change is less complicated than trying to make those two > structs static based on the CONFIG_BPF_SYSCALL configuration. > > Signed-off-by: Ben Dooks Reviewed-by: Simon Horman Probably this is net-next material and if so should be reposted once net-next reopens next week.