From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f48.google.com (mail-wr1-f48.google.com [209.85.221.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C954038657D for ; Thu, 25 Jun 2026 08:54:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.48 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782377651; cv=none; b=T7L6wnZtiGfZ4KkyRNDajeDEmp0O3dYAtaxYEY0rTrt8kVcjidYwgsdqrmUkLffNuCmRdvGoI93O8NPNwYuFoWpHRxPGZA7yfirxJMqEMPPeY+2vUURedEGr1Bq5O11nokDuUeZRE42a1DOagnEuBY27t/HSTBlaz2XCgMEfnqA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782377651; c=relaxed/simple; bh=07Gz4DVxSchKBz41aocKqPwLf5Q7wYxmqWLTrZ9H6nY=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=U1y9TtBAICVvjHcaMOS9GPkuHi8r2kgpZ16Vure9cWj9jAsDxMqqk7N/s0vk84JOA0NdgHrpyEsizRG7Xr0qCVkKo3+1O5GvHOUqHOyGPGECcXeqvfyXfnJds0hhbOrYLCyjDXCa8NtB7LbcSTceu17UPEfyut88izhaQ9t5OIM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=TeZSIzER; arc=none smtp.client-ip=209.85.221.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="TeZSIzER" Received: by mail-wr1-f48.google.com with SMTP id ffacd0b85a97d-46e30429b10so64270f8f.1 for ; Thu, 25 Jun 2026 01:54:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1782377648; x=1782982448; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=/jDoMmJJU0PpNgF+w3Xx9Gr+Xmtdk7u64RSrEr55CTg=; b=TeZSIzEROk+wXDUJ2H7J9qtITFj/majCzC4RRZwR633P94dRl4K2X4xiaAK7By7ze+ K7DEGTJXoevUXfACUrh94xn6QJW/a9k6IusZA+lUxNCYXYF8S42eYkontmM4rq0Na2aQ VAdzE3UF3hq9AN3CidWOXPvSKb8xj/JDx7dUSbkR9TK0a4z59WyHTnjeoB6VqCsbWJCd waHDjV9/lCOJFuenJhABaW6KNlKJAQTtgSEFSccoL/kpVwQ5UPfl1w/boO/W8vAonLkh N+SyAwoJJ5z6KfqBhkwIIquIKvHtokZto2zPXoQgTZiVHXJCs0z+izxUUJ24lECJRKpq ljPQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782377648; x=1782982448; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=/jDoMmJJU0PpNgF+w3Xx9Gr+Xmtdk7u64RSrEr55CTg=; b=dLh7aHiYVfpLiSJ/bdfpdzPxp1gHt83ugfjOhyq67HpFWwp0SOCkEdiq0hPQEWmcAN jtVj5kbFgBV38mBCgIhuwbrHvtekomuRgqtedE6V+HV3mkht8+kaQlESGI/UpyBGADws s5HPh31/mZNIhgym3qHXq7DkJHryrFWAJ0VSKxsyMXScvPz8yQnqj2EpLetRvmSyTDDF o01lqdVuwV70SBy4ny929bVu0B4m3p8vyA3qZBlp04gfU87ve5A3UQVcmMySrXC7UMc5 fXj2d1V+bOHN8UDQMI7/i5x18SJuxmLUc2qnAUWEzt8Ll452ggL3jQvY5po+hqM0FSmq RZww== X-Forwarded-Encrypted: i=1; AHgh+Rp0GM/a4nm56L/gYCTZe5jbaKBZ7oZTfEZ6fhzdq62odaK908chBdhq9QoCX5RGCq7yenuvnTE=@vger.kernel.org X-Gm-Message-State: AOJu0YwYYoB8mTsiUBvk+POqIDMH7pd2ByQlDIm5LDWVVKg5rZsiVw1F REAnkqsJCzyxdYL/hLbavp8/a2nkdtUsKKpFNgRb1s/chj0BzAsJ5WX5 X-Gm-Gg: AfdE7cnskOFxrLhLF8/LypYNACBioBr5ZMu/hcPqgig7scJ/kfcHTJy9uI2BrAPjs4c C6OinLUiBSAghH/p/fkpOttzWGVIEAw0HIHF6BfpDzTLTMqMcvURY3A94Cc+LlF/QkSaS0MvZ53 yx46uKQHXBBldibwb4dbjXpRZcaFZmenKLHwW0GGH5PGsVaYVPH335LokQ/+zHjjHDqs/DDf6q7 kOjDZ2ueK+NFpliGhZG6nrL02Gv1ghOlze2ZBH7vyVvQv/1Ec6d62PU/kCGXIm7+/+9oyN425SX FGs4OqPsux8GfbW3joJkw15IgI6nss4kc2gAz8RTDUdDoj1CIVc1bdDiqDgwTktxr3Lt7KocPed aoaSUZX6zJqOP+XA8WZxFvZ1cnIwN9/1vkAnGrKI3l2xhQtwAKoj85Tx6bqe2f7LEFwjgYmkG9R 5e8iG7WNu6 X-Received: by 2002:a5d:64e4:0:b0:460:67b7:54f1 with SMTP id ffacd0b85a97d-46dc30e2c21mr2268492f8f.42.1782377648254; Thu, 25 Jun 2026 01:54:08 -0700 (PDT) Received: from localhost ([212.73.77.104]) by smtp.gmail.com with UTF8SMTPSA id ffacd0b85a97d-46c1ee018e8sm15530598f8f.11.2026.06.25.01.54.05 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 25 Jun 2026 01:54:07 -0700 (PDT) From: Askar Safin To: avagin@gmail.com Cc: akpm@linux-foundation.org, alexander@mihalicyn.com, axboe@kernel.dk, bernd@bsbernd.com, brauner@kernel.org, criu@lists.linux.dev, david@kernel.org, dhowells@redhat.com, fuse-devel@lists.linux.dev, hch@infradead.org, jack@suse.cz, joannelkoong@gmail.com, linux-api@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, miklos@szeredi.hu, netdev@vger.kernel.org, patches@lists.linux.dev, pfalcato@suse.de, rostedt@goodmis.org, safinaskar@gmail.com, torvalds@linux-foundation.org, val@packett.cool, viro@zeniv.linux.org.uk, willy@infradead.org Subject: Re: [PATCH 0/3] vmsplice: make vmsplice a trivial wrapper for preadv2/pwritev2 Date: Thu, 25 Jun 2026 11:53:57 +0300 Message-ID: <20260625085401.3787887-1-safinaskar@gmail.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: References: Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Andrei Vagin : > On Wed, Jun 24, 2026 at 12:12 AM Askar Safin wrote: > > Does CRIU actually rely on ability to do SPLICE_F_NONBLOCK vmsplice into > > named fifos? Or this is merely a test? > > Yes, it does. I. e. CRIU relies on that named fifo behavior? Okay, I just sent v2 version of my fixes. The patchset contains fix for named fifos. Please, test that this fixes that named fifo problem. > I already explained that this isn't just a perfomance degradation, it > actually breaks the pre-dump mechanism in CRIU. vmsplice is invoked from > our parasite code within the context of a user process, where execution > speed is critical. A heavy performance penalty completely invalidates > the pre-dump logic, making the feature useless. This is very unfortunate. But I still want to remove vmsplice. > At a minimum, we may need to consider a deprecation plan where vmsplice > with SPLICE_F_GIFT triggers a warning for a few releases before these > changes are applied. Alternatively, we could introduce the proposed > behavior alongside a sysctl to fall back to the old behavior and explicitly > state that this fallback path will be completely deprecated in a future kernel > version. My patches change not only SPLICE_F_GIFT behavior, but also vmsplice behavior in general. Let other developers decide what to do (i. e. do nothing, remove vmsplice now or implement some deprecation scheme). -- Askar Safin