From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B0EA13AD510 for ; Fri, 26 Jun 2026 22:29:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782512978; cv=none; b=U4sL8nbI3Kr1cXcHNIgOvIv9oHAAxfexqOSZutjyFVXl71B799BIeTlfOc9rdHJceQAtK7Ctdmtvqsv4bhIC6XR78aPoxcp0CizX1MYUgC19Z47ByZyzjYhG/Ahdoi/OzUjiWKM8bPV2Rpv9HzXDkClZnrJNE00Lfe6G6lUaQzo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782512978; c=relaxed/simple; bh=GjBxLbzrPN5i8iHbPTLj6GbG6RETFp6rUi+R2cHmzgI=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=aATA+PSfe2V+nD3vQRZCyBm63cUQgK/EY3MtXbALpLJPXIWa1V6ygUNW8OFG4Y3JvcsYomQoFeePnB8I5jWww4laIzt3XjnEZ6NA8YUzRK9yyTn8OCeAj4QVMth/eahXCbt0qJz9PoeOcP26C+82vM3R/PTk2W24r3Qb/v6mXBs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=k2bFpxlt; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="k2bFpxlt" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 453C21F000E9; Fri, 26 Jun 2026 22:29:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1782512977; bh=z/KOQXjMCL4+K9L12WXoB3UQ4LGC1afxPFJA9hVfjDA=; h=Date:From:To:Cc:Subject:In-Reply-To:References; b=k2bFpxlt7Wm9C/8eujHy5dBqsKHRHfE+7Phr5425P0zVcZf5P3HfIXdwiYDsF7S7n 49W4wkBiHrCnY8cvl0dQxC+7KyTCydr35Ro8E/qX0lh0b9t+xlGntowCX4gcgTATnD 4XAeKALM4iLKt/KtufF8mdsu8Pq8JerCU9/JKGg6HNv0be+XBKiTzDMmPI6u/4qIA6 H9kMoLRPfq9ptcoD1NvFbRw37q590Hzog7+m1e3atx5xbiDGFmsznRYj4hxW4mbGTO kTu1BWK6XIfWmKkWp6dSUpR8sTaTyh55Hos3O11SlyMAs0+Skdi5SdIwk4uc1H2rhB QA09f1cdtAzIw== Date: Fri, 26 Jun 2026 15:29:36 -0700 From: Jakub Kicinski To: Aleksandr Loktionov Cc: intel-wired-lan@lists.osuosl.org, anthony.l.nguyen@intel.com, netdev@vger.kernel.org Subject: Re: [PATCH iwl-next v5 1/2] ethtool: treat RXH_GTP_TEID as intrinsically symmetric Message-ID: <20260626152936.7359509f@kernel.org> In-Reply-To: <20260626054730.1126969-2-aleksandr.loktionov@intel.com> References: <20260626054730.1126969-1-aleksandr.loktionov@intel.com> <20260626054730.1126969-2-aleksandr.loktionov@intel.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Fri, 26 Jun 2026 07:47:29 +0200 Aleksandr Loktionov wrote: > A GTP tunnel uses the same TEID value in both directions of a flow; > including TEID in the hash input does not break src/dst symmetry. > > ethtool_rxfh_config_is_sym() currently rejects any hash field bitmap > that contains bits outside the four paired L3/L4 fields. This causes > drivers that hash GTP flows on TEID to fail the kernel's preflight > validation in ethtool_check_flow_types(), making it impossible for > those drivers to support symmetric-xor transforms at all. > > Strip RXH_GTP_TEID from the bitmap before the paired-field check so > that drivers may honestly report TEID hashing without blocking the > configuration of symmetric transforms. I don't know much about GTP, but "the Internet" does not seem to agree with your claim: The TEID uniquely identifies the GSN tunnel endpoints. The tunnels for an uplink and a downlink are separate and use a different TEID. https://docs.paloaltonetworks.com/service-providers/10-1/mobile-network-infrastructure-getting-started/gtp/mobile-network-protection-profile So I don't think this will fly..