Re: [PATCH net-next v14 0/9] tls: Add TLS 1.3 hardware offload support

[Nils Juenemann <nils.juenemann@gmail.com>]

Hi Rishikesh, all,

thanks for picking up the sendfile/EOF fix in tls_device_splice_eof().

Separate issue we hit while testing, looks pre-existing in mlx5e
rather than v14: a NULL deref on the RX offload path. Trigger is
ethtool -L <dev> combined 32 (down from 64) under HW-kTLS load,
then a TLS_RX offload setup:

BUG: unable to handle page fault for address: 00000000000031c0
RIP: mlx5e_ktls_add_rx+0x268 [mlx5_core]
Call Trace:
mlx5e_ktls_add
tls_device_dev_add_rx
tls_set_device_offload_rx
tls_setsockopt

sk_rx_queue_get(sk) returns a stale rxq (62 here) after the
reduction; mlx5e_ktls_sk_get_rxq() only guards rxq == -1, so
mlx5e_ktls_add_rx() dereferences priv->channels.c[62], which
appears to be NULL. The resync paths index
priv->channels.c[priv_rx->rxq] the same way. This path is not
TLS 1.3 specific.

I do not have a proposed fix yet. Happy to share the full
decoded oops / additional kdump details or test patches.

Thanks again,
Nils Juenemann