From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-yw1-f170.google.com (mail-yw1-f170.google.com [209.85.128.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 68AD72459EA for ; Sun, 28 Jun 2026 16:25:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.170 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782663961; cv=none; b=Ysl8Fhc/p6tKW2TYmPpB3uac8E7Rz/6RfURy6w3jCYGFQwSgb1ITGPVYTLRyCpzY3Qa0SxGH7bUv3F/w61hZo2PSzn8n8livB4SzJ9qxJNNAprW7rj2vqwnamj5TJuBQ/RFzZG1CDbe0WQOZ2ufi3G9balbHQRUggynLnThUKe8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782663961; c=relaxed/simple; bh=g2UA5Nh4NURnQU5YTpPXu2g0qAmphQXzC4iKtTM9Trg=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=YtP1OQu/jc4vIPitiJz8ei/4v9MYCVsA8FrgqgLw1MwC3J7p8rpYBVte0+oKHHhd6+ozhK5l0t/6dg9SQb0/XOzwo/GJr9d0BDoOUFo+S0KBbyMQpM96rdTUJtnHaO/3OAaUot2SVsngPbZ5O/oh7y8RWPharz1tgIGhe71glSg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=JKL0oaxE; arc=none smtp.client-ip=209.85.128.170 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="JKL0oaxE" Received: by mail-yw1-f170.google.com with SMTP id 00721157ae682-80bb578d58bso19969277b3.0 for ; Sun, 28 Jun 2026 09:25:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1782663958; x=1783268758; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=7van/FF1WCavCF+DOAc6ZN9nL2beTOurDM/vGTwpdMI=; b=JKL0oaxEiINbu1DR3+UgnHxBeii6/FkKYzrTKvU22+fk/ChTSA9jy4eXhj4jc7Gpg2 w8iShpVkpWTw+VJMXd0bvzw1dac5s7uJYNjwhJR+yvxqbkEyzYHPLZcoX1vIyHvL0qM5 Zeqz+0XIHZNyMZA/4gNAJx/ufqauTdTSGhhqWaVmEyjCoazpVp6NYmlgdlN2N7egKt12 Bz6kccKKyd7hXyyOiMlBPGb5hSfPRnYntMwytSBFoXanRyeFCutJJyep1DeqmHIS45St MHvDrxjk5Qox3p+bJl9ydS8yzcYjbQZs7sVmlLS0vuZoiB32n6o196YZ2/3IxHWBjoQX itrA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782663958; x=1783268758; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=7van/FF1WCavCF+DOAc6ZN9nL2beTOurDM/vGTwpdMI=; b=ZDsZB+OcgsbXKc7VEhmE4YPbWM7HHfo7a2bXJWez0tHUPHqA7BwXAzg1YYZxvTDNpu lTtwCSQK7yYqbQppltRYFYPUr8xmKOMF6kSl7bN2sMdWPot9h4c6Td67Z5y+irsd3INO 77nPnKZRUsKKbj4ZOPU9JLE44TKkKeLXPaZ8uexcXxVK1oRotgSZsyNWiGUvZoePqa92 ZZ4v2IXDu9OTT39MNiwjtNtvLLFUqsJhN4z7AtEhNozlzaAdLASTiDsqB3EIh1+lgMin Y29ioRo/D++b9FTnpARv/43HxqLlWnGxhmbFz68UyR61scivr6RmxOLOJ8L4FjzNvWrQ yQEg== X-Forwarded-Encrypted: i=1; AHgh+Rppa0TOfmhzjZcnqe1BTAZ3AipMNYp+cv5Z5iZa7umKh/rl6zCwXdp2Rnv7seRW1Z0z99pkAjA=@vger.kernel.org X-Gm-Message-State: AOJu0Ywx3hpqsZvG4rhy6ICOg2JKzqPFM4UQiXV8aHJiG6IW4M+TNSWR xJpWHqZwuOkH4A4R8YPMH5iSCX9WEruSYc0wz9UAuCuIy6XppgXoki6F X-Gm-Gg: AfdE7cmku2DNqK9yCMU50h4s8Z6ezVbXJ2vrN1SO3tzDTomNdVf3mboskxIVxbyGkJ7 74f1BJMvMSejedVhlV97mP2jZA+dIGcNQvp0zh85ejLsiWByKOFhh9jm3diwoj59aGlFZVYSz6U K6lbBHdQFvB17t7R/+jHC/8V9gwTS804oVtHPS+eHoRICz5IqDEZ+CLksspsPHqETwYSY2dWUJJ NyEjHRSb+s9KjM5L0Fb4w6hVBYa79QyQE156DYEbmv90TusGFYTcPaI5ipNkp8w4EyxMcAxnfOI bPJvubEkQNhjRT49zzwidmtV+15QV/jGLdtsSOmcjpDrOx/zOAPlIGVDTGvQW7DxaJ5r8WUQyqn 0lGL9GnOn3R0yYRIgpgoeJZklCzjw1H3p5s2QevZ0pkuW6oAztRMFxn9VkMgtv9Kn0hWP29fzAn NimuVUo8E+TTsdgY0uYrMukn8skQ== X-Received: by 2002:a05:690c:6185:b0:80c:85b6:764a with SMTP id 00721157ae682-80c85b69188mr75232687b3.63.1782663958305; Sun, 28 Jun 2026 09:25:58 -0700 (PDT) Received: from Dev-Null-MSI ([2a0d:3344:52ac:a808:98a4:4381:be45:536f]) by smtp.gmail.com with ESMTPSA id 00721157ae682-80259d20d84sm106446247b3.0.2026.06.28.09.25.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 28 Jun 2026 09:25:57 -0700 (PDT) From: Yousef Alhouseen To: Petko Manolov , Andrew Lunn , "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni Cc: linux-usb@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org, syzbot+9db6c624635564ad813c@syzkaller.appspotmail.com, Yousef Alhouseen Subject: [PATCH v2] net: usb: rtl8150: handle link status read failures Date: Sun, 28 Jun 2026 18:25:28 +0200 Message-ID: <20260628162528.8273-1-alhouseenyousef@gmail.com> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260628151835.GC14404@carbon.k.g> References: <20260628151835.GC14404@carbon.k.g> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit set_carrier() ignores the result of the USB control transfer and tests the stack variable supplied as its receive buffer. If the device rejects or aborts the request, that variable remains uninitialized and the driver chooses an arbitrary carrier state. Leave the existing carrier state unchanged when the link status cannot be read. A transient USB error should not be treated as link loss. Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2") Reported-by: syzbot+9db6c624635564ad813c@syzkaller.appspotmail.com Closes: https://syzkaller.appspot.com/bug?extid=9db6c624635564ad813c Cc: stable@vger.kernel.org Signed-off-by: Yousef Alhouseen --- drivers/net/usb/rtl8150.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/net/usb/rtl8150.c b/drivers/net/usb/rtl8150.c index c880c95c41a5..d51e43170e03 100644 --- a/drivers/net/usb/rtl8150.c +++ b/drivers/net/usb/rtl8150.c @@ -732,7 +732,9 @@ static void set_carrier(struct net_device *netdev) rtl8150_t *dev = netdev_priv(netdev); short tmp; - get_registers(dev, CSCR, 2, &tmp); + if (get_registers(dev, CSCR, 2, &tmp)) + return; + if (tmp & CSCR_LINK_STATUS) netif_carrier_on(netdev); else -- 2.54.0