From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail.ksb-soft.ru (mail.ksb-soft.ru [5.167.76.63]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9517D3FD946; Mon, 29 Jun 2026 13:08:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=5.167.76.63 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782738540; cv=none; b=gNdpFzTsrkjckvyo2ZUqc8lrpmfh4Q3F1p6XANgNox9p9AlsaGYtnGzAxyhEK+7Cfo8K3Pbz50eBk7LYzPWzDsQ/SD0lI8uKlFQsz47zmsK+YEpdElxl60B5wP7/kHa0wsuxWoBfiJS8rDuES1us5T7LiGb9hxu0zsS04aq/csA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782738540; c=relaxed/simple; bh=7zxT35iZfYUloVfdIN1A2Tchq2YZbtpf3iKeNzj5wWM=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=UZDfj1QlbwW1qJt9TJ+Ke274N/5U1NBBAfVXpHf3bI18pNPTdei0YvrXNFdEveqvTP3TKUiCaODFrh850sw1V+g22a+lo3mOxaceeD1HIgDGH44opOUFpSKwdoWF/6L7f0S/iPWI71XHv65NS2VLNa1994EpXkWNeENuyN3BXkc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=npc-ksb.ru; spf=pass smtp.mailfrom=npc-ksb.ru; arc=none smtp.client-ip=5.167.76.63 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=npc-ksb.ru Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=npc-ksb.ru Received: from ksb-289.ksb.ksb-soft.ru (unknown [10.38.22.14]) by mail.ksb-soft.ru (Postfix) with ESMTPA id 4gpmnP35PQz4LJWR; Mon, 29 Jun 2026 16:08:57 +0300 (MSK) From: Markov Gleb To: Potnuri Bharat Teja Cc: Gleb Markov , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , netdev@vger.kernel.org, linux-kernel@vger.kernel.org (open list), lvc-project@linuxtesting.org Subject: [PATCH net] cxgb4: Fix decode strings dump for T6 adapters Date: Mon, 29 Jun 2026 16:08:54 +0300 Message-ID: <20260629130856.1168-1-markov.gi@npc-ksb.ru> X-Mailer: git-send-email 2.52.0.windows.1 Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-KLMS-Rule-ID: 1 X-KLMS-Message-Action: clean X-KLMS-AntiSpam-Lua-Profiles: 197590 [Oct 29 2025] X-KLMS-AntiSpam-Version: 6.1.1.11 X-KLMS-AntiSpam-Envelope-From: markov.gi@npc-ksb.ru X-KLMS-AntiSpam-Rate: 0 X-KLMS-AntiSpam-Status: not_detected X-KLMS-AntiSpam-Method: none X-KLMS-AntiSpam-Auth: dkim=none X-KLMS-AntiSpam-Info: LuaCore: 72 0.3.72 80ff96170b649fb7ebd1aa4cb544c36c109810bd, {Tracking_uf_ne_domains}, {Tracking_from_domain_doesnt_match_to}, FromAlignment: s X-MS-Exchange-Organization-SCL: -1 X-KLMS-AntiSpam-Interceptor-Info: scan successful X-KLMS-AntiPhishing: Clean X-KLMS-LinksScanning: Clean X-KLMS-AntiVirus: Kaspersky Security for Linux Mail Server, version 10.0.0.7427, bases: 2025/10/29 20:57:00 #27800623 X-KLMS-AntiVirus-Status: Clean, skipped From: Gleb Markov Depending on the value of chip_version, the correct decode set is selected. However, the subsequent matching with the t4 encoding type in the if-else block results in a reassignment, which leads to the loss of support for t6_decode as well as reinitializing of values t4_decode and t5_decode. The component history shows that the if-else block previously used for this purpose, as well as the execution order, was not affected by the change. Furthermore, it is suggested by the execution order that the scenario with overwriting and loss of support will be implemented. Delete the if-else block. Found by Linux Verification Center (linuxtesting.org) with SVACE. Fixes: 6df397539cb0 ("cxgb4: Update correct encoding of SGE Ingress DMA States for T6 adapter") Signed-off-by: Gleb Markov --- drivers/net/ethernet/chelsio/cxgb4/t4_hw.c | 8 -------- 1 file changed, 8 deletions(-) diff --git a/drivers/net/ethernet/chelsio/cxgb4/t4_hw.c b/drivers/net/ethernet/chelsio/cxgb4/t4_hw.c index 8d719f82854a..f3e8153a7a0b 100644 --- a/drivers/net/ethernet/chelsio/cxgb4/t4_hw.c +++ b/drivers/net/ethernet/chelsio/cxgb4/t4_hw.c @@ -6735,14 +6735,6 @@ void t4_sge_decode_idma_state(struct adapter *adapter, int state) return; } - if (is_t4(adapter->params.chip)) { - sge_idma_decode = (const char **)t4_decode; - sge_idma_decode_nstates = ARRAY_SIZE(t4_decode); - } else { - sge_idma_decode = (const char **)t5_decode; - sge_idma_decode_nstates = ARRAY_SIZE(t5_decode); - } - if (state < sge_idma_decode_nstates) CH_WARN(adapter, "idma state %s\n", sge_idma_decode[state]); else -- 2.43.0