From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 881B93EA962 for ; Tue, 30 Jun 2026 11:19:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782818393; cv=none; b=IS7Dg54Sn9rYTwueFTKpmREzr0tED9ADVf3bst/6Qu7hjJxsoGAauYs+iK37dAv5SN052qxCqZVhXEJhCUeolLmww9HP/rdAQuxTHvtMWUoLIQkas7VNHYb0yRMOUzEJutsbOX5Hz1Ovr79FtSkswOKpJKP7MSG4ZXnfzSkRhQM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782818393; c=relaxed/simple; bh=9SQSa2lndL91crLT50aovAsfxh0Gj2zHfRJAMccp9ao=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=dV5g7Zbt4eCv7z/zEZISlyfdkx1K9cmxw6CgDhlCj1ZminoYwbZtWHPWxxINW8U3eciGA39MfU4lYciTJmJkfjqtuvUFM4B1xIubG4ys4ff9zEC2UigT+ciK9zK06FHvDiaoFHKZUXHbkZ0Qyq4A/TCMjzfwOGPOIPuSAsASGxk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=CKY49s/g; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="CKY49s/g" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 259E01F00A3A; Tue, 30 Jun 2026 11:19:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1782818392; bh=WXMm0GByJ8ckgmNhY27Iw1au8xjrtbDfFsApmsKjXWU=; h=From:Date:Subject:References:In-Reply-To:To:Cc; b=CKY49s/gJpkGE2KiUoDx9XjwZbrnYMxoFfchm/AWEUfQWPPB8fyi9m0K600e7FFe1 xzzXGc5rbPx1DiVWhfVqoPIHipiJivgvp8SFUQdsxpP6ZKRq8Fbu7xtO10O/UGeOfW Ydpl1dPLQ2c4xOqA17LFmHNbwnWHx7C1FbFoiXpQiHmfCWzbeSmgWVwxKgSRUU7dCT Z52NdzEEKIutqeXt/T7X4GVYXW3qPAWWhoqyAxgCE9v+bSxSIXMVE3t9LExPDn3i7i Ri9oSLQtJa5TCGtZwec5zc5D4TL0K1SVtINHFY0zGZmuXlcK1qE5USikLlwLtW+0XC kS4GMd2WNdYVA== From: Linus Walleij Date: Tue, 30 Jun 2026 13:19:41 +0200 Subject: [PATCH net-next v2 1/5] net: dsa: realtek: rtl83xx: Make learning optional in join/leave Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260630-rtl8366rb-improvements-v2-1-05eb9d6a37f5@kernel.org> References: <20260630-rtl8366rb-improvements-v2-0-05eb9d6a37f5@kernel.org> In-Reply-To: <20260630-rtl8366rb-improvements-v2-0-05eb9d6a37f5@kernel.org> To: Luiz Angelo Daros de Luca , =?utf-8?q?Alvin_=C5=A0ipraga?= , Andrew Lunn , Vladimir Oltean , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni Cc: netdev@vger.kernel.org, Linus Walleij X-Mailer: b4 0.15.2 Mostly to make it possible to add rtl83xx support piece by piece, make the port learning callback optional in rtl83xx_port_bridge_join() and rtl83xx_port_bridge_leave(). Signed-off-by: Linus Walleij --- drivers/net/dsa/realtek/rtl83xx.c | 26 ++++++++++++-------------- 1 file changed, 12 insertions(+), 14 deletions(-) diff --git a/drivers/net/dsa/realtek/rtl83xx.c b/drivers/net/dsa/realtek/rtl83xx.c index 71124ecca92f..90843d52c5a8 100644 --- a/drivers/net/dsa/realtek/rtl83xx.c +++ b/drivers/net/dsa/realtek/rtl83xx.c @@ -356,9 +356,6 @@ int rtl83xx_port_bridge_join(struct dsa_switch *ds, int port, if (!priv->ops->port_add_isolation) return -EOPNOTSUPP; - if (!priv->ops->port_set_learning) - return -EOPNOTSUPP; - dev_dbg(priv->dev, "bridge %d join port %d\n", bridge.num, port); /* Add this port to the isolation group of every other port @@ -396,9 +393,11 @@ int rtl83xx_port_bridge_join(struct dsa_switch *ds, int port, goto undo_self_isolation; } - ret = priv->ops->port_set_learning(priv, port, true); - if (ret) - goto undo_efid; + if (priv->ops->port_set_learning) { + ret = priv->ops->port_set_learning(priv, port, true); + if (ret) + goto undo_efid; + } return 0; @@ -443,9 +442,6 @@ void rtl83xx_port_bridge_leave(struct dsa_switch *ds, int port, if (!priv->ops->port_remove_isolation) return; - if (!priv->ops->port_set_learning) - return; - dev_dbg(priv->dev, "bridge %d leave port %d\n", bridge.num, port); /* Remove this port from the isolation group of every other @@ -474,11 +470,13 @@ void rtl83xx_port_bridge_leave(struct dsa_switch *ds, int port, * downstream DSA ports from the isolation group. */ - ret = priv->ops->port_set_learning(priv, port, false); - if (ret) - dev_err(priv->dev, - "failed to disable learning on port %d: %pe\n", - port, ERR_PTR(ret)); + if (priv->ops->port_set_learning) { + ret = priv->ops->port_set_learning(priv, port, false); + if (ret) + dev_err(priv->dev, + "failed to disable learning on port %d: %pe\n", + port, ERR_PTR(ret)); + } /* Remove those ports from the isolation group of this port */ ret = priv->ops->port_remove_isolation(priv, port, mask); -- 2.54.0