From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from zg8tmja5ljk3lje4mi4ymjia.icoremail.net (zg8tmja5ljk3lje4mi4ymjia.icoremail.net [209.97.182.222]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 61C0623C4F3; Tue, 30 Jun 2026 06:32:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.97.182.222 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782801130; cv=none; b=uZrvSLYD9ignRjvruMVdYOxQzwJoIf9uvbU8vQjknQ+JYo2m7a2apg6kIlS7tsbLNr47qejZWUMCz0MZ/AcrpT+ng3Hx2xugcRYidVA/6lu2CUXehbrTNwSbX16MwN3DrQGFaHvIrDuLOym7wKyUXRmqyjKrD5s+K/kNt55sKrk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782801130; c=relaxed/simple; bh=MB0sR8M7gI+M0Gyk97cs1UMFVhTrirUVDMe7mVxx/Dw=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=DR5UI6mwu1Muy3W7b5dpM+lZjpfVgvNgxgqKvbFUqB9cLbIqA0895Tpj2UunB7i88h7rv7MmKGq3G96VSbplaMkEa9CjIpXYJQf5ltq0xvBi2N/ohJujp9BbAPLF+dUj7BSrP4j7biUcAXpFns2v5LEdMBJbFEgfIvajomzutLM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=eswincomputing.com; spf=pass smtp.mailfrom=eswincomputing.com; arc=none smtp.client-ip=209.97.182.222 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=eswincomputing.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=eswincomputing.com Received: from E0004057DT.eswin.cn (unknown [10.11.96.26]) by app2 (Coremail) with SMTP id TQJkCgDn+57AYkNqSBwwAA--.59400S2; Tue, 30 Jun 2026 14:31:29 +0800 (CST) From: lizhi2@eswincomputing.com To: devicetree@vger.kernel.org, andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, netdev@vger.kernel.org, pabeni@redhat.com, mcoquelin.stm32@gmail.com, alexandre.torgue@foss.st.com, rmk+kernel@armlinux.org.uk, pjw@kernel.org, palmer@dabbelt.com, aou@eecs.berkeley.edu, alex@ghiti.fr, linux-riscv@lists.infradead.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, maxime.chevallier@bootlin.com Cc: ningyu@eswincomputing.com, linmin@eswincomputing.com, pinkesh.vaghela@einfochips.com, pritesh.patel@einfochips.com, weishangjuan@eswincomputing.com, horms@kernel.org, lee@kernel.org, wens@kernel.org, Zhi Li Subject: [PATCH net-next v9 0/6] net: stmmac: eic7700: add eth1 variant support and update delay bindings Date: Tue, 30 Jun 2026 14:31:22 +0800 Message-ID: <20260630063123.1118-1-lizhi2@eswincomputing.com> X-Mailer: git-send-email 2.52.0.windows.1 Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-CM-TRANSID:TQJkCgDn+57AYkNqSBwwAA--.59400S2 X-Coremail-Antispam: 1UD129KBjvJXoW3KF4rCry5Jr4kAr4fWFyfJFb_yoWktr18pF Z8Wrn8GFsxJFyxAan7JF109a4Fqan3GFyj9r1rJrnrXws09FyqqrWS9F45ZFyDurZ7uryY vF45tF4vka4j9FJanT9S1TB71UUUUU7qnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2 9KBjDU0xBIdaVrnRJUUUBv14x267AKxVWrJVCq3wAFc2x0x2IEx4CE42xK8VAvwI8IcIk0 rVWrJVCq3wAFIxvE14AKwVWUJVWUGwA2ocxC64kIII0Yj41l84x0c7CEw4AK67xGY2AK02 1l84ACjcxK6xIIjxv20xvE14v26F1j6w1UM28EF7xvwVC0I7IYx2IY6xkF7I0E14v26r4U JVWxJr1l84ACjcxK6I8E87Iv67AKxVW0oVCq3wA2z4x0Y4vEx4A2jsIEc7CjxVAFwI0_Gc CE3s1le2I262IYc4CY6c8Ij28IcVAaY2xG8wAqx4xG64xvF2IEw4CE5I8CrVC2j2WlYx0E 2Ix0cI8IcVAFwI0_Jr0_Jr4lYx0Ex4A2jsIE14v26r1j6r4UMcvjeVCFs4IE7xkEbVWUJV W8JwACjcxG0xvY0x0EwIxGrwACjI8F5VA0II8E6IAqYI8I648v4I1lFIxGxcIEc7CjxVA2 Y2ka0xkIwI1lw4CEc2x0rVAKj4xxMxkF7I0En4kS14v26r4a6rW5MxkIecxEwVCm-wCF04 k20xvY0x0EwIxGrwCFx2IqxVCFs4IE7xkEbVWUJVW8JwC20s026c02F40E14v26r1j6r18 MI8I3I0E7480Y4vE14v26r106r1rMI8E67AF67kF1VAFwI0_GFv_WrylIxkGc2Ij64vIr4 1lIxAIcVC0I7IYx2IY67AKxVWUJVWUCwCI42IY6xIIjxv20xvEc7CjxVAFwI0_Gr0_Cr1l IxAIcVCF04k26cxKx2IYs7xG6r1j6r1xMIIF0xvEx4A2jsIE14v26r1j6r4UMIIF0xvEx4 A2jsIEc7CjxVAFwI0_Gr0_Gr1UYxBIdaVFxhVjvjDU0xZFpf9x0pRBOJnUUUUU= X-CM-SenderInfo: xol2xx2s6h245lqf0zpsxwx03jof0z/ From: Zhi Li v8 -> v9: - patch1: - Add Reviewed-by: Rob Herring - patch2: - Update DT binding schema for tx-internal-delay-ps: - Replace the previous oneOf schema with a base range plus allOf/if-then conditional constraints. - Define a common range of 0-4540 ps and apply compatible-specific constraints using conditional schema rules: - eswin,eic7700-qos-eth: maximum 2540 ps - eswin,eic7700-qos-eth-clk-inversion: minimum 2000 ps - patch6: - Refine DTS implementation to address Sashiko review comments: - Address DTC and dtbs_check warnings. - Improve node naming and HSP bus organization. - patch5 and patch6: - Update commit messages for the DTS patches: - Clarify that the DTS patches are included only to provide an overview of the complete Ethernet integration for review. - The upstream DTS enablement will be submitted as a separate series after the DT bindings and driver changes have been applied. - Link to v8: https://lore.kernel.org/lkml/20260610012727.848-1-lizhi2@eswincomputing.com/ v7 -> v8: - eth0-related fixes were moved into separate series [1], [2]: - All eth0-related fixes have been removed from this series to avoid mixing MAC variants and RX timing logic in a single review context. - Reference: [1]https://lore.kernel.org/lkml/20260602014528.2076-1-lizhi2@eswincomputing.com/ [2]https://lore.kernel.org/lkml/20260518021919.404-1-lizhi2@eswincomputing.com/ - Update cover letter and overall series scope description: - Replace previous wording "EIC7700 eth1 RX sampling timing fix" with a more accurate description: - Add eth1 MAC variant support. - Update RGMII delay binding model. - This reflects the structural nature of the series rather than a pure bug fix. - Split DT bindings changes into two patches: - patch1: - Relax RGMII internal delay constraints. - Change rx/tx internal delay from enum-based model to range-based model. - Mark delay properties as optional. - patch2: - Introduce EIC7700 eth1 MAC variant compatible string "eswin,eic7700-qos-eth-clk-inversion". - Model silicon-specific RX clock inversion requirement via SoC variant instead of board-level properties. - Due to this restructuring: - Patch structure and commit messages have changed significantly compared to v7. - The previously received Acked-by from Conor Dooley is not carried forward because the binding patches were substantially reworked and split. - Split driver changes into two patches. No functional changes to eth1 compared to v7: - patch 3: - Make rx-internal-delay-ps and tx-internal-delay-ps optional. - Remove mandatory DT property requirement in probe path. - Allow zero-delay default when properties are absent. - patch 4: - Add support for eth1 MAC variant using compatible-specific match data. - Introduce RX clock inversion handling for eth1 at runtime. - Apply speed-dependent configuration via fix_mac_speed() callback. - Note: - These patches (5/6 and 6/6) are included only to facilitate review of the overall Ethernet integration across bindings, driver, and device tree. A cleaned-up, upstream-ready DTS series will be submitted separately once all dependencies and final hardware integration are completed. - Link to v7: https://lore.kernel.org/lkml/20260427072353.1114-1-lizhi2@eswincomputing.com/ v6 -> v7: - Address checkpatch.pl --strict warnings for DTS changes: - Split DT binding documentation and DTS board description into separate patches - Fix DTS style issues reported by checkpatch: - Reduce line length where applicable - Add required description for rgmii-rxid - DTS changes in this series are split into: - Patch 3/4: syscon binding update (documentation / reference only) - Patch 4/4: board DTS changes (architecture overview only) These patches (3/4 and 4/4) are provided to facilitate review of the overall Ethernet integration across binding, driver, and device tree, and are not intended as final upstream submission in their current form. A cleaned-up, upstream-ready DTS series will be submitted separately once all dependencies and final hardware integration are completed. - Note: - Clock-related bindings referenced in earlier revisions are now already merged into net-next, so dtbs_check warnings related to clock are no longer present and are not relevant to this revision. - No functional changes in the stmmac driver or binding semantics in this revision. - Link to v6: https://lore.kernel.org/lkml/20260423085501.760-1-lizhi2@eswincomputing.com/ v5 -> v6: - Update DTS/DTSI descriptions to fix invalid phandle references reported by DTC: - Add missing GMAC provider nodes required for proper hardware description: - HSP power domain: GMAC nodes moved under this domain to reflect hardware power hierarchy. - Clock nodes: added to provide clk phandles referenced by GMAC. - Reset nodes: added to provide reset phandles referenced by GMAC. - Pinctrl nodes: defines pinctrl settings for GMAC signals (pinctrl_gpio106, pinctrl_gpio111). - Move GMAC nodes under the correct HSP power domain. - Ensure DTS builds without dtc errors and all phandle references (clk/reset/pinctrl/power-domain) are valid. - This update does not change runtime behavior; it only improves DTS consistency and resolves issues reported by dtc. - Note: - The patch 3/3 for DTS changes in this series provide an overview of the GMAC integration and its dependencies, as discussed previously: https://lore.kernel.org/lkml/64bf6b40-b947-4ffa-8d48-4d6341931327@lunn.ch/ - It is **not intended for upstream inclusion** in its current form, and is provided solely for architecture overview and integration context. - A fully cleaned and upstream-ready DTS series will be submitted separately once all related components (pinctrl, clock, power-domain, etc.) are finalized. - dtbs_check has been run on top of net-next for reference purposes. Remaining warnings are expected due to missing EIC7700 clock bindings[1] in net-next and do not reflect issues in the DTS design itself. - One remaining warning: - eswin,eic7700-clock - The clock binding has already been applied to upstream and is present in mainline, but not yet available in net-next. - The syscon binding is extended in this series to include the eswin,eic7700-syscfg compatible. - Any further refinement of the syscfg binding will be handled in separate patches if needed. - Dependencies: - [1]EIC7700 clock binding: https://lore.kernel.org/lkml/20260303080637.2100-1-dongxuyang@eswincomputing.com/ (already applied to upstream) - Link to v5: https://lore.kernel.org/lkml/20260324073017.376-1-lizhi2@eswincomputing.com/ v4 -> v5: - eswin,eic7700-eth.yaml: - Add Acked-by from Conor Dooley - No functional changes - Update dwmac-eic7700.c: - Disable clocks on the error path to fix a clock leak in eic7700_dwmac_init() when regmap_set_bits() fails (reported by Simon Horman ) - Link to v4: https://lore.kernel.org/lkml/20260313075234.1567-1-lizhi2@eswincomputing.com/ v3 -> v4: - Update eswin,eic7700-eth.yaml: - Improve commit message in dt-bindings patch to clarify the hardware difference of the eth1 MAC and why a new compatible string is required. - Move the newly added eswin,hsp-sp-csr item to the end of the list to avoid inserting entries in the middle of the binding schema. - Simplify the compatible schema by replacing the previous oneOf construct with an enum. - Update dwmac-eic7700.c: - Fix build issues. - Adjust code to match the updated binding definition. - Update DTS/DTSI descriptions: - Move SoC-level descriptions to the .dtsi file. - Keep board-specific configuration in the .dts file. - Link to v3: https://lore.kernel.org/lkml/20260303061525.846-1-lizhi2@eswincomputing.com/ v2 -> v3: - Update eswin,eic7700-eth.yaml: - Extend rx-internal-delay-ps and tx-internal-delay-ps range from 0-2400 to 0-2540 to match the full 7-bit hardware delay field (127 * 20 ps). - Add "multipleOf: 20" constraint to reflect the 20 ps hardware step size. - Make rx-internal-delay-ps and tx-internal-delay-ps optional. A well-designed board should not require internal delay tuning. - Remove rx-internal-delay-ps and tx-internal-delay-ps from the example to avoid encouraging blind copy into board DTs. - Update dwmac-eic7700.c: - Treat rx-internal-delay-ps and tx-internal-delay-ps as optional DT properties. - Apply delay configuration only when properties are present. - Keep TX/RX delay registers cleared by default to ensure a deterministic state when no delay is specified. - Describe Ethernet configuration for the HiFive Premier P550 board: - Add GMAC controller nodes for the HiFive Premier P550 board to describe the on-board Ethernet configuration. The Ethernet controller depends on clock, reset, pinctrl and HSP subsystem providers which are currently under upstream review. These dependent nodes will be submitted separately once the corresponding drivers are merged. Due to these missing dependencies, dt-binding-check may report warnings or failures for this series. - No functional changes to RX clock inversion logic. - Link to v2: https://lore.kernel.org/lkml/20260209094628.886-1-lizhi2@eswincomputing.com/ - This series is based on the EIC7700 clock support series: https://lore.kernel.org/all/20260210095008.726-1-dongxuyang@eswincomputing.com/ The clock series is currently under review. v1 -> v2: - Update eswin,eic7700-eth.yaml: - Drop the vendor-specific properties eswin,rx-clk-invert and eswin,tx-clk-invert. - Introduce a distinct compatible string "eswin,eic7700-qos-eth-clk-inversion" to describe MAC instances that require internal RGMII clock inversion. This models the SoC-specific hardware difference directly via the compatible string and avoids per-board configuration properties. - Change rx-internal-delay-ps and tx-internal-delay-ps from enum to minimum/maximum to reflect the actual delay range (0-2400 ps) - Add reference to High-Speed Subsystem documentation in eswin,hsp-sp-csr description. The HSP CSR block is described in Chapter 10 ("High-Speed Interface") of the EIC7700X SoC Technical Reference Manual, Part 4 (EIC7700X_SoC_Technical_Reference_Manual_Part4.pdf): https://github.com/eswincomputing/EIC7700X-SoC-Technical-Reference-Manual/releases - Update dwmac-eic7700.c: - Remove handling of eswin,rx-clk-invert and eswin,tx-clk-invert properties. - Select RX clock inversion based on the new "eswin,eic7700-qos-eth-clk-inversion" compatible string, using match data to apply the required configuration for affected MAC instances (eth1). - Link to v1: https://lore.kernel.org/lkml/20260109080601.1262-1-lizhi2@eswincomputing.com/ Zhi Li (6): dt-bindings: ethernet: eswin: relax internal delay model to range-based constraints dt-bindings: ethernet: eswin: add EIC7700 eth1 RX clock inversion variant net: stmmac: eic7700: make RGMII delay properties optional net: stmmac: eic7700: add support for eth1 clock inversion variant dt-bindings: mfd: syscon: add ESWIN EIC7700 compatible riscv: dts: eswin: eic7700-hifive-premier-p550: enable Ethernet controller .../devicetree/bindings/mfd/syscon.yaml | 2 + .../bindings/net/eswin,eic7700-eth.yaml | 74 +++++- .../dts/eswin/eic7700-hifive-premier-p550.dts | 240 ++++++++++++++++++ arch/riscv/boot/dts/eswin/eic7700.dtsi | 105 ++++++++ .../ethernet/stmicro/stmmac/dwmac-eic7700.c | 117 ++++++++- 5 files changed, 511 insertions(+), 27 deletions(-) -- 2.25.1