From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtpout-03.galae.net (smtpout-03.galae.net [185.246.85.4]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 27D9B19067C; Tue, 30 Jun 2026 08:37:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.246.85.4 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782808634; cv=none; b=eWS60Epfl+WxZdvy7S8fzm/2hkiSbe3UOvSPfLSYMrJZMVpTDnPDZbBbe80Snt7qRKG4Imbtw6Kb9AxXkikxNmiD43khFaMe5qZXi2w+MdEOlaRDGGZ5C93vgk0o50LzRQvAede1WWkfOC2s45DjoGSBAefhEmDgGAOWXNki/js= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782808634; c=relaxed/simple; bh=aooLG63bV4zknygq7xk22oDT4j7FegkFgEwk2Un2eec=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=nx+4oZTmhbUZO2dyoZgU174G+Q+nJvw0kph2DQRZkRJC0PpJefQ85KG9cQLIqXUpnK+sW4pn37a0pDtUoVBUQ0KiaMxsnsixa1JAgZ/8cKoMWR9po8b69PvS+LunSC5ScIzZRY6HeMmCR7aKfNqclfcdt1kbXYAcBOUaIbiIcSY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com; spf=pass smtp.mailfrom=bootlin.com; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b=Wbfs4TxI; arc=none smtp.client-ip=185.246.85.4 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bootlin.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b="Wbfs4TxI" Received: from smtpout-01.galae.net (smtpout-01.galae.net [212.83.139.233]) by smtpout-03.galae.net (Postfix) with ESMTPS id 6403E4E40B94; Tue, 30 Jun 2026 08:37:09 +0000 (UTC) Received: from mail.galae.net (mail.galae.net [212.83.136.155]) by smtpout-01.galae.net (Postfix) with ESMTPS id 2F9A160233; Tue, 30 Jun 2026 08:37:09 +0000 (UTC) Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id 77EC2106F1C74; Tue, 30 Jun 2026 10:37:03 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=dkim; t=1782808628; h=from:subject:date:message-id:to:cc:mime-version: content-transfer-encoding; bh=fd/QA6acfgIrDHgg6VpbFw+QypozMGr8wd9fRrr3/8Q=; b=Wbfs4TxI74pThMevE/iwEHtgj27864fo5QxSfoWLoOsGVI9u8NDKPR6j4KnxsiEZsW1KBJ mlVGDH993x+KgcgiAi3XEnUEgnEUcrY0X4KyJSRWx/WAOg117a0d0qZzF5Dk1yPvNA5tNp RIZqAMPsLpLiWq4ZgfgoefLZZDN1pH+yKPkGC5eluWuWwVlP7jEFmQewnaO2A+sx62Rrid kVzXMpfnBNaEbYFrPY4X51Mq7nEN3u8XJJm/kZ+F5e/dAY2YqxHJ7/8zpqUg+G6hi4ippT vdkSbEe8DGir749qvy0+x/rztAfCPMPVL/PwTyXHBzybeJj/C0uMJcmIMTvG3A== From: Maxime Chevallier To: Andrew Lunn , davem@davemloft.net, Eric Dumazet , Jakub Kicinski , Paolo Abeni , Russell King , Heiner Kallweit Cc: Maxime Chevallier , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, thomas.petazzoni@bootlin.com Subject: [PATCH net-next] net: phylink: Drop references to the .validate() method in comments Date: Tue, 30 Jun 2026 10:37:00 +0200 Message-ID: <20260630083700.2041915-1-maxime.chevallier@bootlin.com> X-Mailer: git-send-email 2.54.0 Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Last-TLS-Session-Version: TLSv1.3 The phylink_mac_ops '.validate()' has been removed in: commit da5f6b80ad64 ("net: phylink: remove .validate() method") There are still a few comments around in phylink that references that, related to the ports fields as well as the Pause configuration. Let's drop these references and update the comments related to Pause handling. Signed-off-by: Maxime Chevallier --- drivers/net/phy/phylink.c | 15 +++++++-------- 1 file changed, 7 insertions(+), 8 deletions(-) diff --git a/drivers/net/phy/phylink.c b/drivers/net/phy/phylink.c index 087ac63f9193..59dfe35afa54 100644 --- a/drivers/net/phy/phylink.c +++ b/drivers/net/phy/phylink.c @@ -153,8 +153,7 @@ static DECLARE_PHY_INTERFACE_MASK(phylink_sfp_interfaces); * phylink_set_port_modes() - set the port type modes in the ethtool mask * @mask: ethtool link mode mask * - * Sets all the port type modes in the ethtool mask. MAC drivers should - * use this in their 'validate' callback. + * Sets all the port type modes in the ethtool mask. */ void phylink_set_port_modes(unsigned long *mask) { @@ -2095,9 +2094,9 @@ static int phylink_bringup_phy(struct phylink *pl, struct phy_device *phy, /* * This is the new way of dealing with flow control for PHYs, * as described by Timur Tabi in commit 529ed1275263 ("net: phy: - * phy drivers should not set SUPPORTED_[Asym_]Pause") except - * using our validate call to the MAC, we rely upon the MAC - * clearing the bits from both supported and advertising fields. + * phy drivers should not set SUPPORTED_[Asym_]Pause"). MAC drivers + * set their support using the MAC_SYM_PAUSE and MAC_ASYM_PAUSE + * capabilities and must NOT change the phy's pause settings directly. */ phy_support_asym_pause(phy); @@ -3931,9 +3930,9 @@ static int phylink_sfp_connect_phy(void *upstream, struct phy_device *phy) /* * This is the new way of dealing with flow control for PHYs, * as described by Timur Tabi in commit 529ed1275263 ("net: phy: - * phy drivers should not set SUPPORTED_[Asym_]Pause") except - * using our validate call to the MAC, we rely upon the MAC - * clearing the bits from both supported and advertising fields. + * phy drivers should not set SUPPORTED_[Asym_]Pause"). MAC drivers + * set their support using the MAC_SYM_PAUSE and MAC_ASYM_PAUSE + * capabilities and must NOT change the phy's pause settings directly. */ phy_support_asym_pause(phy); -- 2.54.0