From: Jakub Kicinski <kuba@kernel.org>
To: Willem de Bruijn <willemdebruijn.kernel@gmail.com>
Cc: davem@davemloft.net, netdev@vger.kernel.org, edumazet@google.com,
pabeni@redhat.com, andrew+netdev@lunn.ch, horms@kernel.org,
shuah@kernel.org, willemb@google.com, noren@nvidia.com,
gal@nvidia.com, linux-kselftest@vger.kernel.org
Subject: Re: [PATCH net-next] selftests: drv-net: toeplitz: cap the Rx queue count
Date: Tue, 30 Jun 2026 16:10:52 -0700 [thread overview]
Message-ID: <20260630161052.5a6c2ec3@kernel.org> (raw)
In-Reply-To: <willemdebruijn.kernel.23684913d1fd4@gmail.com>
On Tue, 30 Jun 2026 13:11:15 -0400 Willem de Bruijn wrote:
> > +def _cap_queue_count(cfg):
> > + ehdr = {"header": {"dev-index": cfg.ifindex}}
> > + chans = cfg.ethnl.channels_get(ehdr)
> > +
> > + config = {}
> > + restore = {}
> > + for key in ("combined-count", "rx-count"):
>
> This assumes that combined and rx are not set at the same time.
> SGTM, not expected in real devices. But technically they could be.
Ack, some tests just assume the NIC uses combined, which is most common.
If this ever causes issues we should probably add support for
provisioning min/max number of queues in the env setup itself.
IIRC someone even posted that at some point.
next prev parent reply other threads:[~2026-06-30 23:10 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-29 23:43 [PATCH net-next] selftests: drv-net: toeplitz: cap the Rx queue count Jakub Kicinski
2026-06-30 17:11 ` Willem de Bruijn
2026-06-30 23:10 ` Jakub Kicinski [this message]
2026-07-02 8:30 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260630161052.5a6c2ec3@kernel.org \
--to=kuba@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=gal@nvidia.com \
--cc=horms@kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=noren@nvidia.com \
--cc=pabeni@redhat.com \
--cc=shuah@kernel.org \
--cc=willemb@google.com \
--cc=willemdebruijn.kernel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox