From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com [67.231.148.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3643636728F; Wed, 1 Jul 2026 03:14:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=67.231.148.174 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782875661; cv=none; b=M/l4z1lLM7MIZLMOm06x6Z/2HuW4W1UcLnQA9aUIO9p046yaCKeroB5n7Fv5KlCVlw5/VftAYuNsWJWgu0pc1zlqDHxIqyxbtT5a3KmjhR/kNmgRZw0Tu7hGHtQHT4rk0MG+1KSPUwWyzOo8bY5XZZ+3hpvzDAZypiyYcWJRtM8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782875661; c=relaxed/simple; bh=JednrzXnDxkafOhtty2lkU/oY2wK64ws0iG8VhUIDOE=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=Nh+rMvGrxh2APoHWybvep6zgIArrqXjRdmwbHST+/BHepI+Bi+vriOzAXzcKwBnxUktHfnlFlVV4EileW8PQrNN+obahZlsHeooN4mPCX5ZbEVNdbBEdbhA0IVozgCUab5H6n5tQdpDzXDtKHXDUCHTZzTYT84oj7WYnaygiAhk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=marvell.com; spf=pass smtp.mailfrom=marvell.com; dkim=pass (2048-bit key) header.d=marvell.com header.i=@marvell.com header.b=BuknYlFu; arc=none smtp.client-ip=67.231.148.174 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=marvell.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=marvell.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=marvell.com header.i=@marvell.com header.b="BuknYlFu" Received: from pps.filterd (m0045849.ppops.net [127.0.0.1]) by mx0a-0016f401.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 6612vTQc2207267; Tue, 30 Jun 2026 20:14:11 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=pfpt0220; bh=7 AvdgVr3QRDIWeldWDM0dtGdNKHEk1MnEyC3CdIAFNM=; b=BuknYlFuvgyuI/Isv TQp8jp0iRFLfPRvCeXAj1lTNh9Eun9PkCrkdD70oi+o8ZXEdG18FRc/dfGaWRxAN KbsBLrmNwaN7XAEMGEmvcWL9UKZ+vIg7rgv1n0jG6zxz69ZdN07J3FFFtjYkJWZI FfCP8g9J+vGVOJbb3bUmvFAA7rTi1+pKUpLnXLosik47Ux6ftqLpxMYSCfH6qSnG wd6PRPeUTM6znLvsxaPk7Qsw6VEEf38xzOwAWHViEGNLMNTw96HT9zR7aTgoSSyj CP7OnIUAE9gddZV12D6SPj/IfOT4uk+LP3rNtMU148Qsbb64//olCQXvOj8Osh7h He3tg== Received: from dc5-exch05.marvell.com ([199.233.59.128]) by mx0a-0016f401.pphosted.com (PPS) with ESMTPS id 4f4cty3b4h-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 30 Jun 2026 20:14:11 -0700 (PDT) Received: from DC5-EXCH05.marvell.com (10.69.176.209) by DC5-EXCH05.marvell.com (10.69.176.209) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.25; Tue, 30 Jun 2026 20:14:10 -0700 Received: from maili.marvell.com (10.69.176.80) by DC5-EXCH05.marvell.com (10.69.176.209) with Microsoft SMTP Server id 15.2.1544.25 via Frontend Transport; Tue, 30 Jun 2026 20:14:10 -0700 Received: from rkannoth-OptiPlex-7090.. (unknown [10.28.36.165]) by maili.marvell.com (Postfix) with ESMTP id 31E7B3F7059; Tue, 30 Jun 2026 20:14:06 -0700 (PDT) From: Ratheesh Kannoth To: , , , , CC: , , , , Subject: [PATCH iproute2-next v3 1/2] devlink: use DEVLINK_VAR_ATTR_TYPE_* in param show/set Date: Wed, 1 Jul 2026 08:43:58 +0530 Message-ID: <20260701031359.839221-2-rkannoth@marvell.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260701031359.839221-1-rkannoth@marvell.com> References: <20260701031359.839221-1-rkannoth@marvell.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Authority-Analysis: v=2.4 cv=etnvCIpX c=1 sm=1 tr=0 ts=6a448603 cx=c_pps a=rEv8fa4AjpPjGxpoe8rlIQ==:117 a=rEv8fa4AjpPjGxpoe8rlIQ==:17 a=FelO9ux0wxsA:10 a=VkNPw1HP01LnGYTKEx00:22 a=l0iWHRpgs5sLHlkKQ1IR:22 a=EAYMVhzMl8SCOHhVQcBL:22 a=M5GUcnROAAAA:8 a=GRCvF58QQ8dbGe4S3LoA:9 a=OBjm3rFKGHvpk9ecZwUJ:22 X-Proofpoint-Spam-Info: AW1haW4tMjYwNzAxMDAzMSBTYWx0ZWRfX7MVuKc4xKngm UtVe8anIElCvv1JopySn8oPiWGDUr20GKkzlpyjYhMv1c9GONvb/i6Ty7p/IpSaC6SLG2SXPYKS QjEsxp9ws1+WurZvX7QBSbNS1Zqkz9E= X-Proofpoint-GUID: C0664oKCL7hhAFZ01Q857rRZHo83T7oc X-Proofpoint-ORIG-GUID: C0664oKCL7hhAFZ01Q857rRZHo83T7oc X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzAxMDAzMSBTYWx0ZWRfX8hFXsu1TtDRP mAo/heVQ1gKGD41C2AXsU02d2bxwsxBtlfEs8QvhIvnBxaj5htqsf/tnC3Z3yAxMAYGZj4YZykJ SXRHRV/oABvPqlbj370ibCEACkJy7GmjjqJWm1oEYCXtwP66+BX+Od7UcIzZLZ0DuNf+ajd4EbN oaSBMdyhwHWfkVgIZJpayjB7OYv3j2228ItmMFKPnw1ZUkxiaKS4EokBp2HPJDgPLctDnx0tkb6 WLLI4eJbbbm6xdbYBsAkobKt3S05f+wA1Po7HY2Jk/Oe7YXruIA0oNEAHpYMJ2VfmQv+RFKlGRP YELG+65LTe+Vq8q72uSx7aYK/GmLA6ly/3w9ut012mLFZNe6iJWkhbYfDpfwqxnrmfGvM8X7Rdi iMPOOjQKL1U8y074GDVq4wTNrnBmRpxPx0VqTIOpVZ56kKUNbYNB3i8WTq/rEdOo2FPifoPAl9W mf8EUKeEkuwozwvZW6w== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-07-01_01,2026-06-26_01,2025-10-01_01 Replace MNL_TYPE_* constants with DEVLINK_VAR_ATTR_TYPE_* when handling DEVLINK_ATTR_PARAM_TYPE in param value display and set paths. The kernel uAPI now exposes these values directly via devlink_var_attr_type. Signed-off-by: Ratheesh Kannoth --- devlink/devlink.c | 34 +++++++++++++++++----------------- 1 file changed, 17 insertions(+), 17 deletions(-) diff --git a/devlink/devlink.c b/devlink/devlink.c index 434a91fe..803ea5d7 100644 --- a/devlink/devlink.c +++ b/devlink/devlink.c @@ -3526,7 +3526,7 @@ static int pr_out_param_value_print(const char *nla_name, int nla_type, print_string(PRINT_FP, NULL, " %s ", label); switch (nla_type) { - case MNL_TYPE_U8: + case DEVLINK_VAR_ATTR_TYPE_U8: if (conv_exists) { err = param_val_conv_str_get(param_val_conv, PARAM_VAL_CONV_LEN, @@ -3541,7 +3541,7 @@ static int pr_out_param_value_print(const char *nla_name, int nla_type, mnl_attr_get_u8(val_attr)); } break; - case MNL_TYPE_U16: + case DEVLINK_VAR_ATTR_TYPE_U16: if (conv_exists) { err = param_val_conv_str_get(param_val_conv, PARAM_VAL_CONV_LEN, @@ -3556,7 +3556,7 @@ static int pr_out_param_value_print(const char *nla_name, int nla_type, mnl_attr_get_u16(val_attr)); } break; - case MNL_TYPE_U32: + case DEVLINK_VAR_ATTR_TYPE_U32: if (conv_exists) { err = param_val_conv_str_get(param_val_conv, PARAM_VAL_CONV_LEN, @@ -3571,11 +3571,11 @@ static int pr_out_param_value_print(const char *nla_name, int nla_type, mnl_attr_get_u32(val_attr)); } break; - case MNL_TYPE_STRING: + case DEVLINK_VAR_ATTR_TYPE_STRING: print_string(PRINT_ANY, label, "%s", mnl_attr_get_str(val_attr)); break; - case MNL_TYPE_FLAG: + case DEVLINK_VAR_ATTR_TYPE_FLAG: if (flag_as_u8) print_bool(PRINT_ANY, label, "%s", mnl_attr_get_u8(val_attr)); @@ -3753,22 +3753,22 @@ static int cmd_dev_param_set_cb(const struct nlmsghdr *nlh, void *data) ctx->cmode_found = true; val_attr = nla_value[DEVLINK_ATTR_PARAM_VALUE_DATA]; switch (nla_type) { - case MNL_TYPE_U8: + case DEVLINK_VAR_ATTR_TYPE_U8: ctx->value.vu8 = mnl_attr_get_u8(val_attr); break; - case MNL_TYPE_U16: + case DEVLINK_VAR_ATTR_TYPE_U16: ctx->value.vu16 = mnl_attr_get_u16(val_attr); break; - case MNL_TYPE_U32: + case DEVLINK_VAR_ATTR_TYPE_U32: ctx->value.vu32 = mnl_attr_get_u32(val_attr); break; - case MNL_TYPE_U64: + case DEVLINK_VAR_ATTR_TYPE_U64: ctx->value.vu64 = mnl_attr_get_u64(val_attr); break; - case MNL_TYPE_STRING: + case DEVLINK_VAR_ATTR_TYPE_STRING: ctx->value.vstr = mnl_attr_get_str(val_attr); break; - case MNL_TYPE_FLAG: + case DEVLINK_VAR_ATTR_TYPE_FLAG: ctx->value.vbool = val_attr ? true : false; break; } @@ -3841,7 +3841,7 @@ static int cmd_dev_param_set(struct dl *dl) mnl_attr_put_u8(nlh, DEVLINK_ATTR_PARAM_TYPE, ctx.nla_type); switch (ctx.nla_type) { - case MNL_TYPE_U8: + case DEVLINK_VAR_ATTR_TYPE_U8: if (conv_exists) { err = param_val_conv_uint_get(param_val_conv, PARAM_VAL_CONV_LEN, @@ -3858,7 +3858,7 @@ static int cmd_dev_param_set(struct dl *dl) return 0; mnl_attr_put_u8(nlh, DEVLINK_ATTR_PARAM_VALUE_DATA, val_u8); break; - case MNL_TYPE_U16: + case DEVLINK_VAR_ATTR_TYPE_U16: if (conv_exists) { err = param_val_conv_uint_get(param_val_conv, PARAM_VAL_CONV_LEN, @@ -3875,7 +3875,7 @@ static int cmd_dev_param_set(struct dl *dl) return 0; mnl_attr_put_u16(nlh, DEVLINK_ATTR_PARAM_VALUE_DATA, val_u16); break; - case MNL_TYPE_U32: + case DEVLINK_VAR_ATTR_TYPE_U32: if (conv_exists) { err = param_val_conv_uint_get(param_val_conv, PARAM_VAL_CONV_LEN, @@ -3892,7 +3892,7 @@ static int cmd_dev_param_set(struct dl *dl) return 0; mnl_attr_put_u32(nlh, DEVLINK_ATTR_PARAM_VALUE_DATA, val_u32); break; - case MNL_TYPE_U64: + case DEVLINK_VAR_ATTR_TYPE_U64: if (conv_exists) err = param_val_conv_uint_get(param_val_conv, PARAM_VAL_CONV_LEN, @@ -3907,7 +3907,7 @@ static int cmd_dev_param_set(struct dl *dl) return 0; mnl_attr_put_u64(nlh, DEVLINK_ATTR_PARAM_VALUE_DATA, val_u64); break; - case MNL_TYPE_FLAG: + case DEVLINK_VAR_ATTR_TYPE_FLAG: err = str_to_bool(dl->opts.param_value, &val_bool); if (err) goto err_param_value_parse; @@ -3917,7 +3917,7 @@ static int cmd_dev_param_set(struct dl *dl) mnl_attr_put(nlh, DEVLINK_ATTR_PARAM_VALUE_DATA, 0, NULL); break; - case MNL_TYPE_STRING: + case DEVLINK_VAR_ATTR_TYPE_STRING: mnl_attr_put_strz(nlh, DEVLINK_ATTR_PARAM_VALUE_DATA, dl->opts.param_value); if (!strcmp(dl->opts.param_value, ctx.value.vstr)) -- 2.43.0