From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com [67.231.156.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 61766368D72; Wed, 1 Jul 2026 03:14:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=67.231.156.173 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782875664; cv=none; b=s+7Cz7h4iSanjEq9w50fYE+C9TgpbEyBMluMaWKKPyg1aI8lt9oOTCMNa1m32K5FkezaTvuiv6y/94nScOz7W/L9Gafm16U0Z6cqLinFwX5y1S5AFOKsiWXE0SzBstGcHTAfdi4FsiXCYCGi5bHusqSpOavzZAAnMRdZoLaTJPM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782875664; c=relaxed/simple; bh=a+nedxxNnu7GxfHRXngUuSdz8TW77MkWJTEkwFgF/Uk=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=tzjkLqeb+y5pVvVYRyeNK/w1AHeh0D9Y5tVajjy8k7rIU/1uCL8zp+f2XTRcsCjC6E5kFJZZIrsb5nULJySVPXnJkEqdw4dBy5Fkxti2my+ThNlvdfvcmOdGrwFrP9S0foPe5B7HxAjBmKlyp/HvsM5x2bFXUX9qpxEjtzgmHsg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=marvell.com; spf=pass smtp.mailfrom=marvell.com; dkim=pass (2048-bit key) header.d=marvell.com header.i=@marvell.com header.b=TzKjfVaS; arc=none smtp.client-ip=67.231.156.173 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=marvell.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=marvell.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=marvell.com header.i=@marvell.com header.b="TzKjfVaS" Received: from pps.filterd (m0045851.ppops.net [127.0.0.1]) by mx0b-0016f401.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 6612vch22243937; Tue, 30 Jun 2026 20:14:15 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=pfpt0220; bh=x nASGrXjHeTpKVyVsPbK24wYI6v0F8Oz/4jhJPZUmOI=; b=TzKjfVaS68ay8fbQ0 CMwMfQwpFduo4YWZ0RqmYd1mDL63OFAt2rp2RDPtsM1Fc5Jzl7Gs9YgkEn0rpMVl q8t3Mob6bJFDiBMtQhAeepk+SeuqtJSWdtvEUe0ScuzORwxn2CriCq2pH/cuzujT q0UHR1zL7ZviKklYFJnS+4ZTc3ElxIBqR/ESVMziTgzblyANgBBX7Elx5sSBOB/d L/Xyz3VnW3PRQPHVGBRcdgO0+HfVLHqnjjhuTBzx0ROm0z5RLUFj84MZWIsWnI+n HYL2hV8Zg9Tie9vE5l3CVJijr3BwvN6XSv2DvkET2NMvhEKOA/EguH0TocoY3cDr RF4mg== Received: from dc6wp-exch02.marvell.com ([4.21.29.225]) by mx0b-0016f401.pphosted.com (PPS) with ESMTPS id 4f2e1hcjxh-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 30 Jun 2026 20:14:14 -0700 (PDT) Received: from DC6WP-EXCH02.marvell.com (10.76.176.209) by DC6WP-EXCH02.marvell.com (10.76.176.209) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.25; Tue, 30 Jun 2026 20:14:14 -0700 Received: from maili.marvell.com (10.69.176.80) by DC6WP-EXCH02.marvell.com (10.76.176.209) with Microsoft SMTP Server id 15.2.1544.25 via Frontend Transport; Tue, 30 Jun 2026 20:14:14 -0700 Received: from rkannoth-OptiPlex-7090.. (unknown [10.28.36.165]) by maili.marvell.com (Postfix) with ESMTP id DFFDB3F7059; Tue, 30 Jun 2026 20:14:10 -0700 (PDT) From: Ratheesh Kannoth To: , , , , CC: , , , , Subject: [PATCH iproute2-next v3 2/2] devlink: support u64-array values in devlink param show/set Date: Wed, 1 Jul 2026 08:43:59 +0530 Message-ID: <20260701031359.839221-3-rkannoth@marvell.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260701031359.839221-1-rkannoth@marvell.com> References: <20260701031359.839221-1-rkannoth@marvell.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Proofpoint-ORIG-GUID: Z7L3exMwfeadsBudE7P4MfUAyqXofxmB X-Proofpoint-Spam-Info: AW1haW4tMjYwNzAxMDAzMSBTYWx0ZWRfX63IQldMyVQ30 AVwc7ptEHtHi4zOGvn9bQja9k5oD7bw8C15TmKFDQZe77VlQvXTpXs7IyIezqUW2+ecnUi26loW pthUdhIPXfh/NOHgxqsVSY9/EyvGDz0= X-Authority-Analysis: v=2.4 cv=e802j6p/ c=1 sm=1 tr=0 ts=6a448606 cx=c_pps a=gIfcoYsirJbf48DBMSPrZA==:117 a=gIfcoYsirJbf48DBMSPrZA==:17 a=FelO9ux0wxsA:10 a=VkNPw1HP01LnGYTKEx00:22 a=l0iWHRpgs5sLHlkKQ1IR:22 a=QXcCYyLzdtTjyudCfB6f:22 a=M5GUcnROAAAA:8 a=EA5XVCQfNfiMJzDliX8A:9 a=OBjm3rFKGHvpk9ecZwUJ:22 X-Proofpoint-GUID: Z7L3exMwfeadsBudE7P4MfUAyqXofxmB X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzAxMDAzMSBTYWx0ZWRfXwpROk/7ZE9W2 jhmM7dc0oOBO0kW4ayaGEdzryp0WhT4l+WrZ6NnV1JVHoNhf4Kfp76H2dtoUeaITAQlUsYqlbCa 1LhrRLGO3Ws6u0hDU1t1oUNvYStpGNhj7dBrAdMVjrMX8fbDCws4PQ4cYGnEUuZzMDzQYJHNBOH LmhkiJhpud1t7+1LQVlkyvguzT6SpB+sx5kjLimjcjlNVpaWw3/PdmI2P8MOQBGfTPTQCwMKSGR LCSKTEp8wnQw8S99c1GPaiujNc0dXnxLl/evYUaWRh051GFKVe0MYZ5h6HbR7UIOPf8w/vpsSnL 8ydHQni4PR4+mZPHzv0rSC5UdUpCd55t03HXyzdc+NQL8ck/9amiBE9jDXnVScUV0asBvAeK72A lsco/LTrYvLLNEUyZf8C47l8qUFtcuztTQbCdQb6O59y/lWaTZuuJcI64PvHTmPU6J/QRc9P95X WTdWPi7/F46L2nj7ygQ== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-07-01_01,2026-06-26_01,2025-10-01_01 Add support for DEVLINK_VAR_ATTR_TYPE_U64_ARRAY parameters that carry multiple DEVLINK_ATTR_PARAM_VALUE_DATA attributes. Parse and display u64 array values in param show, and accept space- or comma-separated u64 values in devlink and port param set commands. - Show search order devlink dev param show pci/0002:01:00.0 name npc_srch_order pci/0002:01:00.0: name npc_srch_order type driver-specific values: cmode runtime value value 0 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 - Set search order devlink dev param set pci/0002:01:00.0 name npc_srch_order value 31,0,1,2,3,4,5,6,7,8,9,10,11,12,13,14,15,16,17,18,19,20,21,\ 22,23,24,25,26,27,28,29,30 cmode runtime Signed-off-by: Ratheesh Kannoth --- devlink/devlink.c | 157 ++++++++++++++++++++++++++++++++++++++++++++-- 1 file changed, 153 insertions(+), 4 deletions(-) diff --git a/devlink/devlink.c b/devlink/devlink.c index 803ea5d7..c6566937 100644 --- a/devlink/devlink.c +++ b/devlink/devlink.c @@ -3515,13 +3515,116 @@ static const struct param_val_conv param_val_conv[] = { }; #define PARAM_VAL_CONV_LEN ARRAY_SIZE(param_val_conv) +#define DEVLINK_PARAM_MAX_ARRAY_SIZE 32 + +struct devlink_param_u64_array { + uint64_t size; + uint64_t val[DEVLINK_PARAM_MAX_ARRAY_SIZE]; +}; + +static int param_value_nested_u64_attr_cb(const struct nlattr *attr, void *data) +{ + struct devlink_param_u64_array *arr = data; + unsigned int len; + + if (mnl_attr_get_type(attr) != DEVLINK_ATTR_PARAM_VALUE_DATA) + return MNL_CB_OK; + + if (arr->size >= DEVLINK_PARAM_MAX_ARRAY_SIZE) + return MNL_CB_ERROR; + + len = mnl_attr_get_payload_len(attr); + if (len == sizeof(uint32_t)) + arr->val[arr->size++] = mnl_attr_get_u32(attr); + else if (len == sizeof(uint64_t)) + arr->val[arr->size++] = mnl_attr_get_u64(attr); + else + return MNL_CB_ERROR; + + return MNL_CB_OK; +} + +static int param_value_u64_array_fill(struct nlattr *nl, + struct devlink_param_u64_array *arr) +{ + int err; + + arr->size = 0; + err = mnl_attr_parse_nested(nl, param_value_nested_u64_attr_cb, arr); + if (err != MNL_CB_OK) + return -EINVAL; + + return 0; +} + +static bool param_value_u64_array_equal(const struct devlink_param_u64_array *a, + const struct devlink_param_u64_array *b) +{ + uint64_t i; + + if (a->size != b->size) + return false; + + for (i = 0; i < a->size; i++) { + if (a->val[i] != b->val[i]) + return false; + } + + return true; +} + +static int param_value_u64_array_put_from_str(struct nlmsghdr *nlh, + const char *param_value, + const struct devlink_param_u64_array *cur) +{ + struct devlink_param_u64_array new_arr = {}; + char *copy, *token, *saveptr = NULL; + char delim[] = " ,"; + uint64_t val; + int err, i; + + copy = strdup(param_value); + if (!copy) + return -ENOMEM; + + token = strtok_r(copy, delim, &saveptr); + while (token) { + if (new_arr.size >= DEVLINK_PARAM_MAX_ARRAY_SIZE) { + free(copy); + pr_err("Too many array elements (max %d)\n", + DEVLINK_PARAM_MAX_ARRAY_SIZE); + return -EINVAL; + } + err = get_u64((__u64 *)&val, token, 10); + if (err) { + free(copy); + pr_err("Value \"%s\" is not a number or not within range\n", + token); + return err; + } + new_arr.val[new_arr.size++] = val; + token = strtok_r(NULL, delim, &saveptr); + } + free(copy); + + /* Check current and new values. If both are equal, bail out */ + if (cur && param_value_u64_array_equal(&new_arr, cur)) + return 1; + + for (i = 0; i < new_arr.size; i++) + mnl_attr_put_u64(nlh, DEVLINK_ATTR_PARAM_VALUE_DATA, new_arr.val[i]); + + return 0; +} static int pr_out_param_value_print(const char *nla_name, int nla_type, struct nlattr *val_attr, bool conv_exists, - const char *label, bool flag_as_u8) + const char *label, bool flag_as_u8, struct nlattr *nl) { + struct devlink_param_u64_array u64_arr = { }; const char *vstr; - int err; + char buffer[1024]; + int err, cnt = 0; print_string(PRINT_FP, NULL, " %s ", label); @@ -3582,6 +3685,20 @@ static int pr_out_param_value_print(const char *nla_name, int nla_type, else print_bool(PRINT_ANY, label, "%s", val_attr); break; + case DEVLINK_VAR_ATTR_TYPE_U64_ARRAY: + err = param_value_u64_array_fill(flag_as_u8 ? val_attr : nl, &u64_arr); + if (err) + return err; + + for (uint64_t i = 0; i < u64_arr.size; i++) { + if (i) + cnt += snprintf(buffer + cnt, sizeof(buffer) - cnt, " "); + cnt += snprintf(buffer + cnt, sizeof(buffer) - cnt, + "%" PRIu64, u64_arr.val[i]); + } + + print_string(PRINT_ANY, label, "%s", buffer); + break; } return 0; @@ -3601,6 +3718,7 @@ static void pr_out_param_value(struct dl *dl, const char *nla_name, if (!nla_value[DEVLINK_ATTR_PARAM_VALUE_CMODE] || (nla_type != MNL_TYPE_FLAG && + nla_type != DEVLINK_VAR_ATTR_TYPE_U64_ARRAY && !nla_value[DEVLINK_ATTR_PARAM_VALUE_DATA])) return; @@ -3614,14 +3732,14 @@ static void pr_out_param_value(struct dl *dl, const char *nla_name, nla_name); err = pr_out_param_value_print(nla_name, nla_type, val_attr, - conv_exists, "value", false); + conv_exists, "value", false, nl); if (err) return; val_attr = nla_value[DEVLINK_ATTR_PARAM_VALUE_DEFAULT]; if (val_attr) { err = pr_out_param_value_print(nla_name, nla_type, val_attr, - conv_exists, "default", true); + conv_exists, "default", true, nl); if (err) return; } @@ -3704,6 +3822,7 @@ struct param_ctx { uint64_t vu64; const char *vstr; bool vbool; + struct devlink_param_u64_array u64arr; } value; }; @@ -3745,6 +3864,7 @@ static int cmd_dev_param_set_cb(const struct nlmsghdr *nlh, void *data) if (!nla_value[DEVLINK_ATTR_PARAM_VALUE_CMODE] || (nla_type != MNL_TYPE_FLAG && + nla_type != DEVLINK_VAR_ATTR_TYPE_U64_ARRAY && !nla_value[DEVLINK_ATTR_PARAM_VALUE_DATA])) return MNL_CB_ERROR; @@ -3771,6 +3891,12 @@ static int cmd_dev_param_set_cb(const struct nlmsghdr *nlh, void *data) case DEVLINK_VAR_ATTR_TYPE_FLAG: ctx->value.vbool = val_attr ? true : false; break; + case DEVLINK_VAR_ATTR_TYPE_U64_ARRAY: + err = param_value_u64_array_fill(param_value_attr, + &ctx->value.u64arr); + if (err) + return MNL_CB_ERROR; + break; } break; } @@ -3923,6 +4049,14 @@ static int cmd_dev_param_set(struct dl *dl) if (!strcmp(dl->opts.param_value, ctx.value.vstr)) return 0; break; + case DEVLINK_VAR_ATTR_TYPE_U64_ARRAY: + err = param_value_u64_array_put_from_str(nlh, dl->opts.param_value, + &ctx.value.u64arr); + if (err == 1) + return 0; + if (err) + return err; + break; default: printf("Value type not supported\n"); return -ENOTSUP; @@ -5369,6 +5503,7 @@ static int cmd_port_param_set_cb(const struct nlmsghdr *nlh, void *data) if (!nla_value[DEVLINK_ATTR_PARAM_VALUE_CMODE] || (nla_type != MNL_TYPE_FLAG && + nla_type != DEVLINK_VAR_ATTR_TYPE_U64_ARRAY && !nla_value[DEVLINK_ATTR_PARAM_VALUE_DATA])) return MNL_CB_ERROR; @@ -5391,6 +5526,12 @@ static int cmd_port_param_set_cb(const struct nlmsghdr *nlh, void *data) case MNL_TYPE_FLAG: ctx->value.vbool = val_attr ? true : false; break; + case DEVLINK_VAR_ATTR_TYPE_U64_ARRAY: + err = param_value_u64_array_fill(param_value_attr, + &ctx->value.u64arr); + if (err) + return MNL_CB_ERROR; + break; } break; } @@ -5519,6 +5660,14 @@ static int cmd_port_param_set(struct dl *dl) if (!strcmp(dl->opts.param_value, ctx.value.vstr)) return 0; break; + case DEVLINK_VAR_ATTR_TYPE_U64_ARRAY: + err = param_value_u64_array_put_from_str(nlh, dl->opts.param_value, + &ctx.value.u64arr); + if (err == 1) + return 0; + if (err) + return err; + break; default: printf("Value type not supported\n"); return -ENOTSUP; -- 2.43.0