From: Lee Jones <lee@kernel.org>
To: Rong Zhang <i@rong.moe>
Cc: "Pavel Machek" <pavel@kernel.org>,
"Jonathan Corbet" <corbet@lwn.net>,
"Shuah Khan" <skhan@linuxfoundation.org>,
"Thomas Weißschuh" <linux@weissschuh.net>,
"Benson Leung" <bleung@chromium.org>,
"Guenter Roeck" <groeck@chromium.org>,
"Marek Behún" <kabel@kernel.org>,
"Mark Pearson" <mpearson-lenovo@squebb.ca>,
"Derek J. Clark" <derekjohn.clark@gmail.com>,
"Hans de Goede" <hansg@kernel.org>,
"Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>,
"Ike Panhc" <ikepanhc@gmail.com>,
"Andrew Lunn" <andrew+netdev@lunn.ch>,
"Jakub Kicinski" <kuba@kernel.org>,
"Vishnu Sankar" <vishnuocv@gmail.com>,
"Vishnu Sankar" <vsankar@lenovo.com>,
linux-leds@vger.kernel.org, netdev@vger.kernel.org,
linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
chrome-platform@lists.linux.dev,
platform-driver-x86@vger.kernel.org
Subject: Re: [PATCH RFC v2 0/9] leds: Add support for hardware-initiated hardware control trigger transition
Date: Thu, 2 Jul 2026 14:41:30 +0100 [thread overview]
Message-ID: <20260702134130.GN2108533@google.com> (raw)
In-Reply-To: <20260618-leds-trigger-hw-changed-v2-0-c28c44053cf3@rong.moe>
On Thu, 18 Jun 2026, Rong Zhang wrote:
> Some laptops can tune their keyboard backlight according to ambient
> light sensors (auto mode). This capability is essentially a hardware
> control trigger. Meanwhile, such laptops also offer a shrotcut for
> cycling through brightness levels and auto mode. For example, on
> ThinkBook, pressing Fn+Space cycles keyboard backlight levels in the
> following sequence:
So we're effectively lifting something out of netdev and making it more
generic. I don't generally have an issue with this, but the idea will
need more eyes on before I feel confident enough to review (for my
own little quirks) and merge it.
--
Lee Jones
prev parent reply other threads:[~2026-07-02 13:41 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-17 16:47 [PATCH RFC v2 0/9] leds: Add support for hardware-initiated hardware control trigger transition Rong Zhang
2026-06-17 16:47 ` [PATCH RFC v2 1/9] leds: Add callback offloaded() to query the state of hardware control trigger Rong Zhang
2026-06-17 16:47 ` [PATCH RFC v2 2/9] leds: cros_ec: Implement offloaded() callback for trigger Rong Zhang
2026-06-17 16:47 ` [PATCH RFC v2 3/9] leds: turris-omnia: " Rong Zhang
2026-06-17 16:47 ` [PATCH RFC v2 4/9] leds: trigger: netdev: Implement offloaded() callback Rong Zhang
2026-06-17 16:47 ` [PATCH RFC v2 5/9] leds: Add trigger_may_offload attribute Rong Zhang
2026-06-17 16:48 ` [PATCH RFC v2 6/9] leds: trigger: Add led_trigger_notify_hw_control_changed() interface Rong Zhang
2026-06-17 16:48 ` [PATCH RFC v2 7/9] platform/x86: ideapad-laptop: Decouple hardware & classdev brightness for keyboard backlight Rong Zhang
2026-06-17 16:48 ` [PATCH RFC v2 8/9] platform/x86: ideapad-laptop: Serialize keyboard backlight notifications Rong Zhang
2026-06-17 16:48 ` [PATCH RFC v2 9/9] platform/x86: ideapad-laptop: Fully support auto keyboard backlight Rong Zhang
2026-07-02 13:41 ` Lee Jones [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260702134130.GN2108533@google.com \
--to=lee@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=bleung@chromium.org \
--cc=chrome-platform@lists.linux.dev \
--cc=corbet@lwn.net \
--cc=derekjohn.clark@gmail.com \
--cc=groeck@chromium.org \
--cc=hansg@kernel.org \
--cc=i@rong.moe \
--cc=ikepanhc@gmail.com \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=kabel@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=linux@weissschuh.net \
--cc=mpearson-lenovo@squebb.ca \
--cc=netdev@vger.kernel.org \
--cc=pavel@kernel.org \
--cc=platform-driver-x86@vger.kernel.org \
--cc=skhan@linuxfoundation.org \
--cc=vishnuocv@gmail.com \
--cc=vsankar@lenovo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox