On Wed, Jul 01, 2026 at 05:59:05PM +0200, Théo Lebrun wrote: > Here are all device pointer variable permutations inside MACB: > > struct device *dev; > struct net_device *dev; > struct net_device *ndev; > struct net_device *netdev; > struct pci_dev *pdev; // inside macb_pci.c > struct phy_device *phy; > struct phy_device *phydev; > struct platform_device *pdev; > struct platform_device *plat_dev; // inside macb_pci.c > > Unify to this convention: > > struct device *dev; > struct net_device *netdev; > struct pci_dev *pci; > struct phy_device *phydev; > struct platform_device *pdev; Oh lovely, OCD approved. Reviewed-by: Conor Dooley