From: Pengpeng Hou <pengpeng@iscas.ac.cn>
To: Chas Williams <3chas3@gmail.com>,
linux-atm-general@lists.sourceforge.net, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Cc: Pengpeng Hou <pengpeng@iscas.ac.cn>
Subject: [PATCH] atm: solos-pci: validate DMA receive size
Date: Sun, 5 Jul 2026 16:45:04 +0800 [thread overview]
Message-ID: <20260705084504.54281-1-pengpeng@iscas.ac.cn> (raw)
The DMA receive path reads header->size from the RX buffer and uses it
to extend the skb with skb_put(skb, size + sizeof(*header)). RX DMA skbs
are allocated with RX_DMA_SIZE bytes, but the DMA path did not check
that the device-provided size fits in that buffer. The MMIO path already
has a similar size check against card->buffer_size.
Reject an oversized DMA receive item before skb_put() and drop the
invalid skb, then continue through the normal DMA RX refill path so the
port is not left without a replacement receive buffer.
Signed-off-by: Pengpeng Hou <pengpeng@iscas.ac.cn>
---
diff --git a/drivers/atm/solos-pci.c b/drivers/atm/solos-pci.c
--- a/drivers/atm/solos-pci.c
+++ b/drivers/atm/solos-pci.c
@@ -784,6 +784,12 @@
header = (void *)skb->data;
size = le16_to_cpu(header->size);
+ if (size > RX_DMA_SIZE - sizeof(*header)) {
+ dev_warn(&card->dev->dev, "Invalid DMA buffer size\n");
+ dev_kfree_skb_any(skb);
+ goto refill_rx;
+ }
+
skb_put(skb, size + sizeof(*header));
skb_pull(skb, sizeof(*header));
} else {
@@ -865,6 +871,7 @@
break;
}
}
+refill_rx:
/* Allocate RX skbs for any ports which need them */
if (card->using_dma && card->atmdev[port] &&
!card->rx_skb[port]) {
next reply other threads:[~2026-07-05 8:45 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-05 8:45 Pengpeng Hou [this message]
2026-07-06 15:14 ` [PATCH] atm: solos-pci: validate DMA receive size Andrew Lunn
2026-07-07 1:45 ` Pengpeng Hou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260705084504.54281-1-pengpeng@iscas.ac.cn \
--to=pengpeng@iscas.ac.cn \
--cc=3chas3@gmail.com \
--cc=linux-atm-general@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox