From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from fhigh-a1-smtp.messagingengine.com (fhigh-a1-smtp.messagingengine.com [103.168.172.152]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B99C8436BDA for ; Mon, 6 Jul 2026 18:20:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=103.168.172.152 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783362054; cv=none; b=deABTst701tZcca5wuQLlYTOKLnJw79YxeX2v57a4Opv7vLtvGjSInKS5xm19t3xnmp3XQSVBaRrWts0PiNdhSLQwmZd4CA5EcmM/CBpEo/LygVnLHi04v405nFvS43z3ME2hNL+4YYEMDwIYz7J8tuEfh8fGD2KQ0JPzoEb0p0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783362054; c=relaxed/simple; bh=BpMU/KQZxIQhJJ019dQAS3ORZw04v9Z1KJIt1fkVI2U=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=OWFe6wWvGFC+TUvDe+nBKs7BTkH85jvON/gZaRs+A1iSdeOtuXmBu4gAXWpa8ivIu2Sk8j0ah2vwMeH8UOTFz16MYkHzYcwovWrm6wE39uPJZxbAIdxIojx/T3UK5OWWltxgXuMF4qF5Vy2gOi+VZhzG9/dZFnle80Y/Z2zXQCo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=fastmail.im; spf=pass smtp.mailfrom=fastmail.im; dkim=pass (2048-bit key) header.d=fastmail.im header.i=@fastmail.im header.b=HMEMPuZd; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b=VOi10Mt5; arc=none smtp.client-ip=103.168.172.152 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=fastmail.im Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=fastmail.im Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=fastmail.im header.i=@fastmail.im header.b="HMEMPuZd"; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="VOi10Mt5" Received: from phl-compute-08.internal (phl-compute-08.internal [10.202.2.48]) by mailfhigh.phl.internal (Postfix) with ESMTP id EDA2F1400114; Mon, 6 Jul 2026 14:20:51 -0400 (EDT) Received: from phl-frontend-04 ([10.202.2.163]) by phl-compute-08.internal (MEProxy); Mon, 06 Jul 2026 14:20:51 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fastmail.im; h= cc:cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:subject:subject:to:to; s=fm2; t=1783362051; x= 1783448451; bh=iezIZhXVpeSc8eAq7auxerJW6WGW3QxsYHckVvIqEJ8=; b=H MEMPuZdFgUFRN0TAlBs5TngMYyHlRTCzsCgxejzEeqGpwZcYCiBrEmLeLGBXS1K1 ImO4E1kvfQOJjRF+fDrY9yiXL817obo0boPtYqKfrQehjlA0oNwnDgNZ2ipVwMKv j3STAUbY/CA932uEISsn2Jpcto5qv8pCKvJdJkIzOcfFDnxrBy93VvqCfRj+zHv0 7V/wMH2Ect4+1Nj/goTBfHqZc7yi7pKOALloy+EBj3IdYaCc9G9iSnP/t7SVrSJ8 b1DcBT2ErN7H1ZryMW7HqorDX11KsRMuDrFsYv96D27eqkfA5R2PQTqCYY4ZyuU5 PChL0P7X3TelH0wGtl8ew== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:subject:subject:to:to:x-me-proxy:x-me-sender :x-me-sender:x-sasl-enc; s=fm2; t=1783362051; x=1783448451; bh=i ezIZhXVpeSc8eAq7auxerJW6WGW3QxsYHckVvIqEJ8=; b=VOi10Mt5RrmBPS6ox 2ePW1m20ZpZ6632DkEpGxo8sXiq6MNgzh7dlmGG+X7cFIZStP1Eq3d9fImGbQEtS f02kp/ziAEKjBmFkdkW65KWnbFA5DCzAQih0ArPi5RsPnonSE5uMK0KTMQ2r/c7f yDLccGzM27zbdK+B6mYon19BKn1RMXlUFjshr93In1JwXLlXLIg8XLZYI8NyckCI pI6W7v/rq2NgFiJX3gaAouQX/XCvXud1lXOtX3Oul5ZrDuxzV8IT6JJNR3s0CZ3g WlnNxo3PB+9C/mlVVsqnm10iVQ5XRw81ixWh44Okbmz4D5GZiJeRdz5V1bjYCq+U w7d8Q== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: dmFkZTEGTPv5OkKcjprW8/I9eo6u4pwgzYOjg6KFhqQqPhEcE15CLvyHfw+KtOGuruiqIO RNBEfkqjE6n9+N680knhEUuD69YEJHEnuIz9rN1Z3nsMpcwWxLrhFq8Y3mO7NKw8IU0Xda 6lObyyPoWVV45JHUZI+DXDDPStMSyKm6G7gmBL/I49XwlNAfrDK9JFzvXaGy1kqeYjVqcI 7dmMZaut61MQOINjUZvHvPGjhzlZQt1yHbk9JExXHi4aAGmELWRRwleBjY7O4shNeF472R iV0vQw/w1/u72oscJfGNj5WiGzXLuavT9H5l8k5y2FM5sILMEpSAYwjnjAGUg6Papuu7Qu gVST0p/505JW3VYbFF8kgszCI7KPobOKXlZoZ5oEnAmQsScQF2EQcee/9RfAI+RovL5hAI UsBv98sIUn638+ow8es2MSL02AbPCsMDL4FmtY05zIyLMYVz/bze3/8sb5br1E1VbGm4rU QNlDirgNgDewi2dOsPI+nIOPIV1gE0VVOVwE0n+4z/rzGW3vOpRrhm7DJBbfITlC/9hspC mX3fZtEsb78OWIfuYad79IQoYZ7qBosaGIOcEZwxDY/gkHlEQfRo9l19RCGlDbsWFURL1X RwJXG5llta8aa47qMND0zIQx3jZclkt/WjCIHDqYusjOYMOGkG8rPMPBMyaA X-ME-Proxy: Feedback-ID: i559e4809:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 6 Jul 2026 14:20:50 -0400 (EDT) From: Alice Mikityanska To: Daniel Borkmann , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Xin Long , Willem de Bruijn , Willem de Bruijn , David Ahern , Nikolay Aleksandrov Cc: Shuah Khan , Stanislav Fomichev , Andrew Lunn , Simon Horman , Florian Westphal , netdev@vger.kernel.org, Alice Mikityanska Subject: [PATCH net-next v8 3/9] udp: Support BIG TCP GSO packets where they can occur Date: Mon, 6 Jul 2026 21:19:35 +0300 Message-ID: <20260706181941.385672-4-alice.kernel@fastmail.im> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260706181941.385672-1-alice.kernel@fastmail.im> References: <20260706181941.385672-1-alice.kernel@fastmail.im> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Alice Mikityanska Wherever a GSO packet can occur, and its length is used to fill the UDP header, use udp_set_len that assigns 0 if the length doesn't fit 16 bits, so that the packet can be properly parsed and segmented later, instead of having truncated length. Use udp_get_len in udp_validate_len to treat BIG TCP packets as valid. Signed-off-by: Alice Mikityanska Reviewed-by: Willem de Bruijn --- net/ipv4/fou_core.c | 2 +- net/ipv6/fou6.c | 2 +- net/netfilter/ipvs/ip_vs_xmit.c | 2 +- net/netfilter/nf_conntrack_proto_udp.c | 2 +- net/psp/psp_main.c | 2 +- 5 files changed, 5 insertions(+), 5 deletions(-) diff --git a/net/ipv4/fou_core.c b/net/ipv4/fou_core.c index a50740d0f288..aef3ce1dec7a 100644 --- a/net/ipv4/fou_core.c +++ b/net/ipv4/fou_core.c @@ -1040,7 +1040,7 @@ static void fou_build_udp(struct sk_buff *skb, struct ip_tunnel_encap *e, uh->dest = e->dport; uh->source = sport; - udp_set_len_short(uh, skb->len); + udp_set_len(uh, skb->len); udp_set_csum(!(e->flags & TUNNEL_ENCAP_FLAG_CSUM), skb, fl4->saddr, fl4->daddr, skb->len); diff --git a/net/ipv6/fou6.c b/net/ipv6/fou6.c index 588929409241..4b659ca60ba9 100644 --- a/net/ipv6/fou6.c +++ b/net/ipv6/fou6.c @@ -30,7 +30,7 @@ static void fou6_build_udp(struct sk_buff *skb, struct ip_tunnel_encap *e, uh->dest = e->dport; uh->source = sport; - udp_set_len_short(uh, skb->len); + udp_set_len(uh, skb->len); udp6_set_csum(!(e->flags & TUNNEL_ENCAP_FLAG_CSUM6), skb, &fl6->saddr, &fl6->daddr, skb->len); diff --git a/net/netfilter/ipvs/ip_vs_xmit.c b/net/netfilter/ipvs/ip_vs_xmit.c index ae3ed2c00ec3..c51ebd83a476 100644 --- a/net/netfilter/ipvs/ip_vs_xmit.c +++ b/net/netfilter/ipvs/ip_vs_xmit.c @@ -1100,7 +1100,7 @@ ipvs_gue_encap(struct net *net, struct sk_buff *skb, dport = cp->dest->tun_port; udph->dest = dport; udph->source = sport; - udp_set_len_short(udph, skb->len); + udp_set_len(udph, skb->len); udph->check = 0; *next_protocol = IPPROTO_UDP; diff --git a/net/netfilter/nf_conntrack_proto_udp.c b/net/netfilter/nf_conntrack_proto_udp.c index 8a5675983e7c..a7edfefd6fd1 100644 --- a/net/netfilter/nf_conntrack_proto_udp.c +++ b/net/netfilter/nf_conntrack_proto_udp.c @@ -45,7 +45,7 @@ static bool udp_validate_len(struct sk_buff *skb, const struct udphdr *hdr, unsigned int dataoff) { - unsigned int udplen = udp_get_len_short(hdr); + unsigned int udplen = udp_get_len(skb, hdr, dataoff); unsigned int skblen = skb->len - dataoff; if (udplen > skblen || udplen < sizeof(*hdr)) diff --git a/net/psp/psp_main.c b/net/psp/psp_main.c index 90c7dc4e76a1..c9c1a8826b7f 100644 --- a/net/psp/psp_main.c +++ b/net/psp/psp_main.c @@ -231,7 +231,7 @@ static void psp_write_headers(struct net *net, struct sk_buff *skb, __be32 spi, uh->source = udp_flow_src_port(net, skb, 0, 0, false); } uh->check = 0; - udp_set_len_short(uh, udp_len); + udp_set_len(uh, udp_len); psph->nexthdr = IPPROTO_TCP; psph->hdrlen = PSP_HDRLEN_NOOPT; -- 2.54.0