From: Daniel Borkmann <daniel@iogearbox.net>
To: kuba@kernel.org
Cc: pabeni@redhat.com, jhs@mojatatu.com, bigeasy@linutronix.de,
andrii@kernel.org, memxor@gmail.com, bpf@vger.kernel.org,
netdev@vger.kernel.org
Subject: [PATCH net v2 0/3] Fix broken TC_ACT_REDIRECT from qdiscs
Date: Mon, 6 Jul 2026 20:56:06 +0200 [thread overview]
Message-ID: <20260706185609.330006-1-daniel@iogearbox.net> (raw)
This is an alternative fix to [0] in order to not uglify
__dev_queue_xmit() with sprinkled ifdefs given this can be
simplified and isolated through a simple test into the BPF
redirect helper itself.
I've also added a proper BPF selftest, so there is no need
to check-in a binary BPF object into selftests given we do
have BPF infra for all of this.
[0] https://lore.kernel.org/netdev/20260629102157.737306-1-jhs@mojatatu.com/
[1] https://lore.kernel.org/netdev/20260629102157.737306-4-jhs@mojatatu.com/
v1 -> v2:
- Added Sebastian's Reviewed-by
- Rebase to latest net, rest is same (Paolo)
Daniel Borkmann (2):
bpf: Reject redirect helpers without a bpf_net_context
selftests/bpf: Add test for redirect from qdisc qevent block
Jamal Hadi Salim (1):
net/sched: Handle TC_ACT_REDIRECT from qdisc filter chains
include/net/pkt_cls.h | 14 ++-
net/core/filter.c | 17 ++-
net/sched/cls_api.c | 6 +-
net/sched/sch_cake.c | 2 +-
net/sched/sch_drr.c | 2 +-
net/sched/sch_dualpi2.c | 2 +-
net/sched/sch_ets.c | 2 +-
net/sched/sch_fq_codel.c | 2 +-
net/sched/sch_fq_pie.c | 2 +-
net/sched/sch_hfsc.c | 2 +-
net/sched/sch_htb.c | 2 +-
net/sched/sch_multiq.c | 2 +-
net/sched/sch_prio.c | 2 +-
net/sched/sch_qfq.c | 2 +-
net/sched/sch_sfb.c | 2 +-
net/sched/sch_sfq.c | 2 +-
tools/testing/selftests/bpf/config | 1 +
.../selftests/bpf/prog_tests/tc_qevent.c | 113 ++++++++++++++++++
.../selftests/bpf/progs/test_tc_qevent.c | 23 ++++
19 files changed, 175 insertions(+), 25 deletions(-)
create mode 100644 tools/testing/selftests/bpf/prog_tests/tc_qevent.c
create mode 100644 tools/testing/selftests/bpf/progs/test_tc_qevent.c
--
2.43.0
next reply other threads:[~2026-07-06 18:56 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-06 18:56 Daniel Borkmann [this message]
2026-07-06 18:56 ` [PATCH net v2 1/3] bpf: Reject redirect helpers without a bpf_net_context Daniel Borkmann
2026-07-06 18:56 ` [PATCH net v2 2/3] net/sched: Handle TC_ACT_REDIRECT from qdisc filter chains Daniel Borkmann
2026-07-06 18:56 ` [PATCH net v2 3/3] selftests/bpf: Add test for redirect from qdisc qevent block Daniel Borkmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260706185609.330006-1-daniel@iogearbox.net \
--to=daniel@iogearbox.net \
--cc=andrii@kernel.org \
--cc=bigeasy@linutronix.de \
--cc=bpf@vger.kernel.org \
--cc=jhs@mojatatu.com \
--cc=kuba@kernel.org \
--cc=memxor@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox