From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qt1-f202.google.com (mail-qt1-f202.google.com [209.85.160.202]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A066131D381 for ; Tue, 7 Jul 2026 08:23:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.202 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783412612; cv=none; b=HkSBBJM7ng8bN1wf5BJXj+phFIpk0skUzmxFXLsUmuyobNNAuvswx5VjlaOecdZ3lvL1ed5YS30cAVuhMditgg+qOm/rOb9MmaOj3Aqs3OVNuEwlsMTvd8xwbM3TPSLVszo1qA7+CdBJmogZUo/VCLElbNLnFUmkQ9l0T2eaESo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783412612; c=relaxed/simple; bh=HQgdLCdm7zLQxOAeI2KzFpaJMzKhabZvUHvnPoqlDsQ=; h=Date:Mime-Version:Message-ID:Subject:From:To:Cc:Content-Type; b=prm4k4gy8j8WuQ40ZXJskt9iRBKBKWzmCgEx9PN5hmUxfM1TPDUnBbnDR9O+Sz8vX61I77cxcqYr4WNFwLBtRNeIsNIjtUqWfi1SKo4PJPvWrBn41kwHSusXS5vFpLL93IHMgSWpec0zD2YeZkgLWdtyBXXhRrUJJH0d14Rgetw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--edumazet.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=SsqbQ9eH; arc=none smtp.client-ip=209.85.160.202 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--edumazet.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="SsqbQ9eH" Received: by mail-qt1-f202.google.com with SMTP id d75a77b69052e-51c26012cd0so49568781cf.0 for ; Tue, 07 Jul 2026 01:23:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1783412608; x=1784017408; darn=vger.kernel.org; h=cc:to:from:subject:message-id:mime-version:date:from:to:cc:subject :date:message-id:reply-to; bh=edpuzPNlqLkIiVe8hDiwbrsEC4+WRFM9TrLPB0rzqfk=; b=SsqbQ9eHwzvMYS2C+i9GPhTCrihTNCLR1sGL4pn+9VnwwaV/n3IFlJ827LABL5sA5J uedUWi2isLJOBxeF4YCQNF9wyFDQWxIxn23TtZD3GtcVir6P0YlmjKvXDz1q3J5+FPmu l7QCGC5ZTn1AaZfAVhoE7cQUYOIR2xHTnsQQG1RMi/NgvnPPvxOWnH9phfj2oRX8BzMa ZD7yaC6We9Clt+rGbdgktAyyf+LEQ2JevUvkyBDIx5enRygmNDQYfcmPQbrH89PbTBp1 +ivOPAMio3u7aNezrC/t9lVaOPW2GwF3LqnQIrJkwdd0JoxUN6sBUTzeqW2i1qvNbNAC rX8w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783412608; x=1784017408; h=cc:to:from:subject:message-id:mime-version:date:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=edpuzPNlqLkIiVe8hDiwbrsEC4+WRFM9TrLPB0rzqfk=; b=ZA0bmTJhf763W2QnWWHA5LNeW0onqrPc7iI3pX7cqGz01svgU3W3emm/lKHb0wKcYH gA0SO0wbXS73cSW4gaWtV4L/oBEKydzzrqQQTcr3x8FAbh0csSoQTCGvY2NShGskadyC zTlOBaFsLrXpq0oDoWgmsdpxeRm57v+2hMJT1+idKrLqrKnCE/uJBt9jNutS4sLz6xi4 th7GhKfaMCenbf8XJ6QxcwnjvYmewatkTS8brDswysYRSdh6Dd49b/xe+NnNVIr+bcZV TCK5yE+WnbJlPGzrZMSG5lgAOjdhcvGVNkJXWia973nQFN8FGmmAEtJqEoVmZKopc/RC CclA== X-Forwarded-Encrypted: i=1; AHgh+Ro9N67wYtt0wv7FPEl0tYPGbkwpJ0HNkgjloKZlL4p38QOXzPBqR/dM7nM3A+xlsm2HZJ9yPsE=@vger.kernel.org X-Gm-Message-State: AOJu0YxwwPC8jRp7P+i6CmQjDFLcDJmpvzbTqcyuH8ch2ds6lLiH7Qnz m+I4Ru6yd/QgMo4820sXzNh4Sn4+d0cTKxEZUhdSYIAuGo18U6rKlzuzCc2BUwMXcAv5ICh10Mw w+wCmCNqhSFJOwQ== X-Received: from qtrr15-n2.prod.google.com ([2002:a05:622a:a98f:20b0:51c:f5f:5d2c]) (user=edumazet job=prod-delivery.src-stubby-dispatcher) by 2002:a05:622a:3cf:b0:50d:900e:c1c1 with SMTP id d75a77b69052e-51c747ca072mr45429201cf.7.1783412607802; Tue, 07 Jul 2026 01:23:27 -0700 (PDT) Date: Tue, 7 Jul 2026 08:23:27 +0000 Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 X-Mailer: git-send-email 2.55.0.795.g602f6c329a-goog Message-ID: <20260707082327.3238690-1-edumazet@google.com> Subject: [PATCH net] net: hsr: fix memory leak on slave unregistration by removing synced VLANs From: Eric Dumazet To: "David S . Miller" , Jakub Kicinski , Paolo Abeni Cc: Simon Horman , Andrew Lunn , netdev@vger.kernel.org, eric.dumazet@gmail.com, Eric Dumazet , syzbot+456957213f32970c0762@syzkaller.appspotmail.com Content-Type: text/plain; charset="UTF-8" When an HSR master device is brought UP, it auto-adds VLAN 0 via vlan_vid0_add(), which propagates VID 0 to its slave devices. If a slave device is later unregistered while HSR is active (e.g., during netns cleanup or interface destruction), hsr_del_port() is called to detach the slave port from the HSR master. However, hsr_del_port() currently does not delete the VLAN IDs that were synced to the slave device by HSR. As a result, the slave device retains a refcount on VID 0 (and any other synced VLANs). When the slave device is destroyed, its vlan_info / vlan_vid_info structure remains allocated, leading to a memory leak. Fix this by calling vlan_vids_del_by_dev(port->dev, master->dev) in hsr_del_port() before unlinking the slave device, matching the cleanup behavior in bonding and team drivers. Fixes: 1a8a63a5305e ("net: hsr: Add VLAN CTAG filter support") Reported-by: syzbot+456957213f32970c0762@syzkaller.appspotmail.com Closes: https://lore.kernel.org/netdev/6a4cb6ca.57639fcc.86d58.000b.GAE@google.com/T/#u Signed-off-by: Eric Dumazet --- net/hsr/hsr_slave.c | 1 + 1 file changed, 1 insertion(+) diff --git a/net/hsr/hsr_slave.c b/net/hsr/hsr_slave.c index d9af9e65f72f07b1997b80c85db16d812fbda488..2d1e3ea72088e35d5d870b4cc86dd2f789670394 100644 --- a/net/hsr/hsr_slave.c +++ b/net/hsr/hsr_slave.c @@ -242,6 +242,7 @@ void hsr_del_port(struct hsr_port *port) netdev_rx_handler_unregister(port->dev); if (!port->hsr->fwd_offloaded) dev_set_promiscuity(port->dev, -1); + vlan_vids_del_by_dev(port->dev, master->dev); netdev_upper_dev_unlink(port->dev, master->dev); if (hsr->prot_version == PRP_V1 && port->type == HSR_PT_SLAVE_B) { -- 2.55.0.795.g602f6c329a-goog