From: Marcin Szycik <marcin.szycik@linux.intel.com>
To: intel-wired-lan@lists.osuosl.org
Cc: netdev@vger.kernel.org, anthony.l.nguyen@intel.com,
Marcin Szycik <marcin.szycik@linux.intel.com>,
kernel test robot <lkp@intel.com>
Subject: [PATCH iwl-next] ice: fix uninitialized response buffer in ice_acl_create_tbl()
Date: Thu, 9 Jul 2026 16:59:04 +0200 [thread overview]
Message-ID: <20260709145904.164375-1-marcin.szycik@linux.intel.com> (raw)
Buffer is uninitialized in error path. Move assignment before goto. This
buffer is only used for response, so its content doesn't matter.
Fixes: d80ee68614c3 ("ice: initialize ACL table")
Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202607022231.FWjSU75X-lkp@intel.com
Signed-off-by: Marcin Szycik <marcin.szycik@linux.intel.com>
---
Tony, please squash this with the offending commit. It's not applied
yet, so hash is invalid, but I don't want to resend a ~5000 line
patchset just to move one line.
---
drivers/net/ethernet/intel/ice/ice_acl_ctrl.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/ethernet/intel/ice/ice_acl_ctrl.c b/drivers/net/ethernet/intel/ice/ice_acl_ctrl.c
index a76762e3aa46..4ea08bd9784c 100644
--- a/drivers/net/ethernet/intel/ice/ice_acl_ctrl.c
+++ b/drivers/net/ethernet/intel/ice/ice_acl_ctrl.c
@@ -354,14 +354,14 @@ int ice_acl_create_tbl(struct ice_hw *hw, struct ice_acl_tbl_params *params)
return -ENOMEM;
}
+ resp_buf = &tbl_alloc.buf.resp_buf;
+
tbl = kzalloc_obj(*tbl);
if (!tbl) {
err = -ENOMEM;
goto err_dealloc_tbl;
}
- resp_buf = &tbl_alloc.buf.resp_buf;
-
/* Retrieve information of the allocated table */
tbl->id = alloc_id;
tbl->first_tcam = resp_buf->ops.table.first_tcam;
--
2.49.0
next reply other threads:[~2026-07-09 15:59 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-09 14:59 Marcin Szycik [this message]
2026-07-10 6:47 ` [Intel-wired-lan] [PATCH iwl-next] ice: fix uninitialized response buffer in ice_acl_create_tbl() Loktionov, Aleksandr
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260709145904.164375-1-marcin.szycik@linux.intel.com \
--to=marcin.szycik@linux.intel.com \
--cc=anthony.l.nguyen@intel.com \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=lkp@intel.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox