From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f45.google.com (mail-wr1-f45.google.com [209.85.221.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4F7404315F for ; Thu, 9 Jul 2026 22:45:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.45 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783637159; cv=none; b=krDprzz747PANFmn+xp0AV3cq5e+BMZY5s0AQ2RPD8V2+gDHUA52ve8NfkV2KMMFsX/SR/0StMjSWLcwLxs8sak+eQ6jPwr2hxfzs6y6WuEbNmGfore9x5AgN5AQ1S1s22W/kc1fvDVIG7rbM8rhSn3GF1tfWK6RnaWauADYARY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783637159; c=relaxed/simple; bh=MGMNdJLo25LAzcpT5SeLIiyZDEx6Ib234ZVeZgxVkEc=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=XKITjKYkvnSsjeYg9GLNL8q++H9HU1josSCUyuKdTSKCbM8unVhTKR92LwC9TIcWcmvtWxqNFJ9a0wwPqAF6dC7T2bhxiegCcadyztGBDI63yMFKCEQnXYPhQ1+WqGU8X1VDxP9NBOh10So0PIm9AiYGcQKPibZeDvLuM+mww1Y= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=purestorage.com; spf=pass smtp.mailfrom=purestorage.com; dkim=pass (2048-bit key) header.d=purestorage.com header.i=@purestorage.com header.b=SAeOjeJV; arc=none smtp.client-ip=209.85.221.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=purestorage.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=purestorage.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=purestorage.com header.i=@purestorage.com header.b="SAeOjeJV" Received: by mail-wr1-f45.google.com with SMTP id ffacd0b85a97d-47d6c634f45so227725f8f.3 for ; Thu, 09 Jul 2026 15:45:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=purestorage.com; s=google2022; t=1783637156; x=1784241956; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=wLN12DgRS88lTiZTocaolG1YOhh4+rIwZ/HTAPUgOKI=; b=SAeOjeJVzj09ro4zy6yyqZLEmRmjobvOF4Gk1jsV0hNmFI2Kk2qjdFu0SEoNc5D9jZ eQX0t0NqaxJGe0ZiBr+Ggf03paGdPcwuyo2hnrVtPq7duIbwhuOZZDtTRAf5QtMQ6s0N +02dHIWfX2MZdy+9ewX3q6OVki9AjrDBsi5lhL3J6B0+GiqNA3vsTOxrMV3+8K8KK+3T ES5IKLuhezLNULk0vrOfXft/UiBN0Y/B8CQO7L9LZYh2/Dc7/na347KzpWjGXd9bAcRb +bIB6ZgNe28kUYcGwM2jZyx164MxYoU00rTb3JN71QoS4DTHuUsJvH13q4nPg3E9HY/N up6g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783637156; x=1784241956; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=wLN12DgRS88lTiZTocaolG1YOhh4+rIwZ/HTAPUgOKI=; b=Yw0jkIR0syiul+o8zyeQUXUYbwNtvmsV4Lixn/MYmU4E5yXBWYJqjn4lmeyjHgCzCZ Qd3Gylo8X5ZR6aLw85L5spPz8gGUYThk14RP3omA9lK6aGsJ4y8eQYKGxz9uDdc1nUc3 c6Gg9fbiI6IRgLZYYvO5GDaoPgx+0W3pQxWCl4p1pihwLoGJSzHdH803amNpu/amilqn pjXcMUQH63YxCnueQ+eS0X5+iWuFcDMPipp6+T5roQ5wq+/iCQCmjdVNORAkCQZ321jj 6d9j9SnFsoS2yag3+G/1v/p1k39PVTmpGMuTzfTZzVvMRQ8E4mllGWPXs9FX/MJc7ltm h31g== X-Gm-Message-State: AOJu0Yy0PwcmcgIfBsmCGEh8ANAvHm8hxTrt52oSLxcs0y1N3P1IJdoj c34RydbphcyBe4yXLINgTkXxG+Ex+xsA/tk45RH2+Z5ahhOTKNibooP0WRMDC2lJAWPPJjolA+q b2Q5yOsBtEpJHSXteJP7HuTshG4gIvkqAJ9cy/9XQKcWfLIjHAS6KCl/AInVJF9vf2cdr9iDm1a NocsBBmZZI9X6BOZnzu5Boe8PAxeODnhCZLvJff8cT0PH6mQ0= X-Gm-Gg: AfdE7clLPE22+ANX7A3pl0nwpCgm0v7NB3cw3IUlvRENKVfD63K+RL+FeetkdmlA4fV njyabxrZZMnp7jMadz0YRf5rhjje63LlS3btEoMyfahGXCYF+ebHPLS0MMUIS12DVO59Ec3Ij3D LtX5S2yqjiBXAVHy5MJDN843WY3kMU4QQ0YumXrkRScZ9S63n+RNWfDuu/ieaA1jVX5zd3uusZB a+jRZCMWlNyNyt7uX3vLc/Aijsoiy6CdX8MpErAkVZBWOZbMnrtUT4cHyubo01L3tFfaK6xHVuf IMQ/6Oaj5nDpnkDDjKXswms4MQOVA5sKuibUJAUXwAJPhjdO1k5BCgJV6WZC6gM6vx6/a47rK1t zjh9IkXogzZ5ghvayjSDkLM6Bbkq6a964eXavU/k4Zuze2fWk2JvmaY4F0MRh+Emzs0NpD6ju4H 2SN2NMNUecq5CzDNscf/CKRVcumXkvEg069kPOKRF9kISrdzSBu6eLcVE3L9WYCKP7EnarChprM yHnC67jUgJqugRuRq9CirunRmnGeAmgNe0vM27E/5LHtO65H/Y0IP+23eYnZ6sMfXcXthJWxyMD IW1rmco/a8MNkxtMCFC5I9eoFW6umP80h0U= X-Received: by 2002:a05:6000:1844:b0:475:f0c2:5b04 with SMTP id ffacd0b85a97d-47df07a2b2cmr9810845f8f.58.1783637155496; Thu, 09 Jul 2026 15:45:55 -0700 (PDT) Received: from dev-rjethwani.dev.purestorage.com ([208.88.159.128]) by smtp.googlemail.com with ESMTPSA id ffacd0b85a97d-47a9de1e6ccsm54918142f8f.5.2026.07.09.15.45.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 09 Jul 2026 15:45:55 -0700 (PDT) From: Rishikesh Jethwani To: netdev@vger.kernel.org Cc: john.fastabend@gmail.com, kuba@kernel.org, sd@queasysnail.net, davem@davemloft.net, pabeni@redhat.com, edumazet@google.com, leon@kernel.org, nils.juenemann@gmail.com, Rishikesh Jethwani Subject: [PATCH 1/1] tls: device: push pending open record on splice EOF Date: Thu, 9 Jul 2026 16:44:36 -0600 Message-Id: <20260709224436.1608993-2-rjethwani@purestorage.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20260709224436.1608993-1-rjethwani@purestorage.com> References: <20260709224436.1608993-1-rjethwani@purestorage.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit On kTLS device-offload sockets, sendfile() with count > EOF can reach ->splice_eof() with a fully assembled but still-open TLS record left pending. tls_device_splice_eof() only flushes partially sent records, so an abrupt close() can drop the final record and the peer receives a short file. Fix tls_device_splice_eof() to also push pending open records. This matches the software path, where splice EOF already flushes pending open records. Fixes: d4c1e80b0d1b ("tls/device: Use splice_eof() to flush") Link: https://lore.kernel.org/netdev/CAMPsyauZ+jzG9AysO0FWv6ZY0kvCUpjX_U7o=oOjCuOQ87BCgg@mail.gmail.com/ Reported-by: Nils Juenemann Signed-off-by: Rishikesh Jethwani --- net/tls/tls_device.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/net/tls/tls_device.c b/net/tls/tls_device.c index 741aef09bfd3..37bb06a8e8f5 100644 --- a/net/tls/tls_device.c +++ b/net/tls/tls_device.c @@ -595,13 +595,15 @@ void tls_device_splice_eof(struct socket *sock) struct tls_context *tls_ctx = tls_get_ctx(sk); struct iov_iter iter = {}; - if (!tls_is_partially_sent_record(tls_ctx)) + if (!tls_is_partially_sent_record(tls_ctx) && + !tls_is_pending_open_record(tls_ctx)) return; mutex_lock(&tls_ctx->tx_lock); lock_sock(sk); - if (tls_is_partially_sent_record(tls_ctx)) { + if (tls_is_partially_sent_record(tls_ctx) || + tls_is_pending_open_record(tls_ctx)) { iov_iter_bvec(&iter, ITER_SOURCE, NULL, 0, 0); tls_push_data(sk, &iter, 0, 0, TLS_RECORD_TYPE_DATA); } -- 2.25.1