From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from fout-a5-smtp.messagingengine.com (fout-a5-smtp.messagingengine.com [103.168.172.148]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A5F2B42882C for ; Fri, 10 Jul 2026 13:43:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=103.168.172.148 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783691001; cv=none; b=c1/HcGUdIOGGuEBHwuHxx+9crhEKimcar/lfU+yuVOgJxe8IKhkRaPBRjTKS9/X9tYHzpxr+0qllwaPiR+N26LJhiyD6eqwRKFCmQ5+eRKLhP0hnl8b25iGo7ndjJGuKwer3Z8UCdclQWKuNEmcF4YpRgBOenYO4rO3csGZvarI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783691001; c=relaxed/simple; bh=BpMU/KQZxIQhJJ019dQAS3ORZw04v9Z1KJIt1fkVI2U=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=ofs5SWi7ccGWdHtcZUSZuPWJ/Y+pLTSI+Z2n25aQ/VAshlS/3z2mCYZ5rnk9iJ1gOKiRm0pcQtUoyoTTF1VWaKDpgYVKdeeLnAxvNA98/yEQlYJBocMMhJ9Aksy+Dvo71h0w/QckNqe5AOpnXzr5ZXY0770xH7sELWUWgVw94yE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=fastmail.im; spf=pass smtp.mailfrom=fastmail.im; dkim=pass (2048-bit key) header.d=fastmail.im header.i=@fastmail.im header.b=ki5OQ/tu; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b=o3b4Tp2q; arc=none smtp.client-ip=103.168.172.148 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=fastmail.im Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=fastmail.im Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=fastmail.im header.i=@fastmail.im header.b="ki5OQ/tu"; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="o3b4Tp2q" Received: from phl-compute-02.internal (phl-compute-02.internal [10.202.2.42]) by mailfout.phl.internal (Postfix) with ESMTP id 21C79EC01CD; Fri, 10 Jul 2026 09:43:19 -0400 (EDT) Received: from phl-frontend-04 ([10.202.2.163]) by phl-compute-02.internal (MEProxy); Fri, 10 Jul 2026 09:43:19 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fastmail.im; h= cc:cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:subject:subject:to:to; s=fm2; t=1783690999; x= 1783777399; bh=iezIZhXVpeSc8eAq7auxerJW6WGW3QxsYHckVvIqEJ8=; b=k i5OQ/tuYQeMjmVy5Jlv80YJtzYTI9TsW7PO7g7BeoTyraHBhKtzuCpeoLxQAjnQi oNpdmrfS6dA7cxKQAGOvzg9KpnnoIMRHHBdo9KwhpbUHqZNArRGxsQx6Uk8tr+vm mKBOGw99fu4xk11XY/3qfQ/yMZ+aSVqBgvSVYcnUmTNK/zVwvriQ0IOkObqYWZB9 mXBvpumlsDs9VPght2W8yl8wGqjfTz0H1DlalX49FzrCeq3JFIwq71LUlZ1iGl7U BiR8HHYLW6l9jXQGFJYGtfY4xP2eXaztCgUcCWZgrssrlIbYBS8cZT2I541wzj5f icIxYMurYQjmxK0jsunTw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:subject:subject:to:to:x-me-proxy:x-me-sender :x-me-sender:x-sasl-enc; s=fm2; t=1783690999; x=1783777399; bh=i ezIZhXVpeSc8eAq7auxerJW6WGW3QxsYHckVvIqEJ8=; b=o3b4Tp2qQDTUqzVxh bqTYfYIl27CD7LZ12zpimXj0JSEbHBiE2OXltDIkJlfX76qOmsb2OzoaAfGuMYyk Y5kH3/UX4UrH+m3Z/KPMaDEt1nernOCS3BRNuFDwK/nxIHTYL3VerBobQ8ZlX2xY 91/GMLIXIaDRPlmFrz5tYHrAKpVNN2xmxyNK6VeF+rsTCB/SuFS8EvPqNQBIyuCM yiV0e/yg3oDV7BaubL5c3V0t6LvqNE1Vl8k9Hh1lqVR1C1SKF3TB7z8darGoR1bh Gin05A4brmJGmE5iMQjOAuCzNYgaBygNWHMukoK/eyN04jt47X5L0KWbrmuk4ASW T8UxQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: dmFkZTEFIDtJybMkhSz+aoCbMXzoIhducNEuhAb0UsdKW5vcb9RmME7tTBBbX+IAN6HHwY jY7/HMSMdSWiW5jJB1rcMXZzIQ4BMvX7Tr0yaCVUph3WHVV4fbiicPZHUJdcrlrp7295Cp LreCLwrcwqFxVNkzCtLJGVDhvn6zUcFiNQ5fMd+1s1CO9ZZzUPogPBJybRzncs3ZWPs6wa TxqPh3N4CWqJSN34wr2B+PIx8mJmH3CcYKvVADIrsqMwDX3woDS9gF3a3eIm4aesJrm7/T 31W50qtne2kH9Ab0cGetb1iVvNTWqi9GzFymzVT0XTWgFFtDCNjAcOKQnyb1MyGsC8dSlt Phk1jgHqsLsi7+M6bVNCQZMgVaa9ridDsh8H5MxU/EeiTeH1nnIK/HedjR+HdC+JC+qYkZ edzNIqTcqimDtZ73rPCGARlwGu62pEhSSqPpiZLt4YGs33SDhEw17dd5HJ5pCWxMdUixsM Dj7NjWhnjgOYJj8LOUiLQhj6IP5YLpzk36tYNjHkTWskgCZ2gZjpjWQXLIgPxHrrkHdNjq NGgxs4UEJpv47U/rWbl1Fk3V99U6/5THxk1fVjU9EBlJy4Z1X4XeND3gFJLmeb6HOzddkv bk3xot1OYsVENwTQUwF0afdMpvv/l58ZNqlnergGG+YeP5VAwOTJ3dB+QSgQ X-ME-Proxy: Feedback-ID: i559e4809:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 10 Jul 2026 09:43:18 -0400 (EDT) From: Alice Mikityanska To: Daniel Borkmann , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Xin Long , Willem de Bruijn , Willem de Bruijn , David Ahern , Nikolay Aleksandrov Cc: Shuah Khan , Stanislav Fomichev , Andrew Lunn , Simon Horman , Florian Westphal , netdev@vger.kernel.org, Alice Mikityanska Subject: [PATCH net-next v9 3/9] udp: Support BIG TCP GSO packets where they can occur Date: Fri, 10 Jul 2026 16:42:36 +0300 Message-ID: <20260710134242.216538-4-alice.kernel@fastmail.im> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260710134242.216538-1-alice.kernel@fastmail.im> References: <20260710134242.216538-1-alice.kernel@fastmail.im> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Alice Mikityanska Wherever a GSO packet can occur, and its length is used to fill the UDP header, use udp_set_len that assigns 0 if the length doesn't fit 16 bits, so that the packet can be properly parsed and segmented later, instead of having truncated length. Use udp_get_len in udp_validate_len to treat BIG TCP packets as valid. Signed-off-by: Alice Mikityanska Reviewed-by: Willem de Bruijn --- net/ipv4/fou_core.c | 2 +- net/ipv6/fou6.c | 2 +- net/netfilter/ipvs/ip_vs_xmit.c | 2 +- net/netfilter/nf_conntrack_proto_udp.c | 2 +- net/psp/psp_main.c | 2 +- 5 files changed, 5 insertions(+), 5 deletions(-) diff --git a/net/ipv4/fou_core.c b/net/ipv4/fou_core.c index a50740d0f288..aef3ce1dec7a 100644 --- a/net/ipv4/fou_core.c +++ b/net/ipv4/fou_core.c @@ -1040,7 +1040,7 @@ static void fou_build_udp(struct sk_buff *skb, struct ip_tunnel_encap *e, uh->dest = e->dport; uh->source = sport; - udp_set_len_short(uh, skb->len); + udp_set_len(uh, skb->len); udp_set_csum(!(e->flags & TUNNEL_ENCAP_FLAG_CSUM), skb, fl4->saddr, fl4->daddr, skb->len); diff --git a/net/ipv6/fou6.c b/net/ipv6/fou6.c index 588929409241..4b659ca60ba9 100644 --- a/net/ipv6/fou6.c +++ b/net/ipv6/fou6.c @@ -30,7 +30,7 @@ static void fou6_build_udp(struct sk_buff *skb, struct ip_tunnel_encap *e, uh->dest = e->dport; uh->source = sport; - udp_set_len_short(uh, skb->len); + udp_set_len(uh, skb->len); udp6_set_csum(!(e->flags & TUNNEL_ENCAP_FLAG_CSUM6), skb, &fl6->saddr, &fl6->daddr, skb->len); diff --git a/net/netfilter/ipvs/ip_vs_xmit.c b/net/netfilter/ipvs/ip_vs_xmit.c index ae3ed2c00ec3..c51ebd83a476 100644 --- a/net/netfilter/ipvs/ip_vs_xmit.c +++ b/net/netfilter/ipvs/ip_vs_xmit.c @@ -1100,7 +1100,7 @@ ipvs_gue_encap(struct net *net, struct sk_buff *skb, dport = cp->dest->tun_port; udph->dest = dport; udph->source = sport; - udp_set_len_short(udph, skb->len); + udp_set_len(udph, skb->len); udph->check = 0; *next_protocol = IPPROTO_UDP; diff --git a/net/netfilter/nf_conntrack_proto_udp.c b/net/netfilter/nf_conntrack_proto_udp.c index 8a5675983e7c..a7edfefd6fd1 100644 --- a/net/netfilter/nf_conntrack_proto_udp.c +++ b/net/netfilter/nf_conntrack_proto_udp.c @@ -45,7 +45,7 @@ static bool udp_validate_len(struct sk_buff *skb, const struct udphdr *hdr, unsigned int dataoff) { - unsigned int udplen = udp_get_len_short(hdr); + unsigned int udplen = udp_get_len(skb, hdr, dataoff); unsigned int skblen = skb->len - dataoff; if (udplen > skblen || udplen < sizeof(*hdr)) diff --git a/net/psp/psp_main.c b/net/psp/psp_main.c index 90c7dc4e76a1..c9c1a8826b7f 100644 --- a/net/psp/psp_main.c +++ b/net/psp/psp_main.c @@ -231,7 +231,7 @@ static void psp_write_headers(struct net *net, struct sk_buff *skb, __be32 spi, uh->source = udp_flow_src_port(net, skb, 0, 0, false); } uh->check = 0; - udp_set_len_short(uh, udp_len); + udp_set_len(uh, udp_len); psph->nexthdr = IPPROTO_TCP; psph->hdrlen = PSP_HDRLEN_NOOPT; -- 2.54.0