From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.9]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 546BA3CCA13; Fri, 10 Jul 2026 21:53:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.9 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783720413; cv=none; b=iXs9TvEXwVIzJ8OuuRd/EG0VjyUJKdKqjBPb0zXgyudHIoOE8xmM3x9bUDyyTbjMJ4TNvWOC83S8jN4VhYkzOOm2s/FOkvB2V3Xj6hg2oPwjgRSVn0HGFJdzMIpoXKoAO+J6fjFTuy+lXd13ve+dkaELe50hqXf2jkdM7le2k2U= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783720413; c=relaxed/simple; bh=5UMsDaI40kLIhvFQda9jCRZY6G24TnN5ExVTwtB+6hI=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=bMQtFIjPI6j7WfjM7tmffnelO+vKqqseEVECH7IVNP7WJp72N2OIMBWGJJU1dXB7tAKlnR1epCGN7Jt/Bl0Pf9mvZbOcUDAIYxLpykbHxxOv+Jt1DGzTLxAxyCOfzPYZY+LI47RFP/oExaQVIip6HT8Uz0Jsblq2x3zKq8sWHw0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=Dy0fdmZc; arc=none smtp.client-ip=198.175.65.9 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="Dy0fdmZc" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1783720413; x=1815256413; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=5UMsDaI40kLIhvFQda9jCRZY6G24TnN5ExVTwtB+6hI=; b=Dy0fdmZcGYy6HtHRgUSavOMLe2K+GM0K7DSkmcRkNieJbYxiEaImk1fp QNE0mk89IUYfgcu6IIpkKHEEMKxJzjPlZlaRzYl18HUMYJLTX6Db4FzXO fmLus8QI2Bv+FW+qmduAR58XH/n7nZ+HaIq1lbWvfgWso9E+yOGFRp6gZ BmLIiokinvb1MG7wE1jv5gFz4qXdxosuo/elFzUAZaZ4JWCETCjwYb5tn DKXlnnwj1Uat7HD0IaUdmx31U4JSC/QP6gCEGE07UtSBMlhvDld01Khvy Hp7hSyuZf7rxWa4bdczeVBC4RwIcUCYvwGFLKiFlcb9mMtfLpAorAgm3+ w==; X-CSE-ConnectionGUID: oiTpAFZRTuKL+pTzv3mlIA== X-CSE-MsgGUID: mUXSzRzIQdmzS6pctt7oFg== X-IronPort-AV: E=McAfee;i="6800,10657,11841"; a="107220801" X-IronPort-AV: E=Sophos;i="6.25,154,1779174000"; d="scan'208";a="107220801" Received: from orviesa008.jf.intel.com ([10.64.159.148]) by orvoesa101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Jul 2026 14:53:24 -0700 X-CSE-ConnectionGUID: EkZfmZqjQHKPs18tUwY45g== X-CSE-MsgGUID: wD0X2liBSMKUUpXVp5NNag== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.25,154,1779174000"; d="scan'208";a="254494655" Received: from anguy11-upstream.jf.intel.com ([10.166.9.133]) by orviesa008.jf.intel.com with ESMTP; 10 Jul 2026 14:53:23 -0700 From: Tony Nguyen To: davem@davemloft.net, kuba@kernel.org, pabeni@redhat.com, edumazet@google.com, andrew+netdev@lunn.ch, netdev@vger.kernel.org Cc: Larysa Zaremba , anthony.l.nguyen@intel.com, przemyslaw.kitszel@intel.com, aleksander.lobakin@intel.com, sridhar.samudrala@intel.com, anjali.singhai@intel.com, michal.swiatkowski@linux.intel.com, maciej.fijalkowski@intel.com, emil.s.tantilov@intel.com, madhu.chittim@intel.com, joshua.a.hay@intel.com, jacob.e.keller@intel.com, jayaprakash.shanmugam@intel.com, jiri@resnulli.us, horms@kernel.org, corbet@lwn.net, richardcochran@gmail.com, linux-doc@vger.kernel.org, Aleksandr Loktionov , Samuel Salin Subject: [PATCH net-next v4 11/15] idpf: print a debug message and bail in case of non-event ctlq message Date: Fri, 10 Jul 2026 14:53:08 -0700 Message-ID: <20260710215313.1475803-12-anthony.l.nguyen@intel.com> X-Mailer: git-send-email 2.47.1 In-Reply-To: <20260710215313.1475803-1-anthony.l.nguyen@intel.com> References: <20260710215313.1475803-1-anthony.l.nguyen@intel.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Larysa Zaremba Unlike previous internal idpf ctlq implementation, idpf calls the default message handler for all received messages that do not have a matching xn transaction, not only for VIRTCHNL2_OP_EVENT. This leads to many error messages printing garbage, because the parsing expected a valid event message, but got e.g. a delayed response for a timed-out transaction. The information about timed-out transactions and otherwise unhandleable messages can still be valuable for developers, so print the information with dynamic debug and exit the function, so the following functions can parse valid events in peace. Reviewed-by: Aleksandr Loktionov Reviewed-by: Michal Kubiak Tested-by: Samuel Salin Signed-off-by: Larysa Zaremba Signed-off-by: Tony Nguyen --- drivers/net/ethernet/intel/idpf/idpf_virtchnl.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/drivers/net/ethernet/intel/idpf/idpf_virtchnl.c b/drivers/net/ethernet/intel/idpf/idpf_virtchnl.c index 1b5935e9c538..bf63fc71d6ae 100644 --- a/drivers/net/ethernet/intel/idpf/idpf_virtchnl.c +++ b/drivers/net/ethernet/intel/idpf/idpf_virtchnl.c @@ -84,6 +84,13 @@ void idpf_recv_event_msg(struct libie_ctlq_ctx *ctx, u32 event; adapter = container_of(ctx, struct idpf_adapter, ctlq_ctx); + if (ctlq_msg->chnl_opcode != VIRTCHNL2_OP_EVENT) { + dev_dbg(&adapter->pdev->dev, + "Unhandled message with opcode %u from CP\n", + ctlq_msg->chnl_opcode); + goto free_rx_buf; + } + if (payload_size < sizeof(*v2e)) { dev_err_ratelimited(&adapter->pdev->dev, "Failed to receive valid payload for event msg (op %d len %d)\n", ctlq_msg->chnl_opcode, -- 2.47.1