From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f47.google.com (mail-pj1-f47.google.com [209.85.216.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E93BC4483B2 for ; Fri, 10 Jul 2026 22:31:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.47 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783722663; cv=none; b=pcyz+HQCuvtTZPgZ5C6ifYXQ24PcmNASrwniG7j6UBOJNHGJVGTEXJ6v7WTDV7M5q0qCbymkjknyUcBsiZulfxK6NcJk0FoSvrUGalFqi/EbieQYbUnszJBR7KCNspQWpS1t3xSujV6Zp+xEElZELf8L+BadnGkxJ4JfzHA/A8o= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783722663; c=relaxed/simple; bh=je8b0NJ3kzl2VgAVR76DhvpWSaNnBgzqfWKjUFfnbDQ=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=tJ1awLUI4W0g4LC3aQpnuJipjOqdbuEcbMOENjryk1/JvrkvR34VcV+y3XMKce2LL/aSlgcQdpvHLXYx2UJbr0C69p5ZYeKz4wuiORm1IpJ/Lel9HdZe97C6DtqDhNcbi7kt3kxYXIb6e0hbBLc5BZQ+7RZhIHxCy0ENFdQ5vmk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=asu.edu; spf=pass smtp.mailfrom=asu.edu; dkim=pass (2048-bit key) header.d=asu.edu header.i=@asu.edu header.b=JVaJNw7K; arc=none smtp.client-ip=209.85.216.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=asu.edu Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=asu.edu Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=asu.edu header.i=@asu.edu header.b="JVaJNw7K" Received: by mail-pj1-f47.google.com with SMTP id 98e67ed59e1d1-37df72c9984so2441429a91.3 for ; Fri, 10 Jul 2026 15:31:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=asu.edu; s=google; t=1783722661; x=1784327461; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=C0kfgGvEQ8I7mCwBq+ettrM4PZ07Bq+DUOcQ+ZPJPwM=; b=JVaJNw7K6iRbe6SVWLVhRoiXL8XTdKSIZEgwgTTARF59sIkQypcguk5Hgv4O23xki/ zDj01Pp45TAxlX1vYMqebRbfbKkfMM7lXhQRPZNagalSUFfuareHuoH3NdzzOcfrQWJX K/oZsgTmgUiinqlVSh6ihV0SZSeb7Ho5YqC4kYwtxcLJZK3S/CUgDLRE+KB1SaxU+ero naFGicxwF49B/hl/1KnTjKKxSG50ony3TEXSQ1DXeRr69SN6oDjb2P/+7XmMwKVv97iN Fix1NnbT1QtJnfGfBtqS8uKpcrLuYGf9+V6XxmCXAY0W4gD2vSkCLMWKPw56zSy7bynX T5xw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783722661; x=1784327461; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=C0kfgGvEQ8I7mCwBq+ettrM4PZ07Bq+DUOcQ+ZPJPwM=; b=Glt/b9S0c+PUnwDrFZUTk7CTNskxQrgTOlhgHOVJLjz9Yf5jWAQzyWwRIKVKms6z8R IQlwMew98ePyUQ1SEYAEWRsUWCzx0jguy0QRS9V/LbyCyPjw3moigkGXmY2XPC41L3ki 9i6BhjOS+V+4MZBI+4JyAkKEbir8q7nOCD3TtSnT6lALaQ8vsM57k3xYw/HLatwVgki2 uiX3WOV/phmXPZzHaDNUf7cj7bIkzy1NJBKRk6BdD6YocaBE8sNtrUdIH3Q7vHZFTECx 6hHvRswc0M8vDTEyCrietCnoUgYdE9Pc2MrH6lkCDTAiUXBZLqHwRuguzpVbMPeJshNY cPfQ== X-Gm-Message-State: AOJu0Yw8t+FHsAG9w0LjhH4+VoJ8VnpDhXyfpeMvKJTY2TZE4ss5LGxz 6dn+a0Vr2+/ol+htDFPMQNAOmUELgyRKi2omLLg56pA+mkJW+R4hTjfHCoYAqr/Nkw== X-Gm-Gg: AfdE7cnNyjkAX/huZeCfBahuJrz//azpAPFKAcH7zIpE8mfKnqhN1Tth6K/ZhMKsqPd cC1DtYGtfLKXGOgj3Xz5eS5wWbQ55lYlH8TMCEs+JDhmJi919gLQiFtc5bnKg5dR0Yc6vz9iuUe 1qSqDDTRbMJAUFTA58DqkWkUerPXRTC1OQiGtOQzk7bs3ujlIj+fiISDPo26Yz0LDe0X8JMGhH+ gSs36AOTorLAlDZsQ62JLRINJ5VnB0fq7ibSlTdVqNQXnYoVwJuWNUE1vQ3eyRXQlzgcD6EzJco VGhf+ymFmptKA3BB4iLSSkGYn676KkFcUtbBwrwFP0GL1DX6qzgrUm8S2et9Vk3PfXDnti4v/mn MSOHSsiQg052i/G2qi7A3ylnC+Xky67Wre8gzEQlCecYA1Pq5ygoafOfIE/kKJ+bjVCCsfgS1 X-Received: by 2002:a17:90b:4f47:b0:387:e0cb:7f1 with SMTP id 98e67ed59e1d1-38dc7836681mr669430a91.37.1783722661211; Fri, 10 Jul 2026 15:31:01 -0700 (PDT) Received: from p1.. ([2607:fb90:ec80:eae:8075:172b:81dd:854c]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-38dc9fc78ffsm53267a91.9.2026.07.10.15.30.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 10 Jul 2026 15:31:00 -0700 (PDT) From: Xiang Mei To: Allison Henderson , "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman Cc: netdev@vger.kernel.org, linux-rdma@vger.kernel.org, rds-devel@oss.oracle.com, linux-kernel@vger.kernel.org, Santosh Shilimkar , Ka-Cheong Poon , bestswngs@gmail.com, Xiang Mei Subject: [PATCH net v2] rds: tcp: hold the RCU lock across ipv6_chk_addr() in rds_tcp_laddr_check() Date: Fri, 10 Jul 2026 15:30:29 -0700 Message-ID: <20260710223029.1307043-1-xmei5@asu.edu> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit rds_tcp_laddr_check() looks up a scoped IPv6 interface with dev_get_by_index_rcu(), drops the RCU read-side lock, and only then passes the bare struct net_device * into ipv6_chk_addr(). dev_get_by_index_rcu() only keeps the device alive within the same RCU read-side section. After rcu_read_unlock(), a concurrent RTM_DELLINK can free the net_device; ipv6_chk_addr() then dereferences the stale pointer in __ipv6_chk_addr_and_flags() (e.g. l3mdev_master_dev_rcu(dev)), reading freed memory. Keep the RCU read-side lock held across the ipv6_chk_addr() call instead of dropping it right after the lookup, so the device cannot be freed while it is in use. BUG: KASAN: slab-use-after-free in __ipv6_chk_addr_and_flags (... net/ipv6/addrconf.c:1998) Read of size 8 at addr ffff8880106ec000 by task exploit/153 Call Trace: ... kasan_report (mm/kasan/report.c:595) __ipv6_chk_addr_and_flags (... net/ipv6/addrconf.c:1998) ipv6_chk_addr (net/ipv6/addrconf.c:2031 net/ipv6/addrconf.c:1972) rds_tcp_laddr_check (net/rds/tcp.c:370) rds_bind (net/rds/bind.c:248) __sys_bind (net/socket.c:1920) __x64_sys_bind (net/socket.c:1956) do_syscall_64 (arch/x86/entry/syscall_64.c:63) entry_SYSCALL_64_after_hwframe (arch/x86/entry/entry_64.S:121) Fixes: eee2fa6ab322 ("rds: Changing IP address internal representation to struct in6_addr") Reported-by: Weiming Shi Assisted-by: Claude:claude-opus-4-8 Signed-off-by: Xiang Mei --- net/rds/tcp.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/net/rds/tcp.c b/net/rds/tcp.c index 955d92277d5a..30cfb0087f2c 100644 --- a/net/rds/tcp.c +++ b/net/rds/tcp.c @@ -355,23 +355,25 @@ int rds_tcp_laddr_check(struct net *net, const struct in6_addr *addr, /* If the scope_id is specified, check only those addresses * hosted on the specified interface. */ + rcu_read_lock(); if (scope_id != 0) { - rcu_read_lock(); dev = dev_get_by_index_rcu(net, scope_id); /* scope_id is not valid... */ if (!dev) { rcu_read_unlock(); return -EADDRNOTAVAIL; } - rcu_read_unlock(); } #if IS_ENABLED(CONFIG_IPV6) if (ipv6_mod_enabled()) { ret = ipv6_chk_addr(net, addr, dev, 0); - if (ret) + if (ret) { + rcu_read_unlock(); return 0; + } } #endif + rcu_read_unlock(); return -EADDRNOTAVAIL; } -- 2.43.0