From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9DC553D47A3; Wed, 15 Jul 2026 21:41:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784151667; cv=none; b=nwkA/EqLAT6N+3EJaJrlzsGRHEVgrLbX+GtrMMprOWaPqY67IxJj127yuNfDyr60uaJCKXMc72/V6p+XPYm0ktcG2vsc2fzYGqvKaioqbnb4jLZ11AqOQKUs5x6CpNrbhJ9fvQ2zBrc/9FbqJ+wm6T3pC13apNZ8IUm89vOSc0I= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784151667; c=relaxed/simple; bh=FRfn1Lcl7gODBO4+Z3pAtZTgRW7uRb7KRQzqnHWVGKg=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=l0FWRo06WrDLHrD6Jm6ijAcviEVbVoyiyai5sLUmhdGfTq6Kw/4jRUf3n8ULD8TstTDa9JUFc0lOC8Yq9Xs4MquFUM29mk8oRug+calcBsOgk0KUNv64b+lrnvdVLshASTbiB5WIiRFUcAkkaqDMK9Aj/V2pxjINHyy5TpI6fZY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=k7excM4z; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="k7excM4z" Received: by smtp.kernel.org (Postfix) with ESMTPSA id CCDC71F000E9; Wed, 15 Jul 2026 21:41:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1784151666; bh=ytgQP223R7qGdJ7/223EddJ2tqlEf9yQOplgDXsmED8=; h=From:Date:Subject:References:In-Reply-To:To:Cc; b=k7excM4zUczbPO7uHJ19oFHHeg+HrjKpbsCZyWshnM/VCMdOZ0I0e1SfE3PKhdj5z bQbRX41vxwaZIGp5yobSJc26u4EB3CiRq9ftSJIE9/kuA7qfs3QbqNYri9EDR/S8mt EY41IQkmBfF1O4HtWd2KsBqFcDsXBD6FMtrGvFz9wxI0oY8RDd05ZBnamZBXwFiHMS WeRDm0tdWaAmbYjVJ4KrXsgwkBc7Ws7x0SBqATV3koJe3TJBckNnhvccyjoHAbtRMr GUrZgueXB4gUNC++lUgohMwy00wkTItAIYiTt3/XHEhetLMEECGRFqqnmL3mlIW18v sdIYi1AUC6D1Q== From: Lorenzo Bianconi Date: Wed, 15 Jul 2026 23:39:43 +0200 Subject: [PATCH bpf-next v5 3/8] net: ice: add xmo_rx_checksum callback Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260715-bpf-xdp-meta-rxcksum-v5-3-623d5c0d0ab7@kernel.org> References: <20260715-bpf-xdp-meta-rxcksum-v5-0-623d5c0d0ab7@kernel.org> In-Reply-To: <20260715-bpf-xdp-meta-rxcksum-v5-0-623d5c0d0ab7@kernel.org> To: Donald Hunter , Jakub Kicinski , "David S. Miller" , Eric Dumazet , Paolo Abeni , Simon Horman , Alexei Starovoitov , Daniel Borkmann , Jesper Dangaard Brouer , John Fastabend , Stanislav Fomichev , Andrew Lunn , Tony Nguyen , Przemek Kitszel , Alexander Lobakin , Andrii Nakryiko , Martin KaFai Lau , Eduard Zingerman , Song Liu , Yonghong Song , KP Singh , Hao Luo , Jiri Olsa , Shuah Khan , Maciej Fijalkowski , Jonathan Corbet , Shuah Khan , Kumar Kartikeya Dwivedi , Emil Tsalapatis Cc: Vladimir Vdovin , Jakub Sitnicki , netdev@vger.kernel.org, bpf@vger.kernel.org, intel-wired-lan@lists.osuosl.org, linux-kselftest@vger.kernel.org, linux-doc@vger.kernel.org, Aleksandr Loktionov , Lorenzo Bianconi X-Mailer: b4 0.14.3 Implement xmo_rx_checksum callback in ice driver to report RX checksum result to the eBPF program bounded to the NIC. Introduce ice_get_rx_csum utility routine in order to make the rx checksum code reusable from ice_rx_csum() Reviewed-by: Aleksandr Loktionov Signed-off-by: Lorenzo Bianconi --- drivers/net/ethernet/intel/ice/ice_txrx_lib.c | 123 +++++++++++++++++--------- 1 file changed, 81 insertions(+), 42 deletions(-) diff --git a/drivers/net/ethernet/intel/ice/ice_txrx_lib.c b/drivers/net/ethernet/intel/ice/ice_txrx_lib.c index e695a664e53d..3aa82ff03d9e 100644 --- a/drivers/net/ethernet/intel/ice/ice_txrx_lib.c +++ b/drivers/net/ethernet/intel/ice/ice_txrx_lib.c @@ -78,69 +78,48 @@ ice_rx_hash_to_skb(const struct ice_rx_ring *rx_ring, libeth_rx_pt_set_hash(skb, hash, decoded); } -/** - * ice_rx_gcs - Set generic checksum in skb - * @skb: skb currently being received and modified - * @rx_desc: receive descriptor - */ -static void ice_rx_gcs(struct sk_buff *skb, - const union ice_32b_rx_flex_desc *rx_desc) -{ - const struct ice_32b_rx_flex_desc_nic *desc; - u16 csum; - - desc = (struct ice_32b_rx_flex_desc_nic *)rx_desc; - skb->ip_summed = CHECKSUM_COMPLETE; - csum = (__force u16)desc->raw_csum; - skb->csum = csum_unfold((__force __sum16)swab16(csum)); -} - -/** - * ice_rx_csum - Indicate in skb if checksum is good - * @ring: the ring we care about - * @skb: skb currently being received and modified - * @rx_desc: the receive descriptor - * @ptype: the packet type decoded by hardware - * - * skb->protocol must be set before this function is called - */ static void -ice_rx_csum(struct ice_rx_ring *ring, struct sk_buff *skb, - union ice_32b_rx_flex_desc *rx_desc, u16 ptype) +ice_get_rx_csum(const union ice_32b_rx_flex_desc *rx_desc, u16 ptype, + struct ice_rx_ring *ring, enum xdp_checksum *ip_summed, + u32 *cksum, u8 *cksum_level) { - struct libeth_rx_pt decoded; + struct libeth_rx_pt decoded = libie_rx_pt_parse(ptype); u16 rx_status0, rx_status1; bool ipv4, ipv6; - /* Start with CHECKSUM_NONE and by default csum_level = 0 */ - skb->ip_summed = CHECKSUM_NONE; - - decoded = libie_rx_pt_parse(ptype); if (!libeth_rx_pt_has_checksum(ring->netdev, decoded)) - return; + goto checksum_none; rx_status0 = le16_to_cpu(rx_desc->wb.status_error0); rx_status1 = le16_to_cpu(rx_desc->wb.status_error1); - if ((ring->flags & ICE_RX_FLAGS_RING_GCS) && rx_desc->wb.rxdid == ICE_RXDID_FLEX_NIC && (decoded.inner_prot == LIBETH_RX_PT_INNER_TCP || decoded.inner_prot == LIBETH_RX_PT_INNER_UDP || decoded.inner_prot == LIBETH_RX_PT_INNER_ICMP)) { - ice_rx_gcs(skb, rx_desc); + const struct ice_32b_rx_flex_desc_nic *desc; + __wsum wcsum; + u16 csum; + + desc = (struct ice_32b_rx_flex_desc_nic *)rx_desc; + *ip_summed = XDP_CHECKSUM_COMPLETE; + csum = (__force u16)desc->raw_csum; + wcsum = csum_unfold((__force __sum16)swab16(csum)); + *cksum = (__force u32)wcsum; + *cksum_level = 0; return; } /* check if HW has decoded the packet and checksum */ if (!(rx_status0 & BIT(ICE_RX_FLEX_DESC_STATUS0_L3L4P_S))) - return; + goto checksum_none; ipv4 = libeth_rx_pt_get_ip_ver(decoded) == LIBETH_RX_PT_OUTER_IPV4; ipv6 = libeth_rx_pt_get_ip_ver(decoded) == LIBETH_RX_PT_OUTER_IPV6; if (ipv4 && (rx_status0 & (BIT(ICE_RX_FLEX_DESC_STATUS0_XSUM_EIPE_S)))) { ring->vsi->back->hw_rx_eipe_error++; - return; + goto checksum_none; } if (ipv4 && (rx_status0 & (BIT(ICE_RX_FLEX_DESC_STATUS0_XSUM_IPE_S)))) @@ -164,14 +143,51 @@ ice_rx_csum(struct ice_rx_ring *ring, struct sk_buff *skb, * we need to bump the checksum level by 1 to reflect the fact that * we are indicating we validated the inner checksum. */ - if (decoded.tunnel_type >= LIBETH_RX_PT_TUNNEL_IP_GRENAT) - skb->csum_level = 1; - - skb->ip_summed = CHECKSUM_UNNECESSARY; + *cksum_level = decoded.tunnel_type >= LIBETH_RX_PT_TUNNEL_IP_GRENAT; + *ip_summed = XDP_CHECKSUM_UNNECESSARY; + *cksum = 0; return; checksum_fail: ring->vsi->back->hw_csum_rx_error++; +checksum_none: + *ip_summed = XDP_CHECKSUM_NONE; + *cksum_level = 0; + *cksum = 0; +} + +/** + * ice_rx_csum - Indicate in skb if checksum is good + * @ring: the ring we care about + * @skb: skb currently being received and modified + * @rx_desc: the receive descriptor + * @ptype: the packet type decoded by hardware + * + * skb->protocol must be set before this function is called + */ +static void +ice_rx_csum(struct ice_rx_ring *ring, struct sk_buff *skb, + union ice_32b_rx_flex_desc *rx_desc, u16 ptype) +{ + enum xdp_checksum ip_summed; + u8 cksum_level; + u32 cksum; + + ice_get_rx_csum(rx_desc, ptype, ring, &ip_summed, &cksum, + &cksum_level); + switch (ip_summed) { + case XDP_CHECKSUM_UNNECESSARY: + skb->ip_summed = CHECKSUM_UNNECESSARY; + skb->csum_level = cksum_level; + break; + case XDP_CHECKSUM_COMPLETE: + skb->ip_summed = CHECKSUM_COMPLETE; + skb->csum = (__force __wsum)cksum; + break; + default: + skb->ip_summed = CHECKSUM_NONE; + break; + } } /** @@ -566,6 +582,28 @@ static int ice_xdp_rx_hash(const struct xdp_md *ctx, u32 *hash, return 0; } +/** + * ice_xdp_rx_checksum - RX checksum XDP hint handler + * @ctx: XDP buff pointer + * @ip_summed: RX checksum result destination address + * @cksum: RX checksum value destination address + * @cksum_level: RX checksum level value destination address + */ +static int ice_xdp_rx_checksum(const struct xdp_md *ctx, + enum xdp_checksum *ip_summed, + u32 *cksum, u8 *cksum_level) +{ + const struct libeth_xdp_buff *xdp_ext = (void *)ctx; + const union ice_32b_rx_flex_desc *rx_desc = xdp_ext->desc; + struct ice_rx_ring *ring; + + ring = libeth_xdp_buff_to_rq(xdp_ext, typeof(*ring), xdp_rxq); + ice_get_rx_csum(rx_desc, ice_get_ptype(rx_desc), ring, ip_summed, + cksum, cksum_level); + + return 0; +} + /** * ice_xdp_rx_vlan_tag - VLAN tag XDP hint handler * @ctx: XDP buff pointer @@ -598,4 +636,5 @@ const struct xdp_metadata_ops ice_xdp_md_ops = { .xmo_rx_timestamp = ice_xdp_rx_hw_ts, .xmo_rx_hash = ice_xdp_rx_hash, .xmo_rx_vlan_tag = ice_xdp_rx_vlan_tag, + .xmo_rx_checksum = ice_xdp_rx_checksum, }; -- 2.55.0