From: Daniil Iskhakov <dish@amicon.ru>
To: Jian Shen <shenjian15@huawei.com>
Cc: Daniil Agalakov <ade@amicon.ru>,
Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
"Daniil Iskhakov" <dish@amicon.ru>, <netdev@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <rrv@amicon.ru>,
<lvc-project@linuxtesting.org>
Subject: [PATCH net-next v2] net: hns: use u32 for register offset in RCB TX coalescing
Date: Wed, 15 Jul 2026 15:58:48 +0300 [thread overview]
Message-ID: <20260715125856.19346-1-dish@amicon.ru> (raw)
From: Daniil Agalakov <ade@amicon.ru>
In both hns_rcb_get_tx_coalesced_frames() and
hns_rcb_set_tx_coalesced_frames(), the local variable reg holds a
register offset passed to dsaf_read_dev() or dsaf_write_dev().
Register offsets on this hardware are 32-bit values. Use u32 for reg
to match the register access interfaces and avoid implying that
64-bit offsets are supported.
Found by Linux Verification Center (linuxtesting.org) with SVACE.
Signed-off-by: Daniil Agalakov <ade@amicon.ru>
Signed-off-by: Daniil Iskhakov <dish@amicon.ru>
---
This is an unchanged resend of v1, which missed the previous net-next
development cycle.
Changes in v2:
- no code changes
- reword the commit message
- add my Signed-off-by tag
- rebase onto the current net-next tree
v1: https://lore.kernel.org/all/20260420144047.2846673-1-ade@amicon.ru/
drivers/net/ethernet/hisilicon/hns/hns_dsaf_rcb.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/ethernet/hisilicon/hns/hns_dsaf_rcb.c b/drivers/net/ethernet/hisilicon/hns/hns_dsaf_rcb.c
index 635b3a95dd82..3c4e4e8ca140 100644
--- a/drivers/net/ethernet/hisilicon/hns/hns_dsaf_rcb.c
+++ b/drivers/net/ethernet/hisilicon/hns/hns_dsaf_rcb.c
@@ -563,7 +563,7 @@ u32 hns_rcb_get_rx_coalesced_frames(
u32 hns_rcb_get_tx_coalesced_frames(
struct rcb_common_cb *rcb_common, u32 port_idx)
{
- u64 reg;
+ u32 reg;
reg = RCB_CFG_PKTLINE_REG + (port_idx + HNS_RCB_TX_PKTLINE_OFFSET) * 4;
return dsaf_read_dev(rcb_common, reg);
@@ -634,7 +634,7 @@ int hns_rcb_set_tx_coalesced_frames(
{
u32 old_waterline =
hns_rcb_get_tx_coalesced_frames(rcb_common, port_idx);
- u64 reg;
+ u32 reg;
if (coalesced_frames == old_waterline)
return 0;
base-commit: f6f3b36c15ed44de1fbb44e645e4fae8c4a4453e
--
2.43.0
next reply other threads:[~2026-07-15 13:13 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-15 12:58 Daniil Iskhakov [this message]
2026-07-24 22:40 ` [PATCH net-next v2] net: hns: use u32 for register offset in RCB TX coalescing patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260715125856.19346-1-dish@amicon.ru \
--to=dish@amicon.ru \
--cc=ade@amicon.ru \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lvc-project@linuxtesting.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=rrv@amicon.ru \
--cc=shenjian15@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox