From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out-184.mta0.migadu.com (out-184.mta0.migadu.com [91.218.175.184]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D2C5943F0AB for ; Fri, 17 Jul 2026 02:23:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=91.218.175.184 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784255017; cv=none; b=YIJuLKdX0dWyG5+zPAMdgugUHLQYiK99ilmRAKy4jlCs+1eqx3fPo7mqtULjT5iISY/PCE5qIhiSPSlBTSTL99SG33EjVTgKdsuya4zUb5jlO2rAhE70KiruEcaJ6JhvEc7DKoiNyTJUeaNQc5suLQyuv6JldBjCp+0/emnqTIA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784255017; c=relaxed/simple; bh=jrVXpX+QjS979JWG2YI9q80Xy/kzoqYHHUu4KOFhl4k=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=rAzlpH0BQr/YcVpXN2LDqKwCnTSBPqpQ7aW8Fo/GM9pggx0ycPXtaExd2r2v8QD/qKlpFMUGzgzxS7ssMNCUZh0pRq1iyYIX3yQ+E+UIp0btyk/XYaaweRwUoYiLYUsjU1d9dXaaB1SzUB1nJrQYJ/gEydislG6pttJjzo8lkng= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=fZE2HN0A; arc=none smtp.client-ip=91.218.175.184 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="fZE2HN0A" X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1784255012; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=a3JqH5R6aAe2D3XZtgdrEzInTdqObFpNQmvDf5kqSx0=; b=fZE2HN0AXFnIX6zXdr5iF/QYuWVyQHLknV56DlJmgswEISfHL6OEENaUO0iF3JjWJNGn6g jKgqlU2HoHyJZRGwYwF0wIsL5CizeeOLy/JJ8YA4/7/4bTaKol72aK76WqgMQXL9mzUF1O Cn8cExAPODYUR1svwU9jKd2iJzqt+x8= From: Chenguang Zhao To: nbd@nbd.name, lorenzo@kernel.org, andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, matthias.bgg@gmail.com, angelogioacchino.delregno@collabora.com Cc: netdev@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-arm-kernel@lists.infradead.org, chenguang.zhao@linux.dev, Chenguang Zhao Subject: [PATCH net] net: ethernet: mtk_eth_soc: pass eth to mtk_handle_irq_rx in poll_controller Date: Fri, 17 Jul 2026 10:23:39 +0800 Message-Id: <20260717022339.301914-1-chenguang.zhao@linux.dev> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Migadu-Flow: FLOW_OUT From: Chenguang Zhao mtk_handle_irq_rx expects a struct mtk_eth * (matching the request_irq cookie), but mtk_poll_controller incorrectly passed the net_device *. Calling ndo_poll_controller with CONFIG_NET_POLL_CONTROLLER enabled would then crash. --- drivers/net/ethernet/mediatek/mtk_eth_soc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/mediatek/mtk_eth_soc.c b/drivers/net/ethernet/mediatek/mtk_eth_soc.c index 5d291e50a47b..351444fb4871 100644 --- a/drivers/net/ethernet/mediatek/mtk_eth_soc.c +++ b/drivers/net/ethernet/mediatek/mtk_eth_soc.c @@ -3467,7 +3467,7 @@ static void mtk_poll_controller(struct net_device *dev) mtk_tx_irq_disable(eth, MTK_TX_DONE_INT); mtk_rx_irq_disable(eth, eth->soc->rx.irq_done_mask); - mtk_handle_irq_rx(eth->irq[MTK_FE_IRQ_RX], dev); + mtk_handle_irq_rx(eth->irq[MTK_FE_IRQ_RX], eth); mtk_tx_irq_enable(eth, MTK_TX_DONE_INT); mtk_rx_irq_enable(eth, eth->soc->rx.irq_done_mask); } -- 2.25.1