From: Jiaxing Hu <gahing@gahingwoo.com>
To: maxime.chevallier@bootlin.com
Cc: andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com,
kuba@kernel.org, pabeni@redhat.com, heiko@sntech.de,
netdev@vger.kernel.org, linux-rockchip@lists.infradead.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next] net: stmmac: dwmac-rk: enable the reference clock for output mode
Date: Fri, 17 Jul 2026 19:00:11 +1200 [thread overview]
Message-ID: <20260717070011.2629800-1-gahing@gahingwoo.com> (raw)
In-Reply-To: <a1e6cf0a-a243-4739-8563-be385add37b2@bootlin.com>
Hi Maxime,
> So the statement "For RGMII, it must be input [...]" is now incorrect :
> - it can be output for RGMII
> - it will be 25Hz if set to output, from what I get from the commit log.
>
> Can you update it ?
Done in v2, added as patch 1:
https://lore.kernel.org/all/20260717065933.2629501-1-gahing@gahingwoo.com/
It rewords clock_in_out so that for RGMII, "output" means the SoC drives
a 25 MHz reference out to a crystal-less PHY. The driver change is now
patch 2 of the same series.
Thanks,
Jiaxing
next prev parent reply other threads:[~2026-07-17 7:00 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-16 6:56 [PATCH net-next] net: stmmac: dwmac-rk: enable the reference clock for output mode Jiaxing Hu
2026-07-16 7:30 ` Maxime Chevallier
2026-07-17 7:00 ` Jiaxing Hu [this message]
2026-07-16 13:21 ` Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260717070011.2629800-1-gahing@gahingwoo.com \
--to=gahing@gahingwoo.com \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=heiko@sntech.de \
--cc=kuba@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=maxime.chevallier@bootlin.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox