From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-yw1-f179.google.com (mail-yw1-f179.google.com [209.85.128.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8F43B2C21DF for ; Sat, 18 Jul 2026 18:34:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.179 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784399664; cv=none; b=BnyMnlCB+xiz4w4asvZZdrGw3EqgZ4Wfg7BYfSMXDMRRqY16FPyLUpg0kCp3QthT2bSwk5lgUwBvZsUsPClkt6nvCK7bcNUnr4zFDBZSO3bKrli+KpQO0FOj4d9oBUNf022oMlXDZHjCvxp6I/fTc8yFE2gmuzz1HuiMGIAJemA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784399664; c=relaxed/simple; bh=g7Mj5txpJ8vBF81drD5/4LBlaLwjK/+72i4WalIkhew=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=gOh4tnQH5bcyMxmgnCd4hM4YaWLOkbmqsClWX2kWh3mIGJXPmLtiHhpQu2G+C7Cz6QRADLaviAUANSupWzU0MRGqcZM7krs/Rt42kiFbM6fuZ4OgbYxB3Cjxnv/wmSTx5CFwk9SaO4HeXRm3pZJGl/Fqqfh3rjzS/dfIW8eXgWc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=QJC2Ubwq; arc=none smtp.client-ip=209.85.128.179 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="QJC2Ubwq" Received: by mail-yw1-f179.google.com with SMTP id 00721157ae682-81e9d8f3289so65996727b3.1 for ; Sat, 18 Jul 2026 11:34:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1784399662; x=1785004462; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=KIMgeRzIphzaOxlDnYtmNHPxi4S7Tx1b1pmPrwhcJMs=; b=QJC2UbwqDWeeUQAfHhUVfgKovfQvbXTJ8L/T4p1f+VDNk/IMokHoGnt6ya7PAQDZpT Yh58dFG++lpwG9qEkIH+voTfgyhqK1pV71WMkIfm3G6qaGdRtp2q6Tf0m5ODzSL2iUWq b7+bQl2hjwriZN6l8w+OEzR2nH/H9QcicnyoJwV6auO27K5pBSKH8F4LaeXeZ2F5d0Ei 29dQCRdpruJPPD+2B6QiCZn4x48okIL9El5Z8Eq/tF9JJyCwXt3yW0c/vWXo5LYVPfi7 D2BTxXkk19d7ChgTdHvS9cFWFFQHS+Wtk8zdEipdkdD/d/CxauXUUFDNQGljJxOKYdit 5LVA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784399662; x=1785004462; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=KIMgeRzIphzaOxlDnYtmNHPxi4S7Tx1b1pmPrwhcJMs=; b=CvR+9um+8AQhJ5rcSoVky1D9Z+1+dsRGtEtkqtvTNi/uNJ2RghSj2qV/EkKFaWI+3v G6NSmMugS+M6XC/t32zT+0sC3XPMlZcZ6HFjKsXKl8aujpT+jvgcRa2xBel6r4QP36FA mcgA9ycMb1Glu9hXLtSA52Qha8/nqZ5hHxRspQI/MaG3LlDAQC1cEBU/UQy80w+fsus2 FH0KTBXTWDIanbP01HbCSvoAEkjEBZDVCdrIi4aRJNPDAMnwVuE64O2mc/kXwRhEwxR1 H4WQdGelENW9Vo4YydqJe8N9JlEWd6r7JRJ8rBYT4sVpLEdsMJktZOqBBvwpENKXV7Ud 5FWQ== X-Forwarded-Encrypted: i=1; AHgh+RoYWjrB5l8z8N4x0M/XU5GaVivBuNW0hV+caCpTyIkFt6iOrn6ITY+yH1hWEKPmZXyYZsDutLE=@vger.kernel.org X-Gm-Message-State: AOJu0YzStAcfiINNQ/c70EFuMHpaDEend40JaRVPrqGBtMQNPeH4DmLB Q6l3daTa4hnB3xRYxxwRCEfcBDLi6KFNkQuCPvBvegNUEduursyNPMvG X-Gm-Gg: AfdE7clEBenM4OW47hc2UqixR5yN8bcfBe5rXdge6UX8EV6vGQx5t6Fq/3Lvn4Y9FgW CcUQ8kPSMYYhlfDiEUEPpZ0JUAIe2SIYy7QqQTK01IoATTAnw1zA5T87H2laqOkQnfGjdq5A7e+ 37JNX1r3c5RV0rFu/t9dtr+bGSy27R6vmYWfMbBMOScHI9BpckIifNkVasEtxzSLC8ZfYTzL4U5 eoUqwRT/+GsZ+fFNT1GA5nRIRL/+XOjbFZeejjjwk1E65k7i5Od6aKuG4NJLeuLOM+zBPtSfsy0 vzHkrc8xryg9xwxzn6Sah21+TKgiTNXek8cCCZMVPqFdCAGmGs7LJtTN5aemPbGaaieLgssrhPo p1OK2geCd9m73sStcSNXxqWiOES0jNWfD1mR+uXeIO5buTSEuRf5QRH76f/0Fv2GJvruviNhnpu QsDDuSBiE7wxXOqmqm+kc= X-Received: by 2002:a05:690c:d8d:b0:81e:cda5:5149 with SMTP id 00721157ae682-81ef252c29fmr25092147b3.28.1784399662373; Sat, 18 Jul 2026 11:34:22 -0700 (PDT) Received: from LAPTOP-83ECOPAB.localdomain ([136.55.173.105]) by smtp.gmail.com with ESMTPSA id 00721157ae682-81ef42eb72asm33671137b3.47.2026.07.18.11.34.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 18 Jul 2026 11:34:21 -0700 (PDT) From: "Cen Zhang (Microsoft)" To: achender@kernel.org Cc: davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, horms@kernel.org, netdev@vger.kernel.org, linux-rdma@vger.kernel.org, rds-devel@oss.oracle.com, linux-kernel@vger.kernel.org, AutonomousCodeSecurity@microsoft.com, tgopinath@linux.microsoft.com, kys@microsoft.com, blbllhy@gmail.com Subject: [PATCH net] rds: tcp: unregister sysctl before tearing down listen socket Date: Sat, 18 Jul 2026 14:34:20 -0400 Message-ID: <20260718183420.13301-1-blbllhy@gmail.com> X-Mailer: git-send-email 2.53.0 Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit rds_tcp_exit_net() frees the per-netns RDS TCP listen socket via rds_tcp_kill_sock() before unregistering the per-netns sysctl table. Since rds_tcp_skbuf_handler() derives the netns from rtn->rds_tcp_listen_sock->sk, a concurrent sysctl write can race with netns teardown and dereference the freed socket/sk. KASAN reports the race as: BUG: KASAN: slab-use-after-free in rds_tcp_skbuf_handler+0x2aa/0x2e0 rds_tcp_skbuf_handler net/rds/tcp.c:721 proc_sys_call_handler fs/proc/proc_sysctl.c vfs_write fs/read_write.c __x64_sys_pwrite64 fs/read_write.c Fix this by unregistering the RDS TCP sysctl table before calling rds_tcp_kill_sock(). unregister_net_sysctl_table() prevents new sysctl handlers from starting and waits for in-flight handlers to finish, so the listen socket can then be released safely. Fixes: 7f5611cbc487 ("rds: sysctl: rds_tcp_{rcv,snd}buf: avoid using current->nsproxy") Reported-by: AutonomousCodeSecurity@microsoft.com Signed-off-by: Cen Zhang (Microsoft) --- net/rds/tcp.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/net/rds/tcp.c b/net/rds/tcp.c index a1de114d5e2e..453d4077a85e 100644 --- a/net/rds/tcp.c +++ b/net/rds/tcp.c @@ -655,13 +655,13 @@ static void __net_exit rds_tcp_exit_net(struct net *net) { struct rds_tcp_net *rtn = net_generic(net, rds_tcp_netid); - rds_tcp_kill_sock(net); - if (rtn->rds_tcp_sysctl) unregister_net_sysctl_table(rtn->rds_tcp_sysctl); if (net != &init_net) kfree(rtn->ctl_table); + + rds_tcp_kill_sock(net); } static struct pernet_operations rds_tcp_net_ops = { -- 2.53.0