From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx3.wp.pl (mx3.wp.pl [212.77.101.10]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 55956378832 for ; Sun, 19 Jul 2026 09:05:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=212.77.101.10 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784451930; cv=none; b=ujoE8lAhAOkkDOdsKCGeE+rLpLFhkLGpxiEnLvE0NmgAK2U4rTeVvRjQvCQtExbHOPN+8iOebxI6BmNJCLMVzJh80OXnyjKiBy2ZFnWNYgLKvaa0L4WUqZzoLVTIuGbGl6ty8zvy+qEHcA/u9f4lwNKnf/In63P2GLc7npb7gWk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784451930; c=relaxed/simple; bh=zJ3h+rGrWEZ2ouTw0FS2SbC51xBqkP8svJg/wh8zXZc=; h=From:To:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=hsVNqQ3OXJLeqVk+GBh4KzAwFaysCHeXkObCZJk0M7GiriIivND6Z0SvlIK0Xul7AudgntgTf4UHDEXVw07pjigRo5n7hr7861ML0KY5o1Q7YUPndOG4SpgK15DeyX6pjAeHVt3rwWmH0U0n6zDMeD3eQOiQyDLIl7CfVDNlueE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=wp.pl; spf=pass smtp.mailfrom=wp.pl; dkim=pass (2048-bit key) header.d=wp.pl header.i=@wp.pl header.b=VN9/HtFh; arc=none smtp.client-ip=212.77.101.10 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=wp.pl Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=wp.pl Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=wp.pl header.i=@wp.pl header.b="VN9/HtFh" Received: (wp-smtpd smtp.wp.pl 22018 invoked from network); 19 Jul 2026 11:05:14 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=wp.pl; s=20241105; t=1784451914; bh=mEBxu3em72tH5NZLQ+i31XYbSLe5UVhLRdd7eOLBkS8=; h=From:To:Subject; b=VN9/HtFhrdzyhljVtPfYBEXdHvIKI4Zb1sho0t5rm6h61IFpf4xu6qZxioy1vQ8jF xQRjcKuTgFzr34qhn9WwQlHH1Wo7GnY8fSM6p/rScT+O0Q3vk1jugcVAy8rt5SuS5V zjIbzZBm+ClrUMBM+c/EqmZxStnaig+OJQfO1S/rf1I7aZR7nhwLDJLB4a4N5q23uU ddzoWlXoDT1yy0zMqrWdWu10VBE8KIIqM/edQ822Xr/I/2wIS5D0KkTDOpoFkaGdhw jIG8RGZ8WxQwBUMlJp9fkkMwZ0ZaFVsERKee1vw7g0LpP6dLYe15ffrCzTRaIVxsz2 PTKXhrY4aVGlQ== Received: from 83.24.141.3.ipv4.supernova.orange.pl (HELO abajkowski.lan) (olek2@wp.pl@[83.24.141.3]) (envelope-sender ) by smtp.wp.pl (WP-SMTPD) with TLS_AES_256_GCM_SHA384 encrypted SMTP for ; 19 Jul 2026 11:05:14 +0200 From: Aleksander Jan Bajkowski To: danieller@nvidia.com, olek2@wp.pl, mkubecek@suse.cz, andrew@lunn.ch, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, jbe@pengutronix.de, netdev@vger.kernel.org Subject: [PATCH ethtool-next v3 3/3] qsfp: print all compliance codes Date: Sun, 19 Jul 2026 11:00:37 +0200 Message-ID: <20260719090458.659332-3-olek2@wp.pl> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260719090458.659332-1-olek2@wp.pl> References: <20260719090458.659332-1-olek2@wp.pl> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-WP-MailID: cd815d4e4ef7ccc16b252f4c116923d9 X-WP-AV: skaner antywirusowy Poczty Wirtualnej Polski X-WP-SPAM: NO 0000001 [8QJR] QSFP modules implement multiple compliance codes. This is common for dual-rate modules. Before the `json` option was introduced, all compliance codes were displayed. Currently, only the last code is displayed. This commit fixes that bug. Compliance codes are represented as array. Fixes: 4071862f58d8 ("sfpid: Add JSON output handling to --module-info in SFF8079 modules") Signed-off-by: Aleksander Jan Bajkowski --- Changes in v3: - add patch to series --- qsfp.c | 264 +++++++++++++++++++++++++++++---------------------------- 1 file changed, 134 insertions(+), 130 deletions(-) diff --git a/qsfp.c b/qsfp.c index c82a3de..113663a 100644 --- a/qsfp.c +++ b/qsfp.c @@ -182,7 +182,6 @@ static void sff8636_show_connector(const struct sff8636_memory_map *map) static void sff8636_show_transceiver(const struct sff8636_memory_map *map) { static const char *pfx = "Transceiver type"; - char value[140] = ""; if (is_json_context()) { open_json_array("transceiver_codes", ""); @@ -217,226 +216,230 @@ static void sff8636_show_transceiver(const struct sff8636_memory_map *map) map->page_00h[SFF8636_FC_SPEED_OFFSET]); } + if (is_json_context()) + open_json_array("transceiver_type", ""); + /* 10G/40G Ethernet Compliance Codes */ if (map->page_00h[SFF8636_ETHERNET_COMP_OFFSET] & SFF8636_ETHERNET_10G_LRM) - sprintf(value, "%s", "10G Ethernet: 10G Base-LRM"); + module_print_any_array_string_entry(pfx, "10G Ethernet: 10G Base-LRM"); if (map->page_00h[SFF8636_ETHERNET_COMP_OFFSET] & SFF8636_ETHERNET_10G_LR) - sprintf(value, "%s", "10G Ethernet: 10G Base-LR"); + module_print_any_array_string_entry(pfx, "10G Ethernet: 10G Base-LR"); if (map->page_00h[SFF8636_ETHERNET_COMP_OFFSET] & SFF8636_ETHERNET_10G_SR) - sprintf(value, "%s", "10G Ethernet: 10G Base-SR"); + module_print_any_array_string_entry(pfx, "10G Ethernet: 10G Base-SR"); if (map->page_00h[SFF8636_ETHERNET_COMP_OFFSET] & SFF8636_ETHERNET_40G_CR4) - sprintf(value, "%s", "40G Ethernet: 40G Base-CR4"); + module_print_any_array_string_entry(pfx, "40G Ethernet: 40G Base-CR4"); if (map->page_00h[SFF8636_ETHERNET_COMP_OFFSET] & SFF8636_ETHERNET_40G_SR4) - sprintf(value, "%s", "40G Ethernet: 40G Base-SR4"); + module_print_any_array_string_entry(pfx, "40G Ethernet: 40G Base-SR4"); if (map->page_00h[SFF8636_ETHERNET_COMP_OFFSET] & SFF8636_ETHERNET_40G_LR4) - sprintf(value, "%s", "40G Ethernet: 40G Base-LR4"); + module_print_any_array_string_entry(pfx, "40G Ethernet: 40G Base-LR4"); if (map->page_00h[SFF8636_ETHERNET_COMP_OFFSET] & SFF8636_ETHERNET_40G_ACTIVE) - sprintf(value, "%s", "40G Ethernet: 40G Active Cable (XLPPI)"); + module_print_any_array_string_entry(pfx, "40G Ethernet: 40G Active Cable (XLPPI)"); /* Extended Specification Compliance Codes from SFF-8024 */ if (map->page_00h[SFF8636_ETHERNET_COMP_OFFSET] & SFF8636_ETHERNET_RSRVD) { switch (map->page_00h[SFF8636_OPTION_1_OFFSET]) { case SFF8636_ETHERNET_UNSPECIFIED: - sprintf(value, "%s", "(reserved or unknown)"); + module_print_any_array_string_entry(pfx, "(reserved or unknown)"); break; case SFF8636_ETHERNET_100G_AOC: - sprintf(value, "%s", - "100G Ethernet: 100G AOC or 25GAUI C2M AOC with worst BER of 5x10^(-5)"); + module_print_any_array_string_entry(pfx, + "100G Ethernet: 100G AOC or 25GAUI C2M AOC with worst BER of 5x10^(-5)"); break; case SFF8636_ETHERNET_100G_SR4: - sprintf(value, "%s", - "100G Ethernet: 100G Base-SR4 or 25GBase-SR"); + module_print_any_array_string_entry(pfx, + "100G Ethernet: 100G Base-SR4 or 25GBase-SR"); break; case SFF8636_ETHERNET_100G_LR4: - sprintf(value, "%s", "100G Ethernet: 100G Base-LR4"); + module_print_any_array_string_entry(pfx, "100G Ethernet: 100G Base-LR4"); break; case SFF8636_ETHERNET_100G_ER4: - sprintf(value, "%s", "100G Ethernet: 100G Base-ER4"); + module_print_any_array_string_entry(pfx, "100G Ethernet: 100G Base-ER4"); break; case SFF8636_ETHERNET_100G_SR10: - sprintf(value, "%s", "100G Ethernet: 100G Base-SR10"); + module_print_any_array_string_entry(pfx, "100G Ethernet: 100G Base-SR10"); break; case SFF8636_ETHERNET_100G_CWDM4_FEC: - sprintf(value, "%s", - "100G Ethernet: 100G CWDM4 MSA with FEC"); + module_print_any_array_string_entry(pfx, + "100G Ethernet: 100G CWDM4 MSA with FEC"); break; case SFF8636_ETHERNET_100G_PSM4: - sprintf(value, "%s", - "100G Ethernet: 100G PSM4 Parallel SMF"); + module_print_any_array_string_entry(pfx, + "100G Ethernet: 100G PSM4 Parallel SMF"); break; case SFF8636_ETHERNET_100G_ACC: - sprintf(value, "%s", - "100G Ethernet: 100G ACC or 25GAUI C2M ACC with worst BER of 5x10^(-5)"); + module_print_any_array_string_entry(pfx, + "100G Ethernet: 100G ACC or 25GAUI C2M ACC with worst BER of 5x10^(-5)"); break; case SFF8636_ETHERNET_100G_CWDM4_NO_FEC: - sprintf(value, "%s", - "100G Ethernet: 100G CWDM4 MSA without FEC"); + module_print_any_array_string_entry(pfx, + "100G Ethernet: 100G CWDM4 MSA without FEC"); break; case SFF8636_ETHERNET_100G_RSVD1: - sprintf(value, "%s", "(reserved or unknown)"); + module_print_any_array_string_entry(pfx, "(reserved or unknown)"); break; case SFF8636_ETHERNET_100G_CR4: - sprintf(value, "%s", - "100G Ethernet: 100G Base-CR4 or 25G Base-CR CA-L"); + module_print_any_array_string_entry(pfx, + "100G Ethernet: 100G Base-CR4 or 25G Base-CR CA-L"); break; case SFF8636_ETHERNET_25G_CR_CA_S: - sprintf(value, "%s", "25G Ethernet: 25G Base-CR CA-S"); + module_print_any_array_string_entry(pfx, "25G Ethernet: 25G Base-CR CA-S"); break; case SFF8636_ETHERNET_25G_CR_CA_N: - sprintf(value, "%s", "25G Ethernet: 25G Base-CR CA-N"); + module_print_any_array_string_entry(pfx, "25G Ethernet: 25G Base-CR CA-N"); break; case SFF8636_ETHERNET_40G_ER4: - sprintf(value, "%s", "40G Ethernet: 40G Base-ER4"); + module_print_any_array_string_entry(pfx, "40G Ethernet: 40G Base-ER4"); break; case SFF8636_ETHERNET_4X10_SR: - sprintf(value, "%s", "4x10G Ethernet: 10G Base-SR"); + module_print_any_array_string_entry(pfx, "4x10G Ethernet: 10G Base-SR"); break; case SFF8636_ETHERNET_40G_PSM4: - sprintf(value, "%s", - "40G Ethernet: 40G PSM4 Parallel SMF"); + module_print_any_array_string_entry(pfx, + "40G Ethernet: 40G PSM4 Parallel SMF"); break; case SFF8636_ETHERNET_G959_P1I1_2D1: - sprintf(value, "%s", - "Ethernet: G959.1 profile P1I1-2D1 (10709 MBd, 2km, 1310nm SM)"); + module_print_any_array_string_entry(pfx, + "Ethernet: G959.1 profile P1I1-2D1 (10709 MBd, 2km, 1310nm SM)"); break; case SFF8636_ETHERNET_G959_P1S1_2D2: - sprintf(value, "%s", - "Ethernet: G959.1 profile P1S1-2D2 (10709 MBd, 40km, 1550nm SM)"); + module_print_any_array_string_entry(pfx, + "Ethernet: G959.1 profile P1S1-2D2 (10709 MBd, 40km, 1550nm SM)"); break; case SFF8636_ETHERNET_G959_P1L1_2D2: - sprintf(value, "%s", - "Ethernet: G959.1 profile P1L1-2D2 (10709 MBd, 80km, 1550nm SM)"); + module_print_any_array_string_entry(pfx, + "Ethernet: G959.1 profile P1L1-2D2 (10709 MBd, 80km, 1550nm SM)"); break; case SFF8636_ETHERNET_10GT_SFI: - sprintf(value, "%s", - "10G Ethernet: 10G Base-T with SFI electrical interface"); + module_print_any_array_string_entry(pfx, + "10G Ethernet: 10G Base-T with SFI electrical interface"); break; case SFF8636_ETHERNET_100G_CLR4: - sprintf(value, "%s", "100G Ethernet: 100G CLR4"); + module_print_any_array_string_entry(pfx, "100G Ethernet: 100G CLR4"); break; case SFF8636_ETHERNET_100G_AOC2: - sprintf(value, "%s", - "100G Ethernet: 100G AOC or 25GAUI C2M AOC with worst BER of 10^(-12)"); + module_print_any_array_string_entry(pfx, + "100G Ethernet: 100G AOC or 25GAUI C2M AOC with worst BER of 10^(-12)"); break; case SFF8636_ETHERNET_100G_ACC2: - sprintf(value, "%s", - "100G Ethernet: 100G ACC or 25GAUI C2M ACC with worst BER of 10^(-12)"); + module_print_any_array_string_entry(pfx, + "100G Ethernet: 100G ACC or 25GAUI C2M ACC with worst BER of 10^(-12)"); break; case SFF8636_ETHERNET_100GE_DWDM2: - sprintf(value, "%s", - "100GE-DWDM2 (DWDM transceiver using 2 wavelengths on a 1550 nm DWDM grid with a reach up to 80 km)"); + module_print_any_array_string_entry(pfx, + "100GE-DWDM2 (DWDM transceiver using 2 wavelengths on a 1550 nm DWDM grid with a reach up to 80 km)"); break; case SFF8636_ETHERNET_100G_1550NM_WDM: - sprintf(value, "%s", "100G 1550nm WDM (4 wavelengths)"); + module_print_any_array_string_entry(pfx, "100G 1550nm WDM (4 wavelengths)"); break; case SFF8636_ETHERNET_10G_BASET_SR: - sprintf(value, "%s", - "10GBASE-T Short Reach (30 meters)"); + module_print_any_array_string_entry(pfx, + "10GBASE-T Short Reach (30 meters)"); break; case SFF8636_ETHERNET_5G_BASET: - sprintf(value, "%s", "5GBASE-T"); + module_print_any_array_string_entry(pfx, "5GBASE-T"); break; case SFF8636_ETHERNET_2HALFG_BASET: - sprintf(value, "%s", "2.5GBASE-T"); + module_print_any_array_string_entry(pfx, "2.5GBASE-T"); break; case SFF8636_ETHERNET_40G_SWDM4: - sprintf(value, "%s", "40G SWDM4"); + module_print_any_array_string_entry(pfx, "40G SWDM4"); break; case SFF8636_ETHERNET_100G_SWDM4: - sprintf(value, "%s", "100G SWDM4"); + module_print_any_array_string_entry(pfx, "100G SWDM4"); break; case SFF8636_ETHERNET_100G_PAM4_BIDI: - sprintf(value, "%s", "100G PAM4 BiDi"); + module_print_any_array_string_entry(pfx, "100G PAM4 BiDi"); break; case SFF8636_ETHERNET_4WDM10_MSA: - sprintf(value, "%s", - "4WDM-10 MSA (10km version of 100G CWDM4 with same RS(528,514) FEC in host system)"); + module_print_any_array_string_entry(pfx, + "4WDM-10 MSA (10km version of 100G CWDM4 with same RS(528,514) FEC in host system)"); break; case SFF8636_ETHERNET_4WDM20_MSA: - sprintf(value, "%s", "4WDM-20 MSA (20km version of 100GBASE-LR4 with RS(528,514) FEC in host system)"); + module_print_any_array_string_entry(pfx, + "4WDM-20 MSA (20km version of 100GBASE-LR4 with RS(528,514) FEC in host system)"); break; case SFF8636_ETHERNET_4WDM40_MSA: - sprintf(value, "%s", - "4WDM-40 MSA (40km reach with APD receiver and RS(528,514) FEC in host system)"); + module_print_any_array_string_entry(pfx, + "4WDM-40 MSA (40km reach with APD receiver and RS(528,514) FEC in host system)"); break; case SFF8636_ETHERNET_100G_DR: - sprintf(value, "%s", - "100GBASE-DR (clause 140), CAUI-4 (no FEC)"); + module_print_any_array_string_entry(pfx, + "100GBASE-DR (clause 140), CAUI-4 (no FEC)"); break; case SFF8636_ETHERNET_100G_FR_NOFEC: - sprintf(value, "%s", - "100G-FR or 100GBASE-FR1 (clause 140), CAUI-4 (no FEC)"); + module_print_any_array_string_entry(pfx, + "100G-FR or 100GBASE-FR1 (clause 140), CAUI-4 (no FEC)"); break; case SFF8636_ETHERNET_100G_LR_NOFEC: - sprintf(value, "%s", - "100G-LR or 100GBASE-LR1 (clause 140), CAUI-4 (no FEC)"); + module_print_any_array_string_entry(pfx, + "100G-LR or 100GBASE-LR1 (clause 140), CAUI-4 (no FEC)"); break; case SFF8636_ETHERNET_200G_ACC1: - sprintf(value, "%s", - "Active Copper Cable with 50GAUI, 100GAUI-2 or 200GAUI-4 C2M. Providing a worst BER of 10-6 or below"); + module_print_any_array_string_entry(pfx, + "Active Copper Cable with 50GAUI, 100GAUI-2 or 200GAUI-4 C2M. Providing a worst BER of 10-6 or below"); break; case SFF8636_ETHERNET_200G_AOC1: - sprintf(value, "%s", - "Active Optical Cable with 50GAUI, 100GAUI-2 or 200GAUI-4 C2M. Providing a worst BER of 10-6 or below"); + module_print_any_array_string_entry(pfx, + "Active Optical Cable with 50GAUI, 100GAUI-2 or 200GAUI-4 C2M. Providing a worst BER of 10-6 or below"); break; case SFF8636_ETHERNET_200G_ACC2: - sprintf(value, "%s", - "Active Copper Cable with 50GAUI, 100GAUI-2 or 200GAUI-4 C2M. Providing a worst BER of 2.6x10-4 for ACC, 10-5 for AUI, or below"); + module_print_any_array_string_entry(pfx, + "Active Copper Cable with 50GAUI, 100GAUI-2 or 200GAUI-4 C2M. Providing a worst BER of 2.6x10-4 for ACC, 10-5 for AUI, or below"); break; case SFF8636_ETHERNET_200G_A0C2: - sprintf(value, "%s", - "Active Optical Cable with 50GAUI, 100GAUI-2 or 200GAUI-4 C2M. Providing a worst BER of 2.6x10-4 for ACC, 10-5 for AUI, or below"); + module_print_any_array_string_entry(pfx, + "Active Optical Cable with 50GAUI, 100GAUI-2 or 200GAUI-4 C2M. Providing a worst BER of 2.6x10-4 for ACC, 10-5 for AUI, or below"); break; case SFF8636_ETHERNET_200G_CR4: - sprintf(value, "%s", - "50GBASE-CR, 100GBASE-CR2, or 200GBASE-CR4"); + module_print_any_array_string_entry(pfx, + "50GBASE-CR, 100GBASE-CR2, or 200GBASE-CR4"); break; case SFF8636_ETHERNET_200G_SR4: - sprintf(value, "%s", - "50GBASE-SR, 100GBASE-SR2, or 200GBASE-SR4"); + module_print_any_array_string_entry(pfx, + "50GBASE-SR, 100GBASE-SR2, or 200GBASE-SR4"); break; case SFF8636_ETHERNET_200G_DR4: - sprintf(value, "%s", "50GBASE-FR or 200GBASE-DR4"); + module_print_any_array_string_entry(pfx, "50GBASE-FR or 200GBASE-DR4"); break; case SFF8636_ETHERNET_200G_FR4: - sprintf(value, "%s", "200GBASE-FR4"); + module_print_any_array_string_entry(pfx, "200GBASE-FR4"); break; case SFF8636_ETHERNET_200G_PSM4: - sprintf(value, "%s", "200G 1550 nm PSM4"); + module_print_any_array_string_entry(pfx, "200G 1550 nm PSM4"); break; case SFF8636_ETHERNET_50G_LR: - sprintf(value, "%s", "50GBASE-LR"); + module_print_any_array_string_entry(pfx, "50GBASE-LR"); break; case SFF8636_ETHERNET_200G_LR4: - sprintf(value, "%s", "200GBASE-LR4"); + module_print_any_array_string_entry(pfx, "200GBASE-LR4"); break; case SFF8636_ETHERNET_64G_EA: - sprintf(value, "%s", "64GFC EA"); + module_print_any_array_string_entry(pfx, "64GFC EA"); break; case SFF8636_ETHERNET_64G_SW: - sprintf(value, "%s", "64GFC SW"); + module_print_any_array_string_entry(pfx, "64GFC SW"); break; case SFF8636_ETHERNET_64G_LW: - sprintf(value, "%s", "64GFC LW"); + module_print_any_array_string_entry(pfx, "64GFC LW"); break; case SFF8636_ETHERNET_128FC_EA: - sprintf(value, "%s", "128GFC EA"); + module_print_any_array_string_entry(pfx, "128GFC EA"); break; case SFF8636_ETHERNET_128FC_SW: - sprintf(value, "%s", "128GFC SW"); + module_print_any_array_string_entry(pfx, "128GFC SW"); break; case SFF8636_ETHERNET_128FC_LW: - sprintf(value, "%s", "128GFC LW"); + module_print_any_array_string_entry(pfx, "128GFC LW"); break; default: - sprintf(value, "%s", "(reserved or unknown)"); + module_print_any_array_string_entry(pfx, "(reserved or unknown)"); break; } } @@ -444,104 +447,105 @@ static void sff8636_show_transceiver(const struct sff8636_memory_map *map) /* SONET Compliance Codes */ if (map->page_00h[SFF8636_SONET_COMP_OFFSET] & (SFF8636_SONET_40G_OTN)) - sprintf(value, "%s", "40G OTN (OTU3B/OTU3C)"); + module_print_any_array_string_entry(pfx, "40G OTN (OTU3B/OTU3C)"); if (map->page_00h[SFF8636_SONET_COMP_OFFSET] & (SFF8636_SONET_OC48_LR)) - sprintf(value, "%s", "SONET: OC-48, long reach"); + module_print_any_array_string_entry(pfx, "SONET: OC-48, long reach"); if (map->page_00h[SFF8636_SONET_COMP_OFFSET] & (SFF8636_SONET_OC48_IR)) - sprintf(value, "%s", "SONET: OC-48, intermediate reach"); + module_print_any_array_string_entry(pfx, "SONET: OC-48, intermediate reach"); if (map->page_00h[SFF8636_SONET_COMP_OFFSET] & (SFF8636_SONET_OC48_SR)) - sprintf(value, "%s", "SONET: OC-48, short reach"); + module_print_any_array_string_entry(pfx, "SONET: OC-48, short reach"); /* SAS/SATA Compliance Codes */ if (map->page_00h[SFF8636_SAS_COMP_OFFSET] & (SFF8636_SAS_24G)) - sprintf(value, "%s", "SAS 24.0G"); + module_print_any_array_string_entry(pfx, "SAS 24.0G"); if (map->page_00h[SFF8636_SAS_COMP_OFFSET] & (SFF8636_SAS_12G)) - sprintf(value, "%s", "SAS 12.0G"); + module_print_any_array_string_entry(pfx, "SAS 12.0G"); if (map->page_00h[SFF8636_SAS_COMP_OFFSET] & (SFF8636_SAS_6G)) - sprintf(value, "%s", "SAS 6.0G"); + module_print_any_array_string_entry(pfx, "SAS 6.0G"); if (map->page_00h[SFF8636_SAS_COMP_OFFSET] & (SFF8636_SAS_3G)) - sprintf(value, "%s", "SAS 3.0G"); + module_print_any_array_string_entry(pfx, "SAS 3.0G"); /* Ethernet Compliance Codes */ if (map->page_00h[SFF8636_GIGE_COMP_OFFSET] & SFF8636_GIGE_1000_BASE_T) - sprintf(value, "%s", "Ethernet: 1000BASE-T"); + module_print_any_array_string_entry(pfx, "Ethernet: 1000BASE-T"); if (map->page_00h[SFF8636_GIGE_COMP_OFFSET] & SFF8636_GIGE_1000_BASE_CX) - sprintf(value, "%s", "Ethernet: 1000BASE-CX"); + module_print_any_array_string_entry(pfx, "Ethernet: 1000BASE-CX"); if (map->page_00h[SFF8636_GIGE_COMP_OFFSET] & SFF8636_GIGE_1000_BASE_LX) - sprintf(value, "%s", "Ethernet: 1000BASE-LX"); + module_print_any_array_string_entry(pfx, "Ethernet: 1000BASE-LX"); if (map->page_00h[SFF8636_GIGE_COMP_OFFSET] & SFF8636_GIGE_1000_BASE_SX) - sprintf(value, "%s", "Ethernet: 1000BASE-SX"); + module_print_any_array_string_entry(pfx, "Ethernet: 1000BASE-SX"); /* Fibre Channel link length */ if (map->page_00h[SFF8636_FC_LEN_OFFSET] & SFF8636_FC_LEN_VERY_LONG) - sprintf(value, "%s", "FC: very long distance (V)"); + module_print_any_array_string_entry(pfx, "FC: very long distance (V)"); if (map->page_00h[SFF8636_FC_LEN_OFFSET] & SFF8636_FC_LEN_SHORT) - sprintf(value, "%s", "FC: short distance (S)"); + module_print_any_array_string_entry(pfx, "FC: short distance (S)"); if (map->page_00h[SFF8636_FC_LEN_OFFSET] & SFF8636_FC_LEN_INT) - sprintf(value, "%s", "FC: intermediate distance (I)"); + module_print_any_array_string_entry(pfx, "FC: intermediate distance (I)"); if (map->page_00h[SFF8636_FC_LEN_OFFSET] & SFF8636_FC_LEN_LONG) - sprintf(value, "%s", "FC: long distance (L)"); + module_print_any_array_string_entry(pfx, "FC: long distance (L)"); if (map->page_00h[SFF8636_FC_LEN_OFFSET] & SFF8636_FC_LEN_MED) - sprintf(value, "%s", "FC: medium distance (M)"); + module_print_any_array_string_entry(pfx, "FC: medium distance (M)"); /* Fibre Channel transmitter technology */ if (map->page_00h[SFF8636_FC_LEN_OFFSET] & SFF8636_FC_TECH_LONG_LC) - sprintf(value, "%s", "FC: Longwave laser (LC)"); + module_print_any_array_string_entry(pfx, "FC: Longwave laser (LC)"); if (map->page_00h[SFF8636_FC_LEN_OFFSET] & SFF8636_FC_TECH_ELEC_INTER) - sprintf(value, "%s", "FC: Electrical inter-enclosure (EL)"); + module_print_any_array_string_entry(pfx, "FC: Electrical inter-enclosure (EL)"); if (map->page_00h[SFF8636_FC_TECH_OFFSET] & SFF8636_FC_TECH_ELEC_INTRA) - sprintf(value, "%s", "FC: Electrical intra-enclosure (EL)"); + module_print_any_array_string_entry(pfx, "FC: Electrical intra-enclosure (EL)"); if (map->page_00h[SFF8636_FC_TECH_OFFSET] & SFF8636_FC_TECH_SHORT_WO_OFC) - sprintf(value, "%s", "FC: Shortwave laser w/o OFC (SN)"); + module_print_any_array_string_entry(pfx, "FC: Shortwave laser w/o OFC (SN)"); if (map->page_00h[SFF8636_FC_TECH_OFFSET] & SFF8636_FC_TECH_SHORT_W_OFC) - sprintf(value, "%s", "FC: Shortwave laser with OFC (SL)"); + module_print_any_array_string_entry(pfx, "FC: Shortwave laser with OFC (SL)"); if (map->page_00h[SFF8636_FC_TECH_OFFSET] & SFF8636_FC_TECH_LONG_LL) - sprintf(value, "%s", "FC: Longwave laser (LL)"); + module_print_any_array_string_entry(pfx, "FC: Longwave laser (LL)"); /* Fibre Channel transmission media */ if (map->page_00h[SFF8636_FC_TRANS_MEDIA_OFFSET] & SFF8636_FC_TRANS_MEDIA_TW) - sprintf(value, "%s", "FC: Twin Axial Pair (TW)"); + module_print_any_array_string_entry(pfx, "FC: Twin Axial Pair (TW)"); if (map->page_00h[SFF8636_FC_TRANS_MEDIA_OFFSET] & SFF8636_FC_TRANS_MEDIA_TP) - sprintf(value, "%s", "FC: Twisted Pair (TP)"); + module_print_any_array_string_entry(pfx, "FC: Twisted Pair (TP)"); if (map->page_00h[SFF8636_FC_TRANS_MEDIA_OFFSET] & SFF8636_FC_TRANS_MEDIA_MI) - sprintf(value, "%s", "FC: Miniature Coax (MI)"); + module_print_any_array_string_entry(pfx, "FC: Miniature Coax (MI)"); if (map->page_00h[SFF8636_FC_TRANS_MEDIA_OFFSET] & SFF8636_FC_TRANS_MEDIA_TV) - sprintf(value, "%s", "FC: Video Coax (TV)"); + module_print_any_array_string_entry(pfx, "FC: Video Coax (TV)"); if (map->page_00h[SFF8636_FC_TRANS_MEDIA_OFFSET] & SFF8636_FC_TRANS_MEDIA_M6) - sprintf(value, "%s", "FC: Multimode, 62.5m (M6)"); + module_print_any_array_string_entry(pfx, "FC: Multimode, 62.5m (M6)"); if (map->page_00h[SFF8636_FC_TRANS_MEDIA_OFFSET] & SFF8636_FC_TRANS_MEDIA_M5) - sprintf(value, "%s", "FC: Multimode, 50m (M5)"); + module_print_any_array_string_entry(pfx, "FC: Multimode, 50m (M5)"); if (map->page_00h[SFF8636_FC_TRANS_MEDIA_OFFSET] & SFF8636_FC_TRANS_MEDIA_OM3) - sprintf(value, "%s", "FC: Multimode, 50um (OM3)"); + module_print_any_array_string_entry(pfx, "FC: Multimode, 50um (OM3)"); if (map->page_00h[SFF8636_FC_TRANS_MEDIA_OFFSET] & SFF8636_FC_TRANS_MEDIA_SM) - sprintf(value, "%s", "FC: Single Mode (SM)"); + module_print_any_array_string_entry(pfx, "FC: Single Mode (SM)"); /* Fibre Channel speed */ if (map->page_00h[SFF8636_FC_SPEED_OFFSET] & SFF8636_FC_SPEED_1200_MBPS) - sprintf(value, "%s", "FC: 1200 MBytes/sec"); + module_print_any_array_string_entry(pfx, "FC: 1200 MBytes/sec"); if (map->page_00h[SFF8636_FC_SPEED_OFFSET] & SFF8636_FC_SPEED_800_MBPS) - sprintf(value, "%s", "FC: 800 MBytes/sec"); + module_print_any_array_string_entry(pfx, "FC: 800 MBytes/sec"); if (map->page_00h[SFF8636_FC_SPEED_OFFSET] & SFF8636_FC_SPEED_1600_MBPS) - sprintf(value, "%s", "FC: 1600 MBytes/sec"); + module_print_any_array_string_entry(pfx, "FC: 1600 MBytes/sec"); if (map->page_00h[SFF8636_FC_SPEED_OFFSET] & SFF8636_FC_SPEED_400_MBPS) - sprintf(value, "%s", "FC: 400 MBytes/sec"); + module_print_any_array_string_entry(pfx, "FC: 400 MBytes/sec"); if (map->page_00h[SFF8636_FC_SPEED_OFFSET] & SFF8636_FC_SPEED_3200_MBPS) - sprintf(value, "%s", "FC: 3200 MBytes/sec"); + module_print_any_array_string_entry(pfx, "FC: 3200 MBytes/sec"); if (map->page_00h[SFF8636_FC_SPEED_OFFSET] & SFF8636_FC_SPEED_200_MBPS) - sprintf(value, "%s", "FC: 200 MBytes/sec"); + module_print_any_array_string_entry(pfx, "FC: 200 MBytes/sec"); if (map->page_00h[SFF8636_FC_SPEED_OFFSET] & SFF8636_FC_SPEED_100_MBPS) - sprintf(value, "%s", "FC: 100 MBytes/sec"); + module_print_any_array_string_entry(pfx, "FC: 100 MBytes/sec"); - module_print_any_string(pfx, value); + if (is_json_context()) + close_json_array(""); } static void sff8636_show_encoding(const struct sff8636_memory_map *map) -- 2.53.0