From: Doruk Tan Ozturk <doruk@0sec.ai>
To: david@ixit.cz, horms@kernel.org
Cc: oe-linux-nfc@lists.linux.dev, hexlabsecurity@proton.me,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net] nfc: fdp: bound the device-supplied read size in fdp_nci_i2c_read()
Date: Mon, 20 Jul 2026 15:21:33 +0200 [thread overview]
Message-ID: <20260720132133.69635-1-doruk@0sec.ai> (raw)
In-Reply-To: <879ab436-043a-450d-87c0-70e7c6f4ff8f@ixit.cz>
On 20/07/2026, David Heidelberg wrote:
> I agree, I was looking at this patch yesterday and the current format
> feels unfavorable. Please send next revision with Simon suggestion :)
Will do. One heads-up before I resend: Bryam Vargas posted a v2 for the
same bug back in June [1] that is more complete than mine. It also
rejects len < FDP_NCI_I2C_MIN_PAYLOAD (the lower bound Simon flagged,
reachable via the u16 truncation) and fixes an skb leak in the same
loop, with a KASAN reproducer, and it carries Simon's Suggested-by. It
looks like it just stalled.
If you would rather pick that one up, it covers more than mine does.
Happy to send my (narrower) v2 with Simon's suggestion if you prefer it
instead, just let me know.
-Doruk
[1] https://lore.kernel.org/all/20260616-b4-disp-b1f8ab4c-v2-1-2d1fe5955325@proton.me/
prev parent reply other threads:[~2026-07-20 13:21 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-11 12:36 [PATCH net] nfc: fdp: bound the device-supplied read size in fdp_nci_i2c_read() Doruk Tan Ozturk
2026-07-20 10:16 ` Simon Horman
2026-07-20 10:19 ` David Heidelberg
2026-07-20 13:21 ` Doruk Tan Ozturk [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260720132133.69635-1-doruk@0sec.ai \
--to=doruk@0sec.ai \
--cc=david@ixit.cz \
--cc=hexlabsecurity@proton.me \
--cc=horms@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=oe-linux-nfc@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox