From: Ido Schimmel <idosch@nvidia.com>
To: Fernando Fernandez Mancera <fmancera@suse.de>
Cc: netdev@vger.kernel.org, horms@kernel.org, pabeni@redhat.com,
kuba@kernel.org, edumazet@google.com, davem@davemloft.net,
dsahern@kernel.org
Subject: Re: [PATCH 1/3 net-next] ipv4: remove unnecessary reset of position pointer
Date: Tue, 21 Jul 2026 14:39:50 +0300 [thread overview]
Message-ID: <20260721113950.GA2592863@shredder> (raw)
In-Reply-To: <20260716203713.17392-2-fmancera@suse.de>
On Thu, Jul 16, 2026 at 10:37:11PM +0200, Fernando Fernandez Mancera wrote:
> The position pointer is only advanced if the return value of the proc
> handler is positive at new_sync_write(). Therefore no need to manually
> reset it when doing error handling.
>
> Signed-off-by: Fernando Fernandez Mancera <fmancera@suse.de>
Reviewed-by: Ido Schimmel <idosch@nvidia.com>
next prev parent reply other threads:[~2026-07-21 11:40 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-16 20:37 [PATCH 0/3 net-next] Misc. minor improvements on IPv4/IPv6 sysctl handling Fernando Fernandez Mancera
2026-07-16 20:37 ` [PATCH 1/3 net-next] ipv4: remove unnecessary reset of position pointer Fernando Fernandez Mancera
2026-07-21 11:39 ` Ido Schimmel [this message]
2026-07-16 20:37 ` [PATCH 2/3 net-next] ipv6: " Fernando Fernandez Mancera
2026-07-21 11:40 ` Ido Schimmel
2026-07-16 20:37 ` [PATCH 3/3 net-next] ipv6: add CAP_NET_ADMIN check for forwarding and force_forwarding sysctl Fernando Fernandez Mancera
2026-07-21 12:24 ` Ido Schimmel
2026-07-21 13:46 ` Fernando Fernandez Mancera
2026-07-21 18:05 ` Ido Schimmel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260721113950.GA2592863@shredder \
--to=idosch@nvidia.com \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=edumazet@google.com \
--cc=fmancera@suse.de \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox