Netdev List
 help / color / mirror / Atom feed
From: Jakub Kicinski <kuba@kernel.org>
To: Weiming Shi <bestswngs@gmail.com>
Cc: Jon Maloy <jmaloy@redhat.com>,
	Tung Quang Nguyen <tung.quang.nguyen@est.tech>,
	"David S . Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	Paolo Abeni <pabeni@redhat.com>, Simon Horman <horms@kernel.org>,
	Xiang Mei <xmei5@asu.edu>,
	netdev@vger.kernel.org, tipc-discussion@lists.sourceforge.net,
	linux-kernel@vger.kernel.org, stable@vger.kernel.org
Subject: Re: [PATCH net v3] tipc: fix NULL deref in tipc_lxc_xmit() on node up
Date: Tue, 21 Jul 2026 11:59:12 -0700	[thread overview]
Message-ID: <20260721115912.7438f90d@kernel.org> (raw)
In-Reply-To: <20260709144718.64535-2-bestswngs@gmail.com>

On Thu,  9 Jul 2026 07:47:19 -0700 Weiming Shi wrote:
> tipc_named_node_up() builds a bulk of this node's cluster-scope service
> bindings for a peer that just came up and sends it with tipc_node_xmit().
> Neither step tolerates an empty skb chain: named_distribute() finishes
> with buf_msg(skb_peek_tail(list)) to tag the last message, and for a
> same-host peer tipc_node_xmit() routes into tipc_lxc_xmit(), which reads
> buf_msg(skb_peek(list)). skb_peek*() returns NULL on an empty chain, so
> buf_msg(NULL) faults.

This patch has been sitting in PW for 2 weeks, due to maintainers being
on vacation. Please repost if it's still relevant.
-- 
pw-bot: defer

      reply	other threads:[~2026-07-21 18:59 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-09 14:47 [PATCH net v3] tipc: fix NULL deref in tipc_lxc_xmit() on node up Weiming Shi
2026-07-21 18:59 ` Jakub Kicinski [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260721115912.7438f90d@kernel.org \
    --to=kuba@kernel.org \
    --cc=bestswngs@gmail.com \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=horms@kernel.org \
    --cc=jmaloy@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=stable@vger.kernel.org \
    --cc=tipc-discussion@lists.sourceforge.net \
    --cc=tung.quang.nguyen@est.tech \
    --cc=xmei5@asu.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox