From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f170.google.com (mail-pl1-f170.google.com [209.85.214.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AEF7144CF29 for ; Tue, 21 Jul 2026 22:19:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.170 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784672372; cv=none; b=bBcc+3Q0Nirtm9d6aAZvqJtadQ4WzkPlzzmmSpSAXZMkVNe4tLyxLxnMfZYr9nzB9DAnEfooJ6BhrfyAkVSTkoCvGr0XvyaH5KMVhiCvNeD5JGoycCcxqKk9A1/qF9bFnMgtysVM2Lc9Y2lCPR2aQQK2E3VKtA5dCGAVNoXPYew= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784672372; c=relaxed/simple; bh=rjlTEXfdGtvamgGrl7WmwFapvU6eayCx3eM576nYxlo=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=VB3PUJDALb00jyFtdQa9aZTQPcMJBbdOCpb2lUIxYMuQcbQXYo2fdS/jj8OGRAxV18+Kkv97+hTDwfJVe2UGGkvrzEZRI51Uf5kYMyRDQ7GjvK7Xp09Qi8Q92O97LJ5+Hh7N7xz9W1j0RXDYh1rAdrQLDSDjiLh4QI5lp9XfIVc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=gwcfOAv4; arc=none smtp.client-ip=209.85.214.170 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="gwcfOAv4" Received: by mail-pl1-f170.google.com with SMTP id d9443c01a7336-2ced3386430so81338565ad.1 for ; Tue, 21 Jul 2026 15:19:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1784672371; x=1785277171; darn=vger.kernel.org; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:date:subject:cc:to:from:from:to:cc:subject :date:message-id:reply-to:content-type; bh=lbofz4e3dpgzQEO5qCd561u75f1n6ZeFDPzk/MT4UfI=; b=gwcfOAv4wAmBnW8AZJCQKTRGKBD0BFgsdzA/ouH5vnv2xcIiWUUs4k+lIwDHJpZRGD W1zRI7FCIMiVYd0ht9K+jF87Y1Nn9cXswhsEu09A/6kEdVw9WcZtnQi2pZeS3BX7eo+Z P/KX1y26ZNgNzKxMJeH3kEnYDj3LAFbxCYGwu8mIDJXb0mSGVWTL2zXikSh4Qx6HlPaj CJs+g2wSAF9Pi/789+3biE9GLnVqDIqUufnORrktKFgt7YkhUkKiR7OVxzdPPQVnbzzT eAAWlT9Dk4LYz6hm5oaSYyIlwRJU6/fcl2lzeCYxWTNqvm89B/5ItqJRROkGqfo5Xc3N wGbw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784672371; x=1785277171; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:date:subject:cc:to:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=lbofz4e3dpgzQEO5qCd561u75f1n6ZeFDPzk/MT4UfI=; b=eMdD/pUFFuVSoBKNJE0JpsDnMermJNYcK9sQ5I8WHq7gYNcWTpRZKmWwaBAGDV6P4n lpEgb10k8kfdZtl6Zg768yXft+BdwAbxM/Dza+e7zzS2GJhrf0JPvJR/NaGvAMuQYVen u8IrUW40Z1yJVmpguOfJLI9jn1xVvWnqZyIp7MTldpXNttRrrloTok8DJ4hkIBlbW/TW v+F7HeUPvNnYRpnp4RX27KJa1vGSzXGdUkzwMLJEma+p8NnqeUmtHkKhSN2qziJ/iPHp KcoxlEbh6Vn2DDJkl0fNjI3yRFghSX5s6r718G62854dfHf+OBn99jVzpg/9+mpU3wnH QSMQ== X-Forwarded-Encrypted: i=1; AHgh+RrsaItj7oxLHr09kGEnJD+7uCRmkDXvJeofSOWErwhOsGP/wrWDB/U2KXgVuywAjH75p0fkkSQ=@vger.kernel.org X-Gm-Message-State: AOJu0Yz8Se3lyZ4LL4A5my/izaV/YaSxIFHNg8ZsHFM7I8YLx24Xn01o irzXl1F306l/82RqPXrLIHk7EYDC/ApecbEdWvAZfG60xlsEzJvAdSxp X-Gm-Gg: AR+sD12Y90DSvefu3TzHljl6jrEdF5xdIxkPN1BVlb9ZbNH9P9hWaAtpUNhwSwNF2cn QL20eCgf7SOAclXGJR0dRUF5MxFpyXmCI+nWXK+KzUWOQaJQLCGzXhmlHdoz4SmChim+DmhgLS8 zbjkZzmaaAYcVHuH9QYwc0bOzLl+ugjbC3dlZodozG7TIzNzIGNTnS2vrELPKkrDutbTbGvE7b0 p8bwNb6qqIw3KXPpN3HIG4zUYBWzhoJXShJ5dvggsUxdwhERJqnehr3taA0OUxy9zYSm98hceGl ZYf20iBvR6t1RJJlLyke6dYbiEwTsrx10b5NIwEb1rfbTQjqGFgsS9Q3hNvHaP46xQVuQptDc/G bhq2P+GU7bnvGS+zbLT4IC0vu8An01fNjIXh2iUQxNrW2/h3+S44scrAmMyplbnZB+TH3ig7LU3 zhVkVbx26uEDxlMyxFa9dQkqC9pr7NNU9MbZc= X-Received: by 2002:a17:903:1b2e:b0:2cb:3f63:7c3e with SMTP id d9443c01a7336-2cf34997d46mr219668105ad.35.1784672371023; Tue, 21 Jul 2026 15:19:31 -0700 (PDT) Received: from CPC-mjac-HKWGEZ.redmond.corp.microsoft.com ([70.37.26.34]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2cf8efae5aesm3657535ad.15.2026.07.21.15.19.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 21 Jul 2026 15:19:30 -0700 (PDT) From: Jack Ma To: Ido Schimmel , netdev@vger.kernel.org Cc: David Ahern , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman , Shuah Khan , linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, Jack Ma Subject: Re: [PATCH net-next v2 2/3] vxlan: honor per-nexthop fdb destination port Date: Tue, 21 Jul 2026 22:19:06 +0000 Message-ID: <20260721221907.2702-2-jack4it@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260721151805.GB2667735@shredder> References: <20260717-b4-vxlan-fdb-port-v2-0-f4862e8fe867@gmail.com> <20260717-b4-vxlan-fdb-port-v2-2-f4862e8fe867@gmail.com> <20260721151805.GB2667735@shredder> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit On Tue, Jul 21, 2026 at 06:18:05PM +0300, Ido Schimmel wrote: > Alignment is off Fixed for v3. The "int hash" and "__be16 *fdb_port" continuation lines now align under the first argument (the column just after the opening paren) in nexthop_path_fdb_result(). > Remove the check given 'fdb_port' is never NULL? Done for v3. Dropped the "if (fdb_port)" guard; the only caller, vxlan_fdb_nh_path_select(), always passes the address of an on-stack __be16, so the store is unconditional now: nhi = rcu_dereference(nhp->nh_info); *fdb_port = nhi->fdb_port; return &nhi->fib_nhc; Thanks, Jack