Netdev List
 help / color / mirror / Atom feed
From: Jakub Kicinski <kuba@kernel.org>
To: Aaron Conole <aconole@redhat.com>
Cc: houminxi@gmail.com, netdev@vger.kernel.org, davem@davemloft.net,
	edumazet@google.com, pabeni@redhat.com, i.maximets@ovn.org,
	echaudro@redhat.com
Subject: Re: [net-next,v4] selftests/net/openvswitch: add SCTP flow key test
Date: Wed, 22 Jul 2026 12:55:28 -0700	[thread overview]
Message-ID: <20260722125528.0f192cca@kernel.org> (raw)
In-Reply-To: <f7to6g1q1ct.fsf@redhat.com>

On Mon, 20 Jul 2026 08:42:10 -0400 Aaron Conole wrote:
> > +# sctp_connect_v4 test
> > +# - sctp(dst=4443) matches client-to-server INIT
> > +# - sctp(src=4443) matches server-to-client INIT-ACK
> > +# - remove flows and verify connection fails, reinstall and recover
> > +test_sctp_connect_v4() {
> > +	local t="test_sctp_connect_v4"
> > +
> > +	which nc >/dev/null 2>&1 || return $ksft_skip
> > +	nc --sctp -z 127.0.0.1 1 </dev/null 2>/dev/null || return $ksft_skip  
> 
> This can probably be instead::
> 
>   nc --help 2>&1 | grep -q -- --sctp || return $ksft_skip
> 
> This reads nicer to detect SCTP support in 'nc' binary.

Can we use socat ? nc incompatibilities are hard to deal with.

      reply	other threads:[~2026-07-22 19:55 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-19 16:26 [PATCH net-next v4] selftests/net/openvswitch: add SCTP flow key test Minxi Hou
2026-07-20 12:42 ` [net-next,v4] " Aaron Conole
2026-07-22 19:55   ` Jakub Kicinski [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260722125528.0f192cca@kernel.org \
    --to=kuba@kernel.org \
    --cc=aconole@redhat.com \
    --cc=davem@davemloft.net \
    --cc=echaudro@redhat.com \
    --cc=edumazet@google.com \
    --cc=houminxi@gmail.com \
    --cc=i.maximets@ovn.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox