From: Fan Gong <gongfan1@huawei.com>
To: <dimitri.daskalakis1@gmail.com>
Cc: <andrew+netdev@lunn.ch>, <davem@davemloft.net>,
<edumazet@google.com>, <gongfan1@huawei.com>,
<guoxin09@huawei.com>, <horms@kernel.org>,
<hramamurthy@google.com>, <ioana.ciornei@nxp.com>,
<kuba@kernel.org>, <linux-doc@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <luosifu@huawei.com>,
<maxime.chevallier@bootlin.com>, <mohsin.bashr@gmail.com>,
<netdev@vger.kernel.org>, <pabeni@redhat.com>,
<shijing34@huawei.com>, <tengpeisen@huawei.com>,
<wudi234@huawei.com>, <wulike1@huawei.com>,
<zhengjiezhen@h-partners.com>, <zhoushuai28@huawei.com>,
<august.hewei@huawei.com>
Subject: Re: Re: [PATCH net-next v11 2/5] hinic3: Add ethtool statistic ops
Date: Thu, 23 Jul 2026 09:35:02 +0800 [thread overview]
Message-ID: <20260723013502.828-1-gongfan1@huawei.com> (raw)
In-Reply-To: <190879f9-2447-449d-acf8-9f9e26651b24@gmail.com>
> > +
> > +static u64 get_val_of_ptr(u32 size, const void *ptr)
> > +{
> > + u64 ret = size == sizeof(u64) ? *(u64 *)ptr :
> > + size == sizeof(u32) ? *(u32 *)ptr :
> > + size == sizeof(u16) ? *(u16 *)ptr :
> > + *(u8 *)ptr;
> > +
> > + return ret;
> > +}
> Why is this needed? It looks like all the counters in
> hinic3_rx_queue_stats, hinic3_tx_queue_stats, and hinic3_port_stats are
> u64.
Thanks for the review. We will remove it in the next patchset.
next prev parent reply other threads:[~2026-07-23 1:35 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-20 12:53 [PATCH net-next v11 0/5] net: hinic3: PF initialization Fan Gong
2026-07-20 12:53 ` [PATCH net-next v11 1/5] hinic3: Add ethtool queue ops Fan Gong
2026-07-21 18:07 ` Mohsin Bashir
2026-07-23 1:32 ` Fan Gong
2026-07-20 12:53 ` [PATCH net-next v11 2/5] hinic3: Add ethtool statistic ops Fan Gong
2026-07-21 19:21 ` Dimitri Daskalakis
2026-07-23 1:35 ` Fan Gong [this message]
2026-07-20 12:53 ` [PATCH net-next v11 3/5] hinic3: Add ethtool coalesce ops Fan Gong
2026-07-20 12:53 ` [PATCH net-next v11 4/5] hinic3: Add ethtool rss ops Fan Gong
2026-07-20 12:53 ` [PATCH net-next v11 5/5] hinic3: Remove unneeded coalesce parameters Fan Gong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260723013502.828-1-gongfan1@huawei.com \
--to=gongfan1@huawei.com \
--cc=andrew+netdev@lunn.ch \
--cc=august.hewei@huawei.com \
--cc=davem@davemloft.net \
--cc=dimitri.daskalakis1@gmail.com \
--cc=edumazet@google.com \
--cc=guoxin09@huawei.com \
--cc=horms@kernel.org \
--cc=hramamurthy@google.com \
--cc=ioana.ciornei@nxp.com \
--cc=kuba@kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luosifu@huawei.com \
--cc=maxime.chevallier@bootlin.com \
--cc=mohsin.bashr@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=shijing34@huawei.com \
--cc=tengpeisen@huawei.com \
--cc=wudi234@huawei.com \
--cc=wulike1@huawei.com \
--cc=zhengjiezhen@h-partners.com \
--cc=zhoushuai28@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox