From: Jakub Kicinski <kuba@kernel.org>
To: bh74.an@samsung.com
Cc: Chenguang Zhao <chenguang.zhao@linux.dev>,
andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com,
pabeni@redhat.com, netdev@vger.kernel.org,
Chenguang Zhao <zhaochenguang@kylinos.cn>
Subject: Re: [PATCH net v3 0/2] net: sxgbe: fix descriptor ring allocation failure handling
Date: Thu, 23 Jul 2026 06:42:42 -0700 [thread overview]
Message-ID: <20260723064242.58d58526@kernel.org> (raw)
In-Reply-To: <20260723021820.203960-1-chenguang.zhao@linux.dev>
On Thu, 23 Jul 2026 10:18:18 +0800 Chenguang Zhao wrote:
> init_dma_desc_rings() leaks already-allocated TX rings
> when RX allocation fails, and sxgbe_open() ignores its
> return value and continues with invalid DMA rings. Fix
> the cleanup path and check the error.
Byungho An, please review.
prev parent reply other threads:[~2026-07-23 13:42 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-23 2:18 [PATCH net v3 0/2] net: sxgbe: fix descriptor ring allocation failure handling Chenguang Zhao
2026-07-23 2:18 ` [PATCH net v3 1/2] net: sxgbe: free TX rings on RX allocation failure Chenguang Zhao
2026-07-23 10:07 ` Vadim Fedorenko
2026-07-23 2:18 ` [PATCH net v3 2/2] net: sxgbe: check descriptor ring allocation failures Chenguang Zhao
2026-07-23 10:11 ` Vadim Fedorenko
2026-07-23 13:42 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260723064242.58d58526@kernel.org \
--to=kuba@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=bh74.an@samsung.com \
--cc=chenguang.zhao@linux.dev \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=zhaochenguang@kylinos.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox